Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp739303lqa; Sun, 28 Apr 2024 01:54:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWdlAhUviQ5nWs26QjY83OGecyvdQwmptrxHuDbuVwszpVGpNT4d5YPzXWDR7v87WWC0378Dh70csQGtItxPNn516gis37BUH5RxA+4dQ== X-Google-Smtp-Source: AGHT+IFzivrTLoIg+aiQ6N6M1GaBAEnakvryYYlLN2ZxJATDldq83EMMzvxgFopa1RGGU0EHtqCb X-Received: by 2002:a17:90a:480b:b0:2a5:3399:b703 with SMTP id a11-20020a17090a480b00b002a53399b703mr6999920pjh.11.1714294444011; Sun, 28 Apr 2024 01:54:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714294443; cv=pass; d=google.com; s=arc-20160816; b=s25cRHLjo50uxeSJMR7AnxdcAvBN3+aV/PnningunQ4mmqjH8rePlKQTSY+Kq9AJ7C IKSzGryB+QMoBWEo4JnYDPkjpqNzp/xh7jjafBggkS40heQxiCi010mq4lz4u8l6q1SA Gnwv2CFC99Rh2foOlaoYz7DuPKkMC04ls4032LPnAj3fbfSccWUYUbXcR9ooYpczPWit 5yNWsHmFTU+oP2OFgp1EDQpakLUJxD51VlDxRpb6cqzSO/2BvcKrAzi837C2RFYwdMoA r7a3SvzMKL+A89GiqHq1CyLKHSKmXOywUraU4fS4m9n+DVMc3Z8O7XRsc0gIpxLiuAaY IWJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=4FYYvXtebx1umtlWiVHfZrloGyYitjsrHCQowXGs9fI=; fh=1sIoSkC+E45ImpDmgfnuuvoRq+J/Tfjb1AmmPr6HVwg=; b=0EH9qBP+ee+mStonBYCUkZxnkKfffT5TdBkgGj7g1KcSkh/Qu1A0vMoCUIeyvxTrmY C4mNrEW3t7VQhDe0wO2J8L4DKvjOangLa1uLdluqPi1uteklRjYEU1Bpta13ORx9NP7y 60NPpmV0VohxWPhAXmx8LCEUWUbYd+rjz7gr5zho4xytZ/LTHlYIhkxUsRmYgq80We6i Dk+tRQ8qHU1NiiqSbs7gSutmEzGB85trM8b6jC2n9gO7Tizu74cVB1L562+nJX8atAmU 2zYmnN8BvBmVqZ4ZUEG9j6Tgo5NtilusOWpBXGXmIl3dDwTQFvCsuVWyK292KT76j2Ds zghQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=CCrJIi0H; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-161333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161333-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u5-20020a17090a4bc500b002a236850fafsi17700700pjl.29.2024.04.28.01.54.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 01:54:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-161333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=CCrJIi0H; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-161333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161333-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 84036281C3D for ; Sun, 28 Apr 2024 08:54:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0227C54BDE; Sun, 28 Apr 2024 08:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="CCrJIi0H" Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E690F516; Sun, 28 Apr 2024 08:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714294435; cv=none; b=OPDD5IJ7pFUONa9AtG5ph2RdXOnlIZysr0PAcDmAyFfThwzh49RXsJSeT06a8PMNwg5DfTYGfEum0rnwYEIOL11YCKGsU0Xwp/WXKpOoOJeG90BpJyq2wPsDrMbdKURcKWEpVJHNhI+xEWc1/cybgoqOYTsCBpGtmDV+Txry1zM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714294435; c=relaxed/simple; bh=4FYYvXtebx1umtlWiVHfZrloGyYitjsrHCQowXGs9fI=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=Jxt+9YtD15Hn7MpWbo0zVLo7oXm/+WeWzsi8nf0oewp4jUk9VKJXWWApNQD2RgUgj7tL4+DwlLg+VMSgbNtVGb5Uh86YvLmA9fBJQo5Ii3LExY1gCcZIoqW1RobMF4w8dKe5LX6UAM+dgNB7KM87lK+hh82+tyvlY3ZsGNs1RkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=CCrJIi0H; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1714294376; x=1714899176; i=markus.elfring@web.de; bh=4FYYvXtebx1umtlWiVHfZrloGyYitjsrHCQowXGs9fI=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=CCrJIi0H7wex0VAQlUYa364LXPoHUrA6nAduJ9ESJJxiOw8J2/yYP9V3clzIPoRQ iu5/YxerI3ByPssPVl3gb/8n4GWV/NfZbROp1Qpb+NvxYdAXxPYPfa+S8u9UdgHr2 An71vl+7V9OVPfKNxW5HMYjcYzEcoLJyeCPQrViSZhcG47lCf3TEmKG6P+MF0mjpu yANFhxEM78hjbCQxPornZ940BPlomRsAJtr64MnR0XJS9zgx9Y/2GTt5lCNwKTIRI YxBzYo6WwAjvItHIJwVMesMbGU7pHyWgm6tcs9G2yewF1fMsjun8QHv+b3FBqbJbb qRscDh68Q3+YZ3GVvw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MD5nx-1rsVx30pgf-006C1H; Sun, 28 Apr 2024 10:52:56 +0200 Message-ID: Date: Sun, 28 Apr 2024 10:52:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: LuMingYin Cc: LuMingYin , LKML , kernel-janitors@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra References: <20240323065550.603005-1-lumingyindetect@163.com> Subject: Re: [PATCH] tools: Fix a memory leak in disas_funcs() Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240323065550.603005-1-lumingyindetect@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MqzjkRcsUqvVBNQOED2Vv92dFj5+JzxkE0jQbNKBZ9ZzKiXfYPN SJECP5XGLImyQeU9VOeiDQJM1Kp28WfewNmXY8pZqzlj0KuGpaPcF/GkNMLt6t8UE+QhUDI QOX5Zxh6HwhIyWQ4JyjLl7Jn4b6+O7Cq/ntk7Za4rk10QmhkqaXcPZoOemDcSleVzLCHkl2 SSYwWul6vRX7nZnH0h/Sg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:bkOo4M0Swbc=;aACqtNQQJFJaO2T5PWnZjNW02eC td5qCHWqQ4+Yzq/g7+MpNWYX4EFgkVKFbl4LyqvtK2RmvwBMvuuSxDrDsy+BTY6N2JNmx3rmS J1c0dLcmnj6c0hoXP0zPA+Yw52+PBUQ7u7P4TLznAnXTfkzdFBls4SDQ4QA3BAhLXQztFGC90 +oW9fZmXBy6eF6A4PTGue68G+hP2pip+YNmbhztRQ77YNWvYB4dfp4UhfAv/aY08Wc025qw23 Qlw7TPjikMLjNbSUyTxmefVLayEogW8b/A+IKyxuMKFm66YQiXlmIsP5nJplaq2V3l42rD8It w38zbdbLOQtEPs7C6AaernNWBq6c7g8K1XK27Xn65/+bQoKBkrZeOrue5kcwhr1wAKMPJElq9 DAhTxemwwzI4TnOj1y0oWYC52juAcfCy70jCagh8xECDqZvzjLhDJooCgIhjozOnCLlXwwvLE g2o1bwFKbcSqyuJc3YKlwuIezB++HVJ1tlPEe53skqUjNTITUywOYR5ZbpFKYmpyHYaytS/R8 PnfULofLhrmvMzH+GAluIHGAM/8VWLVgt8/PbGL5dsqZx+AnmWE4jVlD1zZn59PhLKzhFYeMz bUUuGyCariNXQdL7hu9qy/gA8AdNfULHydWqYKvYGDG6kLmIE8i01+f+6XlEjETUIY2P+QbYf GczrwVOOo6PDy4b2dRZ5RVZKE9Gxv2sxN8/EVYHeeMtCLo6PIPCTnwwmRTZxDRi52KX8GEEdA TtrT+Eb3mU7m6i1HUH5EGG1SrzlpSYneW9O43OIBmxAdm3JjWMUbvcyJjigR5yLIHkaK9+9PV /12T7eUoZdgtpM0CIsXo2B+la6it41raCTojZdrpaE+Vs= =E2=80=A6 > However, after using the memory area pointed to by 'cmd' (line 4619), it= is not deallocated, resulting in a memory leak bug. This commit fixes the= bug. Please take advices from known information sources better into account. * https://kernelnewbies.org/FirstKernelPatch * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?h=3Dv6.9-rc5#n3 I got the impression that Josh Poimboeuf answered your development concern= already. https://lore.kernel.org/lkml/20240323182209.xqzb6rsswvfbg74n@treble/ https://lkml.org/lkml/2024/3/23/285 Would you like to support faster execution of the mentioned program so that manual memory releases can be omitted so far? Did your email address change in the meantime? Regards, Markus