Received-SPF: pass (google.com: domain of linux-kernel+bounces-161397-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7f97aae7-557d-4fac-854b-594e99939598@kernel.org>
Date: Sun, 28 Apr 2024 19:23:19 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] f2fs:remove the restriction on zone sector being align to
 pow2
To: Liao Yuanhong <liaoyuanhong@vivo.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: bo.wu@vivo.com, linux-f2fs-devel@lists.sourceforge.net,
 linux-kernel@vger.kernel.org
References: <20240428111457.17224-1-liaoyuanhong@vivo.com>
Content-Language: en-US
From: Chao Yu <chao@kernel.org>
In-Reply-To: <20240428111457.17224-1-liaoyuanhong@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/4/28 19:14, Liao Yuanhong wrote:
> For zoned-UFS, sector size may not aligned to pow2, so we need to remove
> the pow2 limitation.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
>   drivers/md/dm-table.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index 41f1d731ae5a..823f2f6a2d53 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c

Hi, please discuss this in dm-devel@lists.linux.dev, thanks.

Thanks,

> @@ -1663,10 +1663,6 @@ static int validate_hardware_zoned(struct dm_table *t, bool zoned,
>   		return -EINVAL;
>   	}
>   
> -	/* Check zone size validity and compatibility */
> -	if (!zone_sectors || !is_power_of_2(zone_sectors))
> -		return -EINVAL;
> -
>   	if (dm_table_any_dev_attr(t, device_not_matches_zone_sectors, &zone_sectors)) {
>   		DMERR("%s: zone sectors is not consistent across all zoned devices",
>   		      dm_device_name(t->md));