Received-SPF: pass (google.com: domain of linux-kernel+bounces-161417-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 28 Apr 2024 14:15:11 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, 
	Patrice Chotard <patrice.chotard@foss.st.com>, Andi Shyti <andi.shyti@kernel.org>, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/15] i2c: st: use 'time_left' variable with
 wait_for_completion_timeout()
Message-ID: <uh2onuws3or5ikefsflvobijxhxxoersvdwtzcuu264efqjsk4@kbmmpue4wqb5>
References: <20240427203611.3750-1-wsa+renesas@sang-engineering.com>
 <20240427203611.3750-8-wsa+renesas@sang-engineering.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="v2id2b4lhcrh7vec"
Content-Disposition: inline
In-Reply-To: <20240427203611.3750-8-wsa+renesas@sang-engineering.com>


--v2id2b4lhcrh7vec
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Wolfram,

On Sat, Apr 27, 2024 at 10:35:59PM +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeo=
ut' to
> store the result of wait_for_completion_timeout() causing patterns like:
>=20
> 	timeout =3D wait_for_completion_timeout(...)
> 	if (!timeout) return -ETIMEDOUT;
>=20
> with all kinds of permutations. Use 'time_left' as a variable to make the=
 code
> self explaining.
>=20
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

I like the improvement in general and looking at this driver in more
detail this looks right.

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe
=20
--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--v2id2b4lhcrh7vec
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYuPc4ACgkQj4D7WH0S
/k44DwgAtZhKVJj9zttG75ZuGtMUekDBwzS3shaaEzhuPTFiGDqNIvW1h9F8gYd5
eTYcl3CB1CQlLmyPjn2oQZWOMuXA7pxcT4dC4pjzEBxy265w5MTecW/27+gGnM9W
Efll3bOYAG3XWy52dz1XaysUsX4vco3pofeMPbI2XO17FGhFCAHwcs0mkgtISCHE
Gv6iIiUxgf3cY9UAfiGCPg5hugDhUbmy4Q+5pyDKWIySNqP7BgCXEGtF9zF4XLAw
LIJIAxqsRelpPGwXpOWI53grJlEo7BRziMp8I7wpPBIC1J07rx3u03VJFwh1vh13
J2j2bOT1JHM5aGd86m8TPqOdYa/RJg==
=iiGY
-----END PGP SIGNATURE-----

--v2id2b4lhcrh7vec--