Received-SPF: pass (google.com: domain of linux-kernel+bounces-161442-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 28 Apr 2024 14:46:06 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Marcelo Schmitt <marcelo.schmitt1@gmail.com>, Lars-Peter Clausen
 <lars@metafoo.de>, Andrew Hepp <andrew.hepp@ahepp.dev>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: temperature: mcp9600: Fix temperature reading for
 negative values
Message-ID: <20240428144606.5b3d9a7e@jic23-huawei>
In-Reply-To: <20240427195758.GA3350@debian>
References: <20240424185913.1177127-1-dima.fedrau@gmail.com>
	<Ziy8DsMCeAGK79E7@debian-BULLSEYE-live-builder-AMD64>
	<20240427195758.GA3350@debian>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sat, 27 Apr 2024 21:57:58 +0200
Dimitri Fedrau <dima.fedrau@gmail.com> wrote:

> Am Sat, Apr 27, 2024 at 05:49:18AM -0300 schrieb Marcelo Schmitt:
> > Hi Dimitri,
> >=20
> > Interesting patch this one.
> > I think this does apply, although, the cold junction register has for s=
ign bits
> > so I think we could also have a mask to clear those out.
> > Some code suggestions inline.
> > =20
> Hi Marcelo,
>=20
> the temperature bits are in two=E2=80=99s complement format for hot and c=
old
> junction. Equations to calculate the temperature are also the same in
> the datasheet. There should be no difference when handling them. I don't
> think we need to do anything more with the value except sign_extend it to
> the appropriate data type. If the sign bits aren't right, there is a bug
> in the chip, until then futher processing of it is unneeded. I could add
> a comment here if it helps.

Agreed - by my reading the original patch is correct. Maybe it would act
as cleaner 'documentation' to have the sign_extend32() for the cold junctio=
n be
from bit 12 rather than 15, but I'm not sure it's worth the effort.

Andrew, would be great if you can review this fix in case we are all missing
something!

Jonathan

>=20
> > On 04/24, Dimitri Fedrau wrote: =20
> > > Temperature is stored as 16bit value in two's complement format. Curr=
ent
> > > implementation ignores the sign bit. Make it aware of the sign bit by
> > > using sign_extend32.
> > >=20
> > > Fixes: 3f6b9598b6df ("iio: temperature: Add MCP9600 thermocouple EMF =
converter")
> > > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> > > ---
> > >  drivers/iio/temperature/mcp9600.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >=20
> > > diff --git a/drivers/iio/temperature/mcp9600.c b/drivers/iio/temperat=
ure/mcp9600.c
> > > index 46845804292b..7a3eef5d5e75 100644
> > > --- a/drivers/iio/temperature/mcp9600.c
> > > +++ b/drivers/iio/temperature/mcp9600.c =20
> >=20
> > #define MCP9600_COLD_JUNCTION_SIGN_MSK GENMASK(15,12)
> > ...
> >  =20
> > > @@ -52,7 +52,8 @@ static int mcp9600_read(struct mcp9600_data *data,
> > > =20
> > >  	if (ret < 0)
> > >  		return ret;
> > > -	*val =3D ret;
> > > +
> > > +	*val =3D sign_extend32(ret, 15); =20
> > 	if (chan->address =3D=3D MCP9600_COLD_JUNCTION)
> > 		*val &=3D ~MCP9600_COLD_JUNCTION_SIGN_MSK;
> > =20
> This won't work. Assuming int is 32-bit ret =3D 0xfffe and *val =3D -2 af=
ter
> sign_extends32, this would result in *val =3D -61442 which is wrong.
> > > =20
> > >  	return 0;
> > >  }
> > > --=20
> > > 2.39.2
> > >=20
> > >  =20
> Best regards,
> Dimitri Fedrau