Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760448AbYA1Kpb (ORCPT ); Mon, 28 Jan 2008 05:45:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752532AbYA1KpR (ORCPT ); Mon, 28 Jan 2008 05:45:17 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:54237 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615AbYA1KpP (ORCPT ); Mon, 28 Jan 2008 05:45:15 -0500 Date: Mon, 28 Jan 2008 11:44:59 +0100 From: Ingo Molnar To: Dmitri Vorobiev Cc: Paolo Ciarrocchi , Linux Kernel , Sam Ravnborg Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2 Message-ID: <20080128104459.GA32342@elte.hu> References: <20080127231527.2ea40804@paolo-desktop> <479D067E.3010100@gmail.com> <20080127224258.GA22018@elte.hu> <4d8e3fd30801271448ja6a44ferbf86d37c2f3b825@mail.gmail.com> <4d8e3fd30801271557i4310bc07ifbdea081001cc592@mail.gmail.com> <479D1FD1.2070105@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <479D1FD1.2070105@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 28 * Dmitri Vorobiev wrote: > Paolo Ciarrocchi пишет: > > On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi wrote: > >> On Jan 27, 2008 11:42 PM, Ingo Molnar wrote: > ... > > > > How should I compare the .o file? > > Simply doing a md5sum or should I do a objdump -d before? > > Or a strip? > > > > Comparing the vmlinux images shoudls suffice. But you'll have to make > sure that the object file resulting from the C source that you're > changing gets linked into vmlinux. the vmlinux includes build timestamps so that wont really match. Would be nice to have a build mode that results in a constant vmlinux image. (as long as the .config and the build environment is constant as well) Sam, would this be hard to add? :-) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/