Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp857567lqa; Sun, 28 Apr 2024 07:19:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWVqRkxwqtm7vuIt8BUdI9ipx7hTXmb755lCrS5yg8YmHi/XPk3cK95GkHNeXnqmh2MdJc6UfKY40fY+kYiR5DyUWht48FVc58nCDq/nQ== X-Google-Smtp-Source: AGHT+IELrDz/Ua/VzSgCxtng78DWBDx2N7JKmMoSER7rsGz8LC7UxurU6YBTw7APs+bwxX05mxgO X-Received: by 2002:a17:907:780c:b0:a52:53f2:5ae0 with SMTP id la12-20020a170907780c00b00a5253f25ae0mr5107689ejc.74.1714313955291; Sun, 28 Apr 2024 07:19:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714313955; cv=pass; d=google.com; s=arc-20160816; b=rR9f+8euNMYMGvmKFg0RJoAmFC3SLMCTsTNHRAgkW18TknadATwYKmByE2JJShAjy1 RLSuHfG+wdbdN7iDuGrlJd1Z0V3i8DcE4wNHATtbOA0oja08bCy40nAdlsxs9Rl0Nd0c aafoBTiLksuuOZoOOIwGaZTffY8zWydAltDYEpBEpnUwIWFZ3dYffCrg10yItjTh44jm ksAsvkOPWCyFl2pj+Ommv4r5OMz6LM19EYAsapy8wqmcat9bedNZE6lUhVuKVges69RT khwzxddOXamHgBDpCQkSCB/u18p66mKD1Xhlm2pba6/Co6REyR9m4vLb0tUmJfeX7L5n c07g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=j6mO3t3hnXaOiB5ZOyq1t92l086TzpvYq+MdS6plQWk=; fh=pfFrlfXiCsgV/idJaOiy83ENDJ3ICedBEA7atztuk+g=; b=lKnT9Rcr9iVMzicDf7Hsd1s5YoJM0SMz3kx7LEWwV1QHIWezUYioCsToEyUsMlaja5 ccgPQcl5InW3ssTrIfBAORYdjnEMtqupI06c1HUJIynyUEb2BYxOOIkmcTzKqPftfqJx fVD65V59H8P0hMu2urotHHgw1ERw1sBqcEwFR2v5+qjc/YTGzZZEliuGGvuEdmQ87fZV 0JjOqeBHmAvt7l77DVOymS0sw20gXvPORGJVJtkHKM1c6YK27+H2IALoP3u4f7pVfTKh NjayZzN0i2XrJab5F+xk97VbX1s/LFTolofPbJTWfVwP7B76m0SfmP/zlwygz2YE3wZL xH6g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=GOg3ME0z; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-161449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161449-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id kq19-20020a170906abd300b00a587342f7b5si2651840ejb.332.2024.04.28.07.19.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 07:19:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-161449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=GOg3ME0z; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-161449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161449-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D371D1F21422 for ; Sun, 28 Apr 2024 14:19:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95F0B6EB72; Sun, 28 Apr 2024 14:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="GOg3ME0z" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D09A1C32; Sun, 28 Apr 2024 14:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714313941; cv=none; b=dpizvktWWvwvoOMxVHxiCZ8lfO1ZJ1X4CoRbcNqiJRIy8qC9A1LR8zOByhsFEIoXQb46yREhHeij7W6xNmaG0rGZ7fif9V6HjMjC5h4wlhZxEqStksOfFi0pXGbbjvpwsaPYZhWEpW8P6W7fm6ffXSDSrWWf6Sfjv4m7zlMIo6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714313941; c=relaxed/simple; bh=JbWX6i63EYM5psOXDzYgilWhkDBrAtxvEknNfrhURvE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jReCmNBn2Ge0dw2Dfq8bx2CEKpChOMvfYx8cv4oNQtGAcwbyUc3aihsD1+Pvlxmck8c9R5Y51XBTUGoUNZCTrOcZV0zrtwXL6dDrqOzJT1sbYo43Lf0UgCFgTdfX0EjTdNv/v9x5PoUVvd68yQhxxJwlRi64ykrvrONxrgymcag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=GOg3ME0z; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=j6mO3t3hnXaOiB5ZOyq1t92l086TzpvYq+MdS6plQWk=; b=GOg3ME0zdqZ2wRfYjLhv72GDsS QX6SQfH3KClLIVVi9Hzd8OZdGlRsAg+zPs7VzTZB46j9ii3g0TZU3PTtIEkdSupe7QBNOTre7J66T EmNrxiOxOvMxlMuR87WP1xfEgb2+N5op8rmRmUIsyomN95x+YHyAjONt2+PzryHBqGv4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s15MV-00EBuz-MR; Sun, 28 Apr 2024 16:18:39 +0200 Date: Sun, 28 Apr 2024 16:18:39 +0200 From: Andrew Lunn To: =?iso-8859-1?Q?Ram=F3n?= Nordin Rodriguez Cc: Parthiban Veerasooran , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, horatiu.vultur@microchip.com, ruanjinjie@huawei.com, steen.hegelund@microchip.com, vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com, Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com, benjamin.bigler@bernformulastudent.ch Subject: Re: [PATCH net-next v4 11/12] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY Message-ID: <23f8b4a1-97fd-4d24-9486-3319d432d6e2@lunn.ch> References: <20240418125648.372526-1-Parthiban.Veerasooran@microchip.com> <20240418125648.372526-12-Parthiban.Veerasooran@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > but just compatible = "lan8650" does not work. The device tree binding says that is valid, so this needs fixing. Maybe copy max1111.c in hwmon: static const struct spi_device_id max1111_ids[] = { { "max1110", max1110 }, { "max1111", max1111 }, { "max1112", max1112 }, { "max1113", max1113 }, { }, }; MODULE_DEVICE_TABLE(spi, max1111_ids); static struct spi_driver max1111_driver = { .driver = { .name = "max1111", }, .id_table = max1111_ids, .probe = max1111_probe, .remove = max1111_remove, }; Interestingly, there is no compatible table. So the device tree binding probably should change, not require two compatibles for lan8651. Andrew