Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp860300lqa; Sun, 28 Apr 2024 07:25:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWA4LD7B49X7AteQPnmemtufg5n13LpSMGHzAZUv9+tYoJ+vN3JH5IPdm7/UKIkYXlJsa6reW3IYOQ7EkmDCzywucI4n/77w7KR8C5wtg== X-Google-Smtp-Source: AGHT+IFyKTonshg1D3Zerniq9GTRr+9x9wHpIuvFpMjMQcWmHQyPqdfPtVSHPsQDRWNkBmaExdlo X-Received: by 2002:a25:b31c:0:b0:de4:6c97:2156 with SMTP id l28-20020a25b31c000000b00de46c972156mr8302293ybj.39.1714314350810; Sun, 28 Apr 2024 07:25:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714314350; cv=pass; d=google.com; s=arc-20160816; b=EDkFRK/rKXd9rh7ntT6XgUkM9kD1LVSQaJ91qhyrhC8MYcv8XedSrNzkdzGSqRbjN/ ntICA3Ita4PPP8TiOAoERRXrvV29Y0sjBEAoYSqsv1WKNvQIum4YmKYyGEcxHNFRZ/dB VcydmNHC/c5AVE/Ks6rY97Y3zTSi+SEtnM+RgmYn+2boClUC0dHhr0KxJJPYeFsdyjuV xb4Zbi6KMz5/bKyrdGPn4w1VxpBocqWX/VvfdIu3OeoAKBt8Al8Au01dv8gEVVp8ZU1m QOxc2DLU84N09JlpW1JD7CWHdpgahqhG0axvE4jhfp/SwblQ3KYfTMC23UdQbqIdwUD0 qm/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M2ewwiL2pIG/9gVc441cLBbAgSNOqpkmdmS7M7cFcKk=; fh=pfFrlfXiCsgV/idJaOiy83ENDJ3ICedBEA7atztuk+g=; b=GoTa6/XLou51HLyVSPLBoC+lXdqu4DzZ9uyZIdi+N2qHcKwLf/XX/ExAFjfelMNqEA bW8h1WF+yfrrDk1981OT2hDPBhnGlm9gVxi7QPrKOkoB63v4PmEv6TiLW5Ysyv7Iao6c sS//paWGa3xFK04qYKzWZzvuexr7Cojnz2fTu1jj6hTm+S8vFEwn5UibpSAXeguZI6ok h+weQZ+kVjx+Dk95IRvRWG8zkQvDWZlmsbcjlA5DEmXYqmTOt4OqWzeuoimabPuVYAX/ zKaXdcVOvHcGwkU82KiTrI3CpNupSYpAwmdqXYYWBMwnO4lY9DJqAiit0tjBniYTlroN aWew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=PsybsRSJ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-161450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161450-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b10-20020ac87fca000000b0043addecf1c9si805285qtk.725.2024.04.28.07.25.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 07:25:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-161450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=PsybsRSJ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-161450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161450-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 852F51C20F2E for ; Sun, 28 Apr 2024 14:25:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 359016EB7D; Sun, 28 Apr 2024 14:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="PsybsRSJ" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C01F9AD52; Sun, 28 Apr 2024 14:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714314342; cv=none; b=UMNFsUXqtxgHq4bwF0XLWsMGvbTXT8v1OYXRBJBGE+8IzhEj8aTGS0bC1hSZH619gew4KK2okliFhpVljwtWIkFLZOvoD+8aESDs+KivaaYpN96iWlGVjF8tdzQtHaxA5JRs94nNPY+NBrOgAQM//HnLl1EtL35Ki2aCAri5iJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714314342; c=relaxed/simple; bh=lZxJrpNHn0XSynHk/uJrhAg3iT15StGrcBJXagCaH9Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DOuarzbh5njgD/7kLQvIb3pDDasTpqNfmgjaYSvrqW0/tuej1UkNApO9mbfeXYROqBhAtJEQViMJZknjrEghyV+DVqaqqjkbABXTLquZWPktRBZfEeAQ50jOnkKFpE7mU5yLYDuPRC8/pD7G19N7V6p+WyBbp7HQ0BJ1LMmZeJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=PsybsRSJ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=M2ewwiL2pIG/9gVc441cLBbAgSNOqpkmdmS7M7cFcKk=; b=PsybsRSJOkK+rGQOMjU4XdJfQ2 PAtzE8sZGN0AlyQlsLwcVCWK1ocgaCJtSWG1akpwGdSZwplwCtDlbtCe5PTLrCit+FU2ronl8NDUN GcRnDxwgLBGDFw8M/GbLCDRtpwsfyW56zlGdCguvofmc0UMTGgjaifCWtXsb7p8+t3KY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s15T6-00EBwA-JJ; Sun, 28 Apr 2024 16:25:28 +0200 Date: Sun, 28 Apr 2024 16:25:28 +0200 From: Andrew Lunn To: =?iso-8859-1?Q?Ram=F3n?= Nordin Rodriguez Cc: Parthiban Veerasooran , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, horatiu.vultur@microchip.com, ruanjinjie@huawei.com, steen.hegelund@microchip.com, vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com, Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com, benjamin.bigler@bernformulastudent.ch Subject: Re: [PATCH net-next v4 11/12] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY Message-ID: <8e06c952-b5ab-4591-8ab0-7aebf612a67e@lunn.ch> References: <20240418125648.372526-1-Parthiban.Veerasooran@microchip.com> <20240418125648.372526-12-Parthiban.Veerasooran@microchip.com> <50b7cb69-61c0-45a2-9a48-4160b2d1e24c@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > I agree with your assesment, the phy won't reset itself, but maybe we > could add some comment doc about not adding it for the lan8670, > so no one trips over that in the future. In the PHY driver, you can provide your own .soft_reset handler. It could return -EOPNOTSUPP, or -EINVAL. Maybe check the data sheets for the standalone devices supported by the driver. Can you limit this to just the TC6 PHY? Andrew