Received-SPF: pass (google.com: domain of linux-kernel+bounces-161470-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e482db56-e63e-4165-89de-e460fb2b8d08@infradead.org>
Date: Sun, 28 Apr 2024 08:39:09 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] clocksource: Make the int help prompt unit readable in
 ncurses
To: Borislav Petkov <bp@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
 "Borislav Petkov (AMD)" <bp@alien8.de>,
 "Paul E . McKenney" <paulmck@kernel.org>, Waiman Long <longman@redhat.com>
References: <20240428102143.26764-1-bp@kernel.org>
Content-Language: en-US
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240428102143.26764-1-bp@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 4/28/24 3:21 AM, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> When doing
> 
>   make menuconfig
> 
> and searching for the CLOCKSOURCE_WATCHDOG_MAX_SKEW_US config item, the
> help says:
> 
>   │ Symbol: CLOCKSOURCE_WATCHDOG_MAX_SKEW_US [=125]
>   │ Type  : integer
>   │ Range : [50 1000]
>   │ Defined at kernel/time/Kconfig:204
>   │   Prompt: Clocksource watchdog maximum allowable skew (in   s)
>   							     ^^^^^
> 
>   │   Depends on: GENERIC_CLOCKEVENTS [=y] && CLOCKSOURCE_WATCHDOG [=y]
> 
> because on some terminals, it cannot display the 'μ' char, unicode
> number 0x3bc.
> 
> So simply write it out so that there's no trouble.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: Paul E. McKenney <paulmck@kernel.org>
> Cc: Waiman Long <longman@redhat.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  kernel/time/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
> index fc3b1a06c981..8ebb6d5a106b 100644
> --- a/kernel/time/Kconfig
> +++ b/kernel/time/Kconfig
> @@ -202,7 +202,7 @@ config HIGH_RES_TIMERS
>  	  the size of the kernel image.
>  
>  config CLOCKSOURCE_WATCHDOG_MAX_SKEW_US
> -	int "Clocksource watchdog maximum allowable skew (in μs)"
> +	int "Clocksource watchdog maximum allowable skew (in microseconds)"
>  	depends on CLOCKSOURCE_WATCHDOG
>  	range 50 1000
>  	default 125

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html