Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp916320lqa; Sun, 28 Apr 2024 09:39:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUZ9NVJt4XdI9QEn03WIPMv3e33z/NvlP6WpPqZboNHZXMUHdLqdZOC/AVCqXS/fXsl2d7VfJJUQgx4F0Fh+DpIqrN/Bn7Tgd3KjF47vQ== X-Google-Smtp-Source: AGHT+IF9bn5iH4dPtrEHOjD9+kxEBkaOXzZMVSW4YJmBa7PLsJ8bijeaDr8UmUJ7fLY9/j7+D+Mm X-Received: by 2002:a05:6a00:2d1c:b0:6ed:def7:6ae2 with SMTP id fa28-20020a056a002d1c00b006eddef76ae2mr9441596pfb.6.1714322352531; Sun, 28 Apr 2024 09:39:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714322352; cv=pass; d=google.com; s=arc-20160816; b=a1u7LN3g7ynZgxZkBVlh3L2yO6IStCXqVgXPm3Oq8CCYsvSI9wiRs1RxJmU+0Gdmbo 9aXJ00RltUe0fBSlEdlsEhuVnJmJJLJqwbqSPV3k13JRm+XhoMs34Q5IQEPPTbLcRvKf T2aaXvB5b5xc3gLYT+LxIleX3QoYMwvDIrvd+rmNF1zd3SS2tSCQjIoo3ocWlHLr/ELc NxBxy5CGRAOH/g8QaQ4YZYEmUg2cNGRsEDfzJ5CtU9kgmlLat2VcIwec88yYdINvRNBP 5sHCTWkU0SHkVg3G+paMr26QYYjcuamXQFemjq2ebzrCBrKqqJ/z9v1LknV+pCG/yV+W QK5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=F9IAuojiJRJBdMfdXolE1CKZT+516XOdcs3LxcFaXlQ=; fh=EcHaoAWWz4R7bH0d/dw7fDxRoq+5js+9vzeYMXGRpzY=; b=FMDYBfIE1giuSxRNU8QlQIsym1lZEkKqpeUgOhMzvvh2HBhRsp1QQBOPk+W/KQY5/Q D4mdKFRl/jIXEY2NYdCgSMwIRj+D40alwS6VN9+OpBUZIsZ11ElUvQbcI9h2i97jlW/i CkBe0jfXzy/B5XvqSIm5dravN8wZx6I6VIrCKbtw/LHQHmhznA+JW93SNiqi52A6o8o9 H2YynloUJtcZsrbieOTXAFTtaTfG+kXOxBnGxgPHz4kpxH4KMcwDY9eTT18yTCJ5lj18 y5d2hksnZJKPFOqhQ+qTG6a9PPJb8pgAkfX4fuNdnVMY/RIdBsDPhy9fh64Ki6CHut+a biuQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=RmNTbBV6; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-161496-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161496-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y11-20020a63e24b000000b005dc89957de5si19481076pgj.497.2024.04.28.09.39.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 09:39:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-161496-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=RmNTbBV6; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-161496-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161496-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A592128172E for ; Sun, 28 Apr 2024 16:39:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 97AEB71B49; Sun, 28 Apr 2024 16:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="RmNTbBV6" Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40DA06F083; Sun, 28 Apr 2024 16:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714322335; cv=none; b=ejUj9UEvWPQhxe5Aumh3qEbjoucJTMzpxk5OO5jxcZkFnswIgGRqM15ExeXZDuSWe2oA7EW6mN/xPSDJAl2BxA4UUPnaWDLQwB6hfSarmwCArJUtHKM5/4wdrHJlhv0UItAr0dUlOJ7sZrZuXG4xLenOCdEc/FNu8RPF2Wxd1qY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714322335; c=relaxed/simple; bh=F9IAuojiJRJBdMfdXolE1CKZT+516XOdcs3LxcFaXlQ=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=aSmZW/kTBL+yo/ryaHp8kmqr4ezhjnkArFAfeb3n9VNStQdHCx4fEfkoAiMx0c/fZqr1Jr9+KOkvY1X0Va9kF52+lsBM31ZlrF51ooQKQrFqoDPWxKH61glErqE8V5kKjzwu7aP0BzIMqreN//VQ+PIPPAPRxyVmRFiBwY1YgF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=RmNTbBV6; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1714322317; x=1714927117; i=markus.elfring@web.de; bh=F9IAuojiJRJBdMfdXolE1CKZT+516XOdcs3LxcFaXlQ=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=RmNTbBV6emQQxkKqg0S1hFN72jQ6StcSvpnc882kBNBj0LiasbzhmWtcgYcL6hog jBf3wG3C8wOBaATeNyegYOZ6FsNSb6ysehGgwdTw0IqrHWaSXvWVa10TLjHqxxYjf cvZ3GIMVG37yrPsXibS4nhfYiLSDO6xEBZRD/6qqcbPAyYEm8Oy6llzU03T47L0lo QZMVAKW0+2j9vSzjC0QDsqg3zrB2oFwVTuO8BxaFqRoxfxE91kFYqpkjkWmQZkqZm t52ahIncuxl6hqB9J22LpmL3rte4t4yYnLHCQ6pois6k2tCwLLknRh5TAsdOE2gwh YpncIYl+HdUJuCS3Lw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M4sbr-1rzkMs37zz-00DNys; Sun, 28 Apr 2024 18:38:37 +0200 Message-ID: Date: Sun, 28 Apr 2024 18:38:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sungwoo Kim , linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org, Johan Hedberg , Luiz Augusto von Dentz , Marcel Holtmann Cc: LKML , "Dave (Jing) Tian" References: <20240428015834.2485653-1-iam@sung-woo.kim> Subject: Re: [PATCH v2] Bluetooth: msft: fix slab-use-after-free in msft_do_close() Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240428015834.2485653-1-iam@sung-woo.kim> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:KgATldkKNdd0yMfd/hsnoSA3khz4WDL7eZ1c45p78WC4Se1AaAj P9LodVlemdun9GSJCHLkVYTdsLRiVVzIlhtd00WOvIfvkXCzhFKxrEPfDjvyyXmLCpURju/ 8KZauxsqG/dmQ+FsUMlrvfy3Ek8JCU9uB5Vzk2ss70r9u6tvvDY2z3NpTg24A9+GXMVWOhZ PDSR6Ws10psFmd/PDBgVw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:+wVU6gULitE=;kmnn2v4nHZT0auwpAOQM25RTioh dcUiA/naPB7nnWm+4mFrrjILOP7VwKPsgNa/fHW9MxfM+PVCvgvRUwtB3Me4x6YYuvLqnAoUp 3PA37tLJdvsPwKK/ynWiuO4RAjlK3UooWEoNLm4gHGm3JG8UTnlmgTeIvxfzuUF2UhBWnNff5 X3PkiBPYuVVnv8ODORmJVYyAxoYqk0HE1JAqEXWN7z/pHOjeDHSJipwfawtzpI3izUEqndFNb xkN4diRLDA8j9dAMB7UH9Idn71sAiFrfE0AT1cu/GwINcQNwDMgLWWmFrHXowagCUTj9ox6tC HNIxW3HvYnmDYTL9jF+KuDgeQqyG8d8wSDg49GHDe7cXhlwGU6kvMrYnaQSZ9mgicdWkzE5df bF/PujDUiOQfXTeWPrWPEzN9FvbjCdF8uvyJPCzaOzoub1rRLq1zB1wkBEkFHHHN1acD0h6eh 83s2T2eqZFosxeHzuZTY9ZfmKiQxG4YyMP59E3MUuVRfFoyYfA+Vw+W3uz4wIxa8LJ/D5J4F7 HxI/uybwbDlCc6Iejia4pdu2e3LQtH+mDQlz3CeTD0ZVqXDBKuSfzPv48qfR3JdM7wEV/NvdY z2qjfMFsz+4lIu7v19O8Ys3J6sxY6jpFyDBlA2qOX++8olTBTiEZM7VB2ns7kdRymFmMYIQEl 226nvTJlXCYyGRuGOVP4NUMY0/NoJa3CPF3hQVmLb5GuiLQutT33RqDTL7G3LknQJG4PTf58w Cxg9PWdckLAg2+27jl4NtA8ODaK1X6Sl4J2LXnbIIye2R55oRmD1tQVq6SYYs4TqSKfZCZSnh Sbm/68HBAUgbc/ig3xteyKBT00qJTBzvLsMjOtIhNUPFk= Will an other distribution of email addresses over recipient lists be more helpful? > Hi, could you review this patch? I suggest to reconsider such a question once for the final commit message. > Now *not static* msft functions hold and put hdev->msft_data. > It prevents from potential and real use-after-free bugs. Is another corresponding imperative wording desirable for an improved change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94 Regards, Markus