Received-SPF: pass (google.com: domain of linux-kernel+bounces-161509-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: linkmauve@linkmauve.fr, Jianfeng Liu <liujianfeng1994@gmail.com>
Cc: andy.yan@rock-chips.com, conor+dt@kernel.org,
 cristian.ciocaltea@collabora.com, devicetree@vger.kernel.org,
 dsimic@manjaro.org, ezequiel@vanguardiasur.com.ar,
 frattaroli.nicolas@gmail.com, iommu@lists.linux.dev, joro@8bytes.org,
 krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
 linux-rockchip@lists.infradead.org, macromorgan@hotmail.com,
 mchehab@kernel.org, p.zabel@pengutronix.de, robh@kernel.org,
 robin.murphy@arm.com, sebastian.reichel@collabora.com,
 shreeya.patel@collabora.com, will@kernel.org, sigmaris@gmail.com,
 nicolas@ndufresne.ca
Subject: Re: [PATCH v4 0/2] Enable JPEG encoding on rk3588
Date: Sun, 28 Apr 2024 19:01:38 +0200
Message-ID: <3784322.QJadu78ljV@diego>
In-Reply-To: <20240427071638.79915-1-liujianfeng1994@gmail.com>
References:
 <20240418141509.2485053-1-linkmauve@linkmauve.fr>
 <20240427071638.79915-1-liujianfeng1994@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Hi Jianfeng,

Am Samstag, 27. April 2024, 09:16:38 CEST schrieb Jianfeng Liu:
> Hi Emmanuel,
>=20
> On Thu, 18 Apr 2024 16:15:04 +0200, Emmanuel Gil Peyrot wrote:
> >- Only expose a single VEPU121, since the driver doesn=E2=80=99t yet sup=
port
> >  exposing them all as a single video node to userspace.
> I'm also doing work with the hantro node on rk3588 which has both vdpu
> and vepu. Discussions can be found here[1]. If I enable the jpeg encoder
> at feb50000, would it cause any side effects if other jpeg encoders in
> your patch are enabled? And what's the disadvantage of enabling multi
> jpeg endoers in devicetree?

the basic problem is that exposing multiple jpeg encoders would require
userspace to do the scheduling. Which is bad.
I.e. all userspace programms would need to know the existence of
all jpeg encoders and then somehow negotiate how to use all of them
most efficiently.

Think multiple different programs that would need to negotiate to
spread across all of them in the best way.

Doing this in the kernel, we just expose one encoder (and queue) all
programs would just pile onto that one encoder and the kernel then
would be on the hook to do the scheduling - which the kernel can do
better (with relevant code implemented)