Received-SPF: pass (google.com: domain of linux-kernel+bounces-161540-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Sun, 28 Apr 2024 11:30:47 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Cc: patrick@stwcx.xyz, Jean Delvare <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: max31790: revise the scale to write pwm
Message-ID: <062ac1a4-7cf2-454c-ba4f-b19695f1c2b4@roeck-us.net>
References: <20240416022211.859483-1-Delphine_CC_Chiu@wiwynn.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240416022211.859483-1-Delphine_CC_Chiu@wiwynn.com>

On Tue, Apr 16, 2024 at 10:22:11AM +0800, Delphine CC Chiu wrote:
> Since the value for PWMOUT Target Duty Cycle register is a 9 bit
> left-justified value that ranges from 0 to 511 and is contained in 2
> bytes.
> 
> There is an issue that the PWM signal recorded by oscilloscope would
> not be on consistently if we set PWM to 100% to the driver.
> 
> It is because the LSB of the 9 bit would always be zero if it just
> left shift 8 bit for the value that write to PWMOUT Target Duty
> Cycle register.
> 
> Therefore, revise the scale of the value that was written to pwm input
> from 255 to 511 and modify the value to left-justified value.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

Applied.

Thanks,
Guenter