Received-SPF: pass (google.com: domain of linux-kernel+bounces-161541-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 28 Apr 2024 20:31:42 +0200
From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org
Subject: Re: [tip: x86/cpu] x86/mce: Switch to new Intel CPU model defines
Message-ID: <20240428183142.GHZi6WDu5nbmJJ_BcH@fat_crate.local>
References: <171415513118.10875.11391783217612357854.tip-bot2@tip-bot2>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <171415513118.10875.11391783217612357854.tip-bot2@tip-bot2>

On Fri, Apr 26, 2024 at 06:12:11PM -0000, tip-bot2 for Tony Luck wrote:
> @@ -398,7 +398,7 @@ static noinstr int mce_severity_intel(struct mce *m, struct pt_regs *regs, char 
>  			continue;
>  		if (s->excp && excp != s->excp)
>  			continue;
> -		if (s->cpu_model && boot_cpu_data.x86_model != s->cpu_model)
> +		if (s->cpu_vfm && boot_cpu_data.x86_model != s->cpu_vfm)

Hold on, isn't this supposed to be:

		if (s->cpu_vfm && boot_cpu_data.cpu_vfm != s->cpu_vfm)

?

You're getting rid of the ->x86_model checking altogether...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette