Received-SPF: pass (google.com: domain of linux-kernel+bounces-161552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 28 Apr 2024 19:26:33 +0000
To: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jwoithe@just42.net, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com
From: Szilard Fabian <szfabian@bluemarch.art>
Cc: Szilard Fabian <szfabian@bluemarch.art>
Subject: [PATCH] platform/x86/fujitsu-laptop: Replace sprintf() with sysfs_emit()
Message-ID: <20240428192548.113261-1-szfabian@bluemarch.art>
Feedback-ID: 87830438:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

As suggested by Documentation/filesystems/sysfs.rst sysfs_emit() should be
used when formatting the value to be returned to user space.

Signed-off-by: Szilard Fabian <szfabian@bluemarch.art>
---
 drivers/platform/x86/fujitsu-laptop.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/f=
ujitsu-laptop.c
index 94480af49467..968fc91bd5e4 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -386,11 +386,11 @@ static ssize_t lid_show(struct device *dev, struct de=
vice_attribute *attr,
 =09struct fujitsu_laptop *priv =3D dev_get_drvdata(dev);
=20
 =09if (!(priv->flags_supported & FLAG_LID))
-=09=09return sprintf(buf, "unknown\n");
+=09=09return sysfs_emit(buf, "unknown\n");
 =09if (priv->flags_state & FLAG_LID)
-=09=09return sprintf(buf, "open\n");
+=09=09return sysfs_emit(buf, "open\n");
 =09else
-=09=09return sprintf(buf, "closed\n");
+=09=09return sysfs_emit(buf, "closed\n");
 }
=20
 static ssize_t dock_show(struct device *dev, struct device_attribute *attr=
,
@@ -399,11 +399,11 @@ static ssize_t dock_show(struct device *dev, struct d=
evice_attribute *attr,
 =09struct fujitsu_laptop *priv =3D dev_get_drvdata(dev);
=20
 =09if (!(priv->flags_supported & FLAG_DOCK))
-=09=09return sprintf(buf, "unknown\n");
+=09=09return sysfs_emit(buf, "unknown\n");
 =09if (priv->flags_state & FLAG_DOCK)
-=09=09return sprintf(buf, "docked\n");
+=09=09return sysfs_emit(buf, "docked\n");
 =09else
-=09=09return sprintf(buf, "undocked\n");
+=09=09return sysfs_emit(buf, "undocked\n");
 }
=20
 static ssize_t radios_show(struct device *dev, struct device_attribute *at=
tr,
@@ -412,11 +412,11 @@ static ssize_t radios_show(struct device *dev, struct=
 device_attribute *attr,
 =09struct fujitsu_laptop *priv =3D dev_get_drvdata(dev);
=20
 =09if (!(priv->flags_supported & FLAG_RFKILL))
-=09=09return sprintf(buf, "unknown\n");
+=09=09return sysfs_emit(buf, "unknown\n");
 =09if (priv->flags_state & FLAG_RFKILL)
-=09=09return sprintf(buf, "on\n");
+=09=09return sysfs_emit(buf, "on\n");
 =09else
-=09=09return sprintf(buf, "killed\n");
+=09=09return sysfs_emit(buf, "killed\n");
 }
=20
 static DEVICE_ATTR_RO(lid);
--=20
2.44.0