Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760543AbYA1LzZ (ORCPT ); Mon, 28 Jan 2008 06:55:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754022AbYA1LzM (ORCPT ); Mon, 28 Jan 2008 06:55:12 -0500 Received: from cantor.suse.de ([195.135.220.2]:54513 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbYA1LzK (ORCPT ); Mon, 28 Jan 2008 06:55:10 -0500 Date: Mon, 28 Jan 2008 12:55:09 +0100 Message-ID: From: Takashi Iwai To: Mariusz Kozlowski Cc: Andrew Morton , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, David Miller , perex@perex.cz Subject: Re: 2.6.24-rc8-mm1: old sparc64 bug In-Reply-To: <200801251934.35782.m.kozlowski@tuxland.pl> References: <20080117023514.9df393cf.akpm@linux-foundation.org> <200801250104.34669.m.kozlowski@tuxland.pl> <200801251934.35782.m.kozlowski@tuxland.pl> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 50 At Fri, 25 Jan 2008 19:34:35 +0100, Mariusz Kozlowski wrote: > > Hello, > > > > I was digging through the gentoo bugzilla and found this: > > > > > > http://bugs.gentoo.org/show_bug.cgi?id=141823 > > > > > > As you see this bug is present since at least 2.6.17. I can reproduce > > > that here on my hardware with 2.6.24-rc8-mm1. All you need to do is install > > > mp3blaster on sparc64, run: > > > > > > $ mp3blaster some_mp3_file.mp3 > > > > > > and stop it by pressing ctrl-c. It oopses when you stop it. It doesn't happen > > > every time but it'll oops in a few tries. > > > > This looks similar like a bug I fixed ago. Damn, it's still there. > > > > Could you build with CONFIG_SND_DEBUG=y ? It addas some sanity checks > > and might catch the fatal condition. > > Done. I don't think it changed much though :-/ OK, could you try the patch below? thanks, Takashi --- diff -r edbe1b84179b sound/core/oss/pcm_oss.c --- a/sound/core/oss/pcm_oss.c Mon Jan 28 12:30:17 2008 +0100 +++ b/sound/core/oss/pcm_oss.c Mon Jan 28 12:56:13 2008 +0100 @@ -1621,6 +1621,7 @@ static int snd_pcm_oss_sync(struct snd_p snd_pcm_format_set_silence(runtime->format, runtime->oss.buffer, size1); + size1 /= runtime->channels; /* frames */ fs = snd_enter_user(); snd_pcm_lib_write(substream, (void __user *)runtime->oss.buffer, size1); snd_leave_user(fs); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/