Message-ID: <479DC1AB.1060304@siemens.com>
Date: Mon, 28 Jan 2008 12:51:07 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20070801)
MIME-Version: 1.0
To: Steven Rostedt <rostedt@goodmis.org>
CC: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
       LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Christoph Hellwig <hch@infradead.org>,
       Gregory Haskins <ghaskins@novell.com>,
       Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
       Thomas Gleixner <tglx@linutronix.de>, Tim Bird <tim.bird@am.sony.com>,
       Sam Ravnborg <sam@ravnborg.org>, "Frank Ch. Eigler" <fche@redhat.com>,
       John Stultz <johnstul@us.ibm.com>,
       Arjan van de Ven <arjan@infradead.org>,
       Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 06/20 -v5] add notrace annotations for NMI routines
References: <20080123160236.969334052@goodmis.org> <20080123160442.063076557@goodmis.org> <20080123213139.GB2282@Krystal> <Pine.LNX.4.58.0801260024270.11589@gandalf.stny.rr.com>
In-Reply-To: <Pine.LNX.4.58.0801260024270.11589@gandalf.stny.rr.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 33

Steven Rostedt wrote:
> On Wed, 23 Jan 2008, Mathieu Desnoyers wrote:
> 
>> * Steven Rostedt (rostedt@goodmis.org) wrote:
>>> This annotates NMI functions with notrace. Some tracers may be able
>>> to live with this, but some cannot. So we turn off NMI tracing.
>>>
>>> One solution might be to make a notrace_nmi which would only turn
>>> off NMI tracing if a trace utility needed it off.
>>>
>> Is this still needed with the atomic clocksource read ?
>>
> 
> Before you ask again, I've still included this in -v6, simply because I
> didn't get a chance to test it without this patch. I'll try to remember to
> do that on Monday.

Only in case you finally have to keep the annotations for the posted
tracer: Then please make it a Kconfig selectable restriction, because
there are use cases of the mcount hook where you are interested in NMI
invocations.

TiA,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/