Received-SPF: pass (google.com: domain of linux-kernel+bounces-161697-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 29 Apr 2024 08:51:46 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Joshua Yeong <joshua.yeong@starfivetech.com>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: cpufreq: Fix printing large cpu and cpufreq number
Message-ID: <20240429032146.2d3t7bai7k6cotqt@vireshk-i7>
References: <20240425110017.75238-1-joshua.yeong@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240425110017.75238-1-joshua.yeong@starfivetech.com>

On 25-04-24, 19:00, Joshua Yeong wrote:
> Fix printing negative number when CPU frequency
> with large number.
> 
> Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com>
> ---
>  drivers/cpufreq/freq_table.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
> index c17dc51a5a02..9b9568023f3c 100644
> --- a/drivers/cpufreq/freq_table.c
> +++ b/drivers/cpufreq/freq_table.c
> @@ -194,7 +194,7 @@ int cpufreq_table_index_unsorted(struct cpufreq_policy *policy,
>  	}
>  	if (optimal.driver_data > i) {
>  		if (suboptimal.driver_data > i) {
> -			WARN(1, "Invalid frequency table: %d\n", policy->cpu);
> +			WARN(1, "Invalid frequency table: %u\n", policy->cpu);
>  			return 0;
>  		}
> 
> @@ -254,7 +254,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf,
>  		if (show_boost ^ (pos->flags & CPUFREQ_BOOST_FREQ))
>  			continue;
> 
> -		count += sprintf(&buf[count], "%d ", pos->frequency);
> +		count += sprintf(&buf[count], "%u ", pos->frequency);
>  	}
>  	count += sprintf(&buf[count], "\n");

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh