Received-SPF: pass (google.com: domain of linux-kernel+bounces-161760-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f6ef8692-246e-49a5-952f-d371a87a70f4@ti.com>
Date: Mon, 29 Apr 2024 11:24:50 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] net: ti: icssg_prueth: Add SW TX / RX Coalescing
 based on hrtimers
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
CC: Dan Carpenter <dan.carpenter@linaro.org>,
        Heiner Kallweit
	<hkallweit1@gmail.com>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Diogo Ivo
	<diogo.ivo@siemens.com>, Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski
	<kuba@kernel.org>, Eric Dumazet <edumazet@google.com>,
        "David S. Miller"
	<davem@davemloft.net>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <srk@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>, <r-gunasekaran@ti.com>,
        Roger Quadros <rogerq@kernel.org>
References: <20240424091823.1814136-1-danishanwar@ti.com>
 <98588a89-4970-4d75-be8a-ac410d77789f@lunn.ch>
 <1c5809f2-b69d-48d1-8c27-285f164ebeb8@ti.com>
 <2a4bea87-04bf-4373-8220-69650b435710@lunn.ch>
From: MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <2a4bea87-04bf-4373-8220-69650b435710@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 25/04/24 6:19 pm, Andrew Lunn wrote:
>> I did some benchmarking today with,
>> 	1. Default driver (without any IRQ coalescing enabled)
>> 	2. IRQ Coalescing (With this patch)
>> 	3. Default IRQ Coalescing (Suggested by you in the above patch)
>>
>> I have pasted the full logs at [1].
>>
>> Below are the final numbers,
>>
>> ==============================================================
>> Method                  | Tput_TX | CPU_TX | Tput_RX | CPU_RX |
>> ==============================================================
>> Default Driver           943 Mbps    31%      517 Mbps  38%   |
>> IRQ Coalescing (Patch)   943 Mbps    28%      518 Mbps  25%   |
>> Default IRQ Coalescing   942 Mbps    32%      521 Mbps  25%   |
>> ==============================================================
>>
>> I see that the performance number is more or less same for all three
>> methods only the CPU load seems to be varying. The IRQ coalescing patch
>> (using hrtimer) seems to improve the cpu load by 3-4% in TX and 13% in
>> RX. Whereas the default method that you have suggested doesn't give any
>> improvemnet in tx however cpu load improves in RX with the same amount
>> as method 2.
>>
>> Please let me know if this patch is OK to you based on the benchmarking?
> 
> It is good to include benchmark results in patches which claim to
> improve performance. Please add the default and the patch version
> results to the commit message.

Sure, I will add the benchmarking numbers in commit message and send v2.

> 
> The numbers show your more complex version does bring benefits, so it
> is O.K. to use it. I just wounder how many other drivers would benefit
> from a one line change.
> 
> 	Andrew

-- 
Thanks and Regards,
Danish