Received-SPF: pass (google.com: domain of linux-kernel+bounces-161762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ce49c67c24f57ffab166d688a1c9e3139733f412.camel@kernel.org>
Subject: Re: [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup
 failure
From: PJ Waskiewicz <ppwaskie@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>, linux-cxl@vger.kernel.org, 
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Sun, 28 Apr 2024 22:57:13 -0700
In-Reply-To: <20240409132241.GA2071709@bhelgaas>
References: <20240409132241.GA2071709@bhelgaas>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.0-1 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-04-09 at 08:22 -0500, Bjorn Helgaas wrote:
> On Sun, Apr 07, 2024 at 02:05:26PM -0700, ppwaskie@kernel.org=C2=A0wrote:
> > From: PJ Waskiewicz <ppwaskie@kernel.org>
> >=20
> > Currently, Type 3 CXL devices (CXL.mem) can train using host CXL
> > drivers on Emerald Rapids systems.=C2=A0 However, on some production
> > systems from some vendors, a buggy BIOS exists that improperly
> > populates the ACPI =3D> PCI mappings.
>=20
> Can you be more specific about what this ACPI =3D> PCI mapping is?
> If you already know what the problem is, I'm sure this is obvious,
> but
> otherwise it's not.

Apologies for the delay in response.  Things got a bit busy with travel
and whatnot...

On one of these particular hosts, in /sys/bus/acpi/devices/ACPI0016:00,
for example, the UID would be something like CX01.  It isn't an u64 at
all, and there's no atoi() or other conversions that would match what
the UID should be.

In my case, /sys/bus/acpi/devices/ACPI0016:02/ is my CXL device in
question. The UID that is presented from enumeration was CX02.=20
However, if I scour the CEDT manually, the UID of my particular CXL
device is really UID 49.

So, if I went from the PCI/CXL device side, and called something along
the lines of to_cxl_host_bridge() and tried to go from the pci_dev to
the acpi_handle, I'd get CX02 back.  Then trying to use that to call
acpi_table_parse_cedt() would fail.

The BIOS fix from the vendor corrected the UID enumeration on the ACPI
side.  This allowed things to properly line up when traversing through
the kernel APIs and parsing the ACPI tables.

Let me know if this helps clarify!  If not, I can try and get more
detailed info.

-PJ