Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1193155lqa; Mon, 29 Apr 2024 00:25:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWJTFO0rFqZVAxBiBl0ivAXxSrjb9DJzlbyVw8YIMpf60egTxydsrUM5EpkfjFgbYJNSMFky27a8xGRiNPZZRliGT6SXWdg79v7YRQHtQ== X-Google-Smtp-Source: AGHT+IHYWznQaKuMvX9GyrFocSg5CrOSXFMH0OL0Me66FuM2j80rDApZ+J4BRFMI0j9fznvpsUFy X-Received: by 2002:a50:9fc1:0:b0:572:2efe:4d14 with SMTP id c59-20020a509fc1000000b005722efe4d14mr8119089edf.10.1714375556965; Mon, 29 Apr 2024 00:25:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714375556; cv=pass; d=google.com; s=arc-20160816; b=l3UIX2sz6F0zMPhwnQ8ESEDxYr4Mo4+w2Y7UghBnZrRiPJxcCtQQEp6DroemuB7NLM r0bjxWezNtmFxANxjBFgsDP6roQkSetPpFwt6qjw2o46m3ye3MEDtz60nSrBZzYKQiWE f1lBbl9f0/7lx5ZmC3eB9flCc8YyZgowXr2NPtnI1JBI/SpRLWhaSkbVrPp1o3RcwckL E6mI4Emn4r5HPCsRmR7lk2ApkY8jbfvC8pQ9Rz7XP77M5ezqNt2tzczRijiBwC+MUh+R yJDo8qeyBPVknVifkxV7aZ3XDkcBYjiGsiAaSQ5nC0CSSJeSbMRavg1DIGtM79vGoewZ 5KsA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=zHN1UD5TWJNXAgNMrRcVqXjchUiV/1X9JFjbgPJ7NYE=; fh=5ac6bIx7giKNBt3vqyD6UmY0yraTpg7JD4WAUI6zQmc=; b=Sf7B54WMjoriIL39Iz7WLwCD/xPZ+MCsxhp7X1Pq+cYxme+SGMrzdz8HWC8Sx5WrhL 0/JkyVMAzEgnh3U7xCVjsggDwbn7y+ij8AFpnLR3oPDQ6NXG67bcTdlzoDIT0HhpN1kM NCdHN0VglZ+x2ErpB7KAPdTzkyh2dkn8CNhx6IKkf4n939M9oStSmy+oxp9O5Y2R1g55 YLpoFDQkOKnrDeNZNCoPRotx/+p6KgINlCwFMSWoYx47N3HFZLpNov0mLPDXkc8Nx9CQ MIbjEsX0oRlwfNLf7rOM1ALCDZ/cP0V47s16G6uX4q0JYuo+DlESaBhNp5DyHv4pNNhX EqlQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JrvQQFV+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-161855-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161855-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id if17-20020a0564025d9100b005727bddc2cfsi1689502edb.295.2024.04.29.00.25.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 00:25:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-161855-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JrvQQFV+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-161855-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-161855-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B07611F21906 for ; Mon, 29 Apr 2024 07:25:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D58FE1427E; Mon, 29 Apr 2024 07:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JrvQQFV+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECDB78472; Mon, 29 Apr 2024 07:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714375549; cv=none; b=NX+fIXT8eB5i+WPZrpWpGyKEtJsPwFS2x9bwmVMIeCPOGOr+ipx5JRJwI6Aopu5yL7RSBU+oGEBvyLg431J8EDNmLkd2JieaA3GGe2rMf1YVVqA+VJFuhJupISsrcFLGzaH0sp7i709IRKFgUV5NfLrjQqfDXW5hw3oZ4Bq2nH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714375549; c=relaxed/simple; bh=HADVt0e0B/pg98rMxUXytmNKr8grn91AvnMopqDte2U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TaKlQw6D9//QNrqC5krVn+u/m4TFIhzJL706dYjFoBeWGLlwNu+QnNf2DQlH95bldPNC+GuR0nPYmQ6JDbF3QM9GzetkPLXV1HXZEM4qV3w0mg6lDNVvCZuhq5PEuGUfzx93Sev3+rhcuaqEvzp/k0w4Ti/liLvuYx3RqvjO9Ho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JrvQQFV+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04303C113CD; Mon, 29 Apr 2024 07:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714375548; bh=HADVt0e0B/pg98rMxUXytmNKr8grn91AvnMopqDte2U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JrvQQFV+t0qveKS6tiIEJs3lceWl+/V8k0AR27jYTm/N9+UVJOEOc2YL+EguNAr3a 3msiT9goSG8auKiEyvAz/UAmQJxrsIpBbjjVs/WAzbZAOScGVmo20cBZBrVO8+9uno hiWLC9/y6cinbhwvI2CaYg4JHnP8TcUFl8pQjU4/aVeppH2TOk/5wB5Jto5vDSEKtl EUDUMYFMnKFU8hCPoH7DG1hhAdJ31JySzpP1vZQE8mUoWBRs1VLvM9g8m3qd972w0u j9JYt3AgSHgs4ELsw+VxxI0/y014p+v7+QYuBwonyfh2ZpQW1uDJ08Zx0y2UObYEzZ wHaTjt5NjLOdw== Message-ID: Date: Mon, 29 Apr 2024 09:25:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] spi: dt-bindings: ti,qspi: convert to dtschema To: Kousik Sanagavarapu Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Javier Carrasco References: <20240428070258.4121-1-five231003@gmail.com> <59fe75b6-a4a4-4c90-a3c4-c8a4b539e879@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/04/2024 09:10, Kousik Sanagavarapu wrote: > On Mon, Apr 29, 2024 at 07:07:38AM +0200, Krzysztof Kozlowski wrote: >> On 28/04/2024 08:58, Kousik Sanagavarapu wrote: >>> Convert txt binding of TI's qspi controller (found on their omap SoCs) to >>> dtschema to allow for validation. > > [...] > >>> + spi-max-frequency: >>> + description: Maximum SPI clocking speed of the controller in Hz. >>> + $ref: /schemas/types.yaml#/definitions/uint32 >> >> >> Are you sure that's actually needed? That's not a property of controller. > > [...] > >>> + num-cs = <4>; >>> + spi-max-frequency = <48000000>; >> >> Drop. Are you sure driver parses it? > > The driver does parse it though. Looking at > drivers/spi/spi-ti-qspi.c::ti_qspi_probe(), > > if (!of_property_read_u32(np, "spi-max-frequency", &max_freq)) > host->max_speed_hz = max_freq; > > So I included it in the dtschema as well. Please let me know if > including it in the dtschema in this case is wrong. Ah, indeed. It is fine there. Keep it in the binidng and in the example. Best regards, Krzysztof