Received-SPF: pass (google.com: domain of linux-kernel+bounces-161897-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <d6b562f336b3750c131830a984b148ea7103ab0d.camel@physik.fu-berlin.de>
Subject: Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency
 property
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring
 <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
  Conor Dooley <conor+dt@kernel.org>, Yoshinori Sato
 <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
 devicetree@vger.kernel.org, linux-sh@vger.kernel.org, 
 linux-kernel@vger.kernel.org
Cc: Kousik Sanagavarapu <five231003@gmail.com>
Date: Mon, 29 Apr 2024 10:16:01 +0200
In-Reply-To: <20240322064221.25776-1-krzysztof.kozlowski@linaro.org>
References: <20240322064221.25776-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-03-22 at 07:42 +0100, Krzysztof Kozlowski wrote:
> The J2 SPI controller bindings never allowed spi-max-frequency property
> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
> schema allows it.  Linux driver does not parse that property from
> controller node, thus drop it from DTS as incorrect hardware
> description.  The SPI child device has already the same property with
> the same value, so functionality should not be affected.
>=20
> Cc: Kousik Sanagavarapu <five231003@gmail.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/sh/boot/dts/j2_mimas_v2.dts | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas=
_v2.dts
> index fa9562f78d53..faf884f53804 100644
> --- a/arch/sh/boot/dts/j2_mimas_v2.dts
> +++ b/arch/sh/boot/dts/j2_mimas_v2.dts
> @@ -71,8 +71,6 @@ spi0: spi@40 {
>  			#address-cells =3D <1>;
>  			#size-cells =3D <0>;
> =20
> -			spi-max-frequency =3D <25000000>;
> -
>  			reg =3D <0x40 0x8>;
> =20
>  			sdcard@0 {

It seems that spi-bus.txt has been replaced by spi-controller.yaml now, so
I think we should update the filename in the commit message, shouldn't we?

Besides that, I agree with the changes.

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

Adrian

--=20
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913