Received-SPF: pass (google.com: domain of linux-kernel+bounces-161903-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 29 Apr 2024 10:22:42 +0200
From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
	linux-tip-commits@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86/cpu: Fix thinko comparing x86_vfm with x86_model
Message-ID: <20240429082242.GAZi9Y0uK-e2KGWxmX@fat_crate.local>
References: <20240428183142.GHZi6WDu5nbmJJ_BcH@fat_crate.local>
 <20240429022051.63360-1-tony.luck@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240429022051.63360-1-tony.luck@intel.com>

On Sun, Apr 28, 2024 at 07:20:51PM -0700, Tony Luck wrote:
> This is obviously nonsense. Fix it.
> 
> Fixes: 68b4c6d168c5 ("x86/mce: Switch to new Intel CPU model defines")
> Reported-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> 
> Boris: Do you rebase x86/cpu branch in TIP? If so this could be merged
> into the broken patch. If not then slap it on top. Risk of bisection
> breakage is tiny as this only affects a quirk handling patrol scrub
> errors on Skylake and Cascade lake systems.

Lemme try to rebase. And btw, you could've avoided the same name
patches:

e063b531d4e8 (refs/remotes/tip/x86/cpu) x86/mm: Switch to new Intel CPU model defines
94eb882e9575 x86/tsc_msr: Switch to new Intel CPU model defines
95be3ccd711c x86/tsc: Switch to new Intel CPU model defines
7cd2e9a90299 x86/cpu: Switch to new Intel CPU model defines
343ec8beae30 x86/resctrl: Switch to new Intel CPU model defines
43e8e0a95a89 x86/resctrl: Switch to new Intel CPU model defines

<--

173e856a55d0 x86/microcode/intel: Switch to new Intel CPU model defines
68b4c6d168c5 x86/mce: Switch to new Intel CPU model defines
8a5943977900 x86/mce: Switch to new Intel CPU model defines
066f54e65e47 x86/mce: Switch to new Intel CPU model defines

<---

34304acb3290 x86/cpu: Switch to new Intel CPU model defines
77d0930acedf x86/cpu/intel_epb: Switch to new Intel CPU model defines
a7c345216f88 x86/aperfmperf: Switch to new Intel CPU model defines
22878345b4c1 x86/apic: Switch to new Intel CPU model defines
e8475a26a94f perf/x86/msr: Switch to new Intel CPU model defines
438731421a2f perf/x86/intel/uncore: Switch to new Intel CPU model defines
d413a1955a8e perf/x86/intel/uncore: Switch to new Intel CPU model defines
9b2583d8103e perf/x86/intel/uncore: Switch to new Intel CPU model defines

<---

a7011b852a30 perf/x86/intel/pt: Switch to new Intel CPU model defines
0011a51d73d5 perf/x86/lbr: Switch to new Intel CPU model defines
5ee800945a34 perf/x86/intel/cstate: Switch to new Intel CPU model defines


and why in the hell are there 2 or 3 patches of the same name touching
the same thing? Why can't they be a single patch?

Lemme rebase the lot.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette