Received-SPF: pass (google.com: domain of linux-kernel+bounces-161939-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 29 Apr 2024 11:57:57 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2] ACPI: Move acpi_blacklisted() declaration to
 asm/acpi.h
Message-ID: <Zi9hFbrIfyDhrA5R@smile.fi.intel.com>
References: <20240429040441.748479-1-sathyanarayanan.kuppuswamy@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240429040441.748479-1-sathyanarayanan.kuppuswamy@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Sun, Apr 28, 2024 at 09:04:41PM -0700, Kuppuswamy Sathyanarayanan wrote:
> The function acpi_blacklisted() is defined only when CONFIG_X86 is
> enabled and is only used by X86 arch code. To align with its usage and
> definition conditions, move its declaration to asm/acpi.h

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

..

>  extern char acpi_video_backlight_string[];
>  extern long acpi_is_video_device(acpi_handle handle);
> -extern int acpi_blacklisted(void);

I would replace it with a blank line (to me it seems the above and below are
different groups from semantic point of view, but Rafael may correct me).

>  extern void acpi_osi_setup(char *str);
>  extern bool acpi_osi_is_win8(void);

-- 
With Best Regards,
Andy Shevchenko