Received-SPF: pass (google.com: domain of linux-kernel+bounces-161999-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0e6abfb3-ae9e-45db-b441-a7c97beec185@ti.com>
Date: Mon, 29 Apr 2024 15:08:53 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am625-sk: Add bootph-all property
 in phy_gmii_sel node
Content-Language: en-US
To: Krzysztof Kozlowski <krzk@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Rob Herring <robh@kernel.org>, Tero
 Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>, Nishanth
 Menon <nm@ti.com>,
        <s-vadapalli@ti.com>
CC: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <20240429061600.2723904-1-c-vankar@ti.com>
 <c17d8123-e9cb-45b5-84df-9fe102ddeddc@kernel.org>
 <4b3d2578-06ea-4feb-aa31-3968063953e8@ti.com>
 <f400160f-1caf-44f6-a1b2-3a538eebd63c@ti.com>
 <44e430f6-1bad-4d0c-a908-823b83625db5@kernel.org>
From: Chintan Vankar <c-vankar@ti.com>
In-Reply-To: <44e430f6-1bad-4d0c-a908-823b83625db5@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 29/04/24 12:56, Krzysztof Kozlowski wrote:
> On 29/04/2024 08:58, Chintan Vankar wrote:
>>
>>
>> On 29/04/24 12:12, Chintan Vankar wrote:
>>>
>>>
>>> On 29/04/24 12:08, Krzysztof Kozlowski wrote:
>>>> Are you sure you kept proper ordering of nodes or just stuffed this to
>>>> the end?
>>>
>>> Yes, I added this node at the end.
>>
>> Is it okay to add it at the end or it should be defined after "cpsw3g"
>> node ?
> 
> What is the ordering for this subarch? What does the DTS coding style say?
> 

I tried to verify the order this file is following from DTS coding style
documentation, but it seems it is not following the order mentioned in
Documentation.

Since we will need the same functionality for "am62x-lpsk" board I am
planning to add this node in "k3-am62x-sk-common.dtsi". In that file I
will follow the same order as it is followed in "k3-am62-main.dtsi".

> Best regards,
> Krzysztof
>