Date: Mon, 28 Jan 2008 14:56:15 +0100
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: michael <trimarchi@gandalf.sssup.it>
Cc: linux-kernel@vger.kernel.org, Andrew Victor <linux@maxim.org.za>,
       David Brownell <david-b@pacbell.net>
Subject: Re: at91sam9260 wakeup on serial port
Message-ID: <20080128145615.1d756025@dhcp-252-066.norway.atmel.com>
In-Reply-To: <479DB934.6090806@gandalf.sssup.it>
References: <479DB934.6090806@gandalf.sssup.it>
Organization: Atmel Norway
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1002
Lines: 24

On Mon, 28 Jan 2008 12:15:00 +0100
michael <trimarchi@gandalf.sssup.it> wrote:

> Hi,
> I implement a little patch (ndr just for a try) for the atmel serial 
> driver atmel_serial.c to wakeup the system when it is in suspend-ram state.
> I reconfigure the RXD pin as a gpio in suspend function and restore it 
> in the resume function. It is the correct way?

I'm not sure...this is rather platform-specific, so I don't think it
really belongs in the atmel_serial() driver. One solution might be to
add a function pointer to struct atmel_uart_data that the driver can
call from ->suspend() in order to let the platform code handle this as
appropriate.

Cc'ing Andrew Victor and David Brownell since they know the AT91
platform code better than me.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/