Received-SPF: pass (google.com: domain of linux-kernel+bounces-162034-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <aedb7cd5-56b3-4efe-b62c-ac3d7a9be740@redhat.com>
Date: Mon, 29 Apr 2024 20:17:57 +1000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/4] vhost: Cleanup
Content-Language: en-US
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
 jasowang@redhat.com, shan.gavin@gmail.com
References: <20240423032407.262329-1-gshan@redhat.com>
 <20240429025750-mutt-send-email-mst@kernel.org>
From: Gavin Shan <gshan@redhat.com>
In-Reply-To: <20240429025750-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/29/24 17:02, Michael S. Tsirkin wrote:
> On Tue, Apr 23, 2024 at 01:24:03PM +1000, Gavin Shan wrote:
>> This is suggested by Michael S. Tsirkin according to [1] and the goal
>> is to apply smp_rmb() inside vhost_get_avail_idx() if needed. With it,
>> the caller of the function needn't to worry about memory barriers. Since
>> we're here, other cleanups are also applied.
> 
> 
> Gavin I suggested another approach.
> 1. Start with the patch I sent (vhost: order avail ring reads after
>     index updates) just do a diff against latest.
>     simplify error handling a bit.
> 2. Do any other cleanups on top.
> 

My apologies, Michael. I didn't see your patch until now [1]

   [1] https://lore.kernel.org/virtualization/20240327155750-mutt-send-email-mst@kernel.org/

v2 was sent with your changes integrated and other cleanup are applied on
top of it. Please take a look when you getting a chance.

   v2: https://lore.kernel.org/virtualization/20240429101400.617007-1-gshan@redhat.com/T/#t

Thanks,
Gavin