Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1263933lqa; Mon, 29 Apr 2024 03:29:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU11+ArI+OKAZATwjsrY2txmKzarOgi/skyhLQUhZ+oshI+V+2q91ammCm3BbIm899jLUO9m6ku/ou9OZIarZi8+Zx2SmWNLI47W6xzLw== X-Google-Smtp-Source: AGHT+IG6HYYT/6JnrdUiImKpXyRhJtP42Hi8Se6hA1Y/N6hDoZG4uYbRc41S4jIFqQnkjcZM0WvJ X-Received: by 2002:a17:906:1c48:b0:a52:56e8:224a with SMTP id l8-20020a1709061c4800b00a5256e8224amr7824531ejg.51.1714386550945; Mon, 29 Apr 2024 03:29:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714386550; cv=pass; d=google.com; s=arc-20160816; b=aImvdmQ0k14Q1mk1N7EfrflGXGb/SbrzW8X1PQXKm2Ei95w10FPlRDPTJSHE2ak/8K Br9pokPOs5VQZaJcSCXCyd7zcOfSCTnFZAPLq3FeLzTtnlm6syDt6fMVyZfY3NPDj4sr fWBh7rsqVLaxVWDMi4Rr54uCSlQXeoQC3XcW0BMyVcexghdWV5hFx8a7HG13KQkZmqVd Lf6l9ETPhD7N8vENM6BMJteELJP2jCBFZR0HvplCpcX++2q64Zwk0fkCXIgfedzLw0ZK HyXC0scp0Zz/86e9FTq+10vygeNucs2XuMic0ryT3NrAY1Ms/R8E6/llYDZ94TdlD9uR 7CLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=elgfhsK5tTawzbHG+tPHUGcJURx+nPCBExkfqNrn9eE=; fh=I6+YIJ0cU6av9gjex9uk0tH1W2cF3iLwQaciu2NqtN8=; b=I5LKhSZ6GdBbg/ZwFNceE4O+Qq9NLvQ3Lg4u2gtfzm/W4D1vlll0h9jnH90hgYPZHJ omTOKe8IwmFTa+RYLc0gGKz7OjSvXJzo7Nzn7c4W769iOW7NrTxJ7uTT8zOVDhET5sr/ RtVdl13uZ4/E/r2S+VCE8RD/5AblPukH+s9I+xAIrfKqoyC3nW4uISgSyefs3p9Bqg3s lLv0UYboTiEdJvRutr1HGG8YifuQ7eYF9g8e6dI+syQgP3IjGpvivhkKVwztxIYikl5a lb8cuVxjcpU03kmB3krYBc+F81LOlp2jMI8yx/mkDtMtPcGQjTdTAL6rKnQrOtkYhrS8 W9iQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sY1jqojp; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-162055-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162055-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id i10-20020a1709064fca00b00a55a8a9580fsi10891977ejw.341.2024.04.29.03.29.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 03:29:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-162055-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sY1jqojp; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-162055-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162055-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A9A141F22DC1 for ; Mon, 29 Apr 2024 10:29:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA8C6381C8; Mon, 29 Apr 2024 10:28:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sY1jqojp" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035B137169 for ; Mon, 29 Apr 2024 10:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714386539; cv=none; b=kAoB/ZHWlwfWbPoyPDC3qtL1JxwEMkcPCCJquLIrk8Zuw8C1FJScVm1QWy+dGOAbPk1BKXCjcOhdonLn/3mjiOSgwyjycfKOvsCuWuklVOuyXLP7esqtTv+Qet/IGkejTGscsxQh4YCKW3Rsj5LawNC4OPXurFVGWjSejyxvv1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714386539; c=relaxed/simple; bh=2IDhjsMhb5aYhiqCE9TtV8L5uKIoVLzCbnj3R6GZewg=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=dJO8sV4QmI8KegNCwsXCvgS2bfg6iEVu06fKGtpk1UdrmCcE5Clm3DiCnU4KTPb9N/fHFVaKRu9SRWTQBG5Q2Tk2lxBvJJDzxkMlCYyr2sgtcKNugNrLip+eVws8Hv9ZiPeLeqn3ESenZkWJYdgBHLQ2Is5ENhC50wCB5icVVRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sY1jqojp; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 622B0C113CD; Mon, 29 Apr 2024 10:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714386538; bh=2IDhjsMhb5aYhiqCE9TtV8L5uKIoVLzCbnj3R6GZewg=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=sY1jqojp/kNqy2FM9Lm1z573PZOVnyeHLmzSq7ogYyxtBy0m5ixrh6NysQ1yFBrUB /jdEGixdLOyQWB7C9Do0QQm7v56/9D+yZdwKEmu4C4uvou35VlRccRXsd3QlEqY7Ml aBT5zlzXIJZUFwQd2WAT3dl3778e1U9/W5oc7KiiCML25nYNtp1RRxK/0vbzFk+RFA GNeNXwqK+7lGdRIMCf10rbq0goSC1K1awPNqDdE3qojDmPzm5oGARRWS1yYCLWdGFh OHlSD7m2WsbeEU9lDex4S2zEoZi209QeB9EBSp5/3HRrlLZpEjU4Iv37TO5ZQ7SJsA L/k9+oZIm4ezw== From: Robert Foss To: Jonas Karlman , David Airlie , Thomas Zimmermann , Luca Ceresoli , Neil Armstrong , Daniel Vetter , Andrzej Hajda , Jernej Skrabec , Alexander Stein , Maxime Ripard , Laurent Pinchart , Maarten Lankhorst Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Petazzoni In-Reply-To: <20240426122259.46808-1-luca.ceresoli@bootlin.com> References: <20240426122259.46808-1-luca.ceresoli@bootlin.com> Subject: Re: [PATCH RESEND] Revert "drm/bridge: ti-sn65dsi83: Fix enable error path" Message-Id: <171438653511.2566805.2252397252665472830.b4-ty@kernel.org> Date: Mon, 29 Apr 2024 12:28:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.10.1 On Fri, 26 Apr 2024 14:22:59 +0200, Luca Ceresoli wrote: > This reverts commit 8a91b29f1f50ce7742cdbe5cf11d17f128511f3f. > > The regulator_disable() added by the original commit solves one kind of > regulator imbalance but adds another one as it allows the regulator to be > disabled one more time than it is enabled in the following scenario: > > 1. Start video pipeline -> sn65dsi83_atomic_pre_enable -> regulator_enable > 2. PLL lock fails -> regulator_disable > 3. Stop video pipeline -> sn65dsi83_atomic_disable -> regulator_disable > > [...] Applied, thanks! [1/1] Revert "drm/bridge: ti-sn65dsi83: Fix enable error path" https://cgit.freedesktop.org/drm/drm-misc/commit/?id=2940ee03b232 Rob