Received-SPF: pass (google.com: domain of linux-kernel+bounces-162097-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f7ff317b-f91b-429c-ac09-61b338264890@redhat.com>
Date: Mon, 29 Apr 2024 12:49:54 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86: ISST: Add Grand Ridge to HPM CPU list
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
 markgross@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240422212222.3881606-1-srinivas.pandruvada@linux.intel.com>
Content-Language: en-US
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20240422212222.3881606-1-srinivas.pandruvada@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 4/22/24 11:22 PM, Srinivas Pandruvada wrote:
> Add Grand Ridge (ATOM_CRESTMONT) to hpm_cpu_ids, so that MSR 0x54 can be
> used.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

This looks like it needs to be applied on top of the fixes branch, or else
after 6.10-rc1 is out.

Ilpo, what do you think ?

Regards,

Hans

> ---
>  drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index 30951f7131cd..1accdaaf282c 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -721,6 +721,7 @@ static struct miscdevice isst_if_char_driver = {
>  static const struct x86_cpu_id hpm_cpu_ids[] = {
>  	X86_MATCH_INTEL_FAM6_MODEL(GRANITERAPIDS_D,	NULL),
>  	X86_MATCH_INTEL_FAM6_MODEL(GRANITERAPIDS_X,	NULL),
> +	X86_MATCH_INTEL_FAM6_MODEL(ATOM_CRESTMONT,	NULL),
>  	X86_MATCH_INTEL_FAM6_MODEL(ATOM_CRESTMONT_X,	NULL),
>  	{}
>  };