Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761339AbYA1ONz (ORCPT ); Mon, 28 Jan 2008 09:13:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757254AbYA1ONs (ORCPT ); Mon, 28 Jan 2008 09:13:48 -0500 Received: from namei.org ([69.55.235.186]:52571 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757649AbYA1ONr (ORCPT ); Mon, 28 Jan 2008 09:13:47 -0500 Date: Tue, 29 Jan 2008 01:13:03 +1100 (EST) From: James Morris X-X-Sender: jmorris@us.intercode.com.au To: Herbert Xu cc: Linus Torvalds , Andrew Morton , "David S. Miller" , Linux Kernel Mailing List Subject: Re: [AUDIT]: Increase skb->truesize in audit_expand In-Reply-To: <20080128111018.GA6442@gondor.apana.org.au> Message-ID: References: <20080128111018.GA6442@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 31 On Mon, 28 Jan 2008, Herbert Xu wrote: > Hi: > > [AUDIT]: Increase skb->truesize in audit_expand > > The recent UDP patch exposed this bug in the audit code. It > was calling pskb_expand_head without increasing skb->truesize. > The caller of pskb_expand_head needs to do so because that function > is designed to be called in places where truesize is already fixed > and therefore it doesn't update its value. > > Because the audit system is using it in a place where the truesize > has not yet been fixed, it needs to update its value manually. > > Signed-off-by: Herbert Xu Acked-by: James Morris (Candidate for stable ?) - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/