Received-SPF: pass (google.com: domain of linux-kernel+bounces-162150-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <eb15ab0a-e416-4ae9-98bb-610fdc04492c@web.de>
Date: Mon, 29 Apr 2024 13:31:13 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Bard Liao <yung-chuan.liao@linux.intel.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
 linux-sound@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Bard Liao <bard.liao@intel.com>,
 Vinod Koul <vinod.koul@linaro.org>
References: <20240429004935.2400191-1-yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH] soundwire: fix usages of device_get_named_child_node()
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240429004935.2400191-1-yung-chuan.liao@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:c8GE1h8qdHE=;VvLBTWnInpeRHE/89SbHNIXQ+eG
 GcJSp6rzdek4ag5G/VInqebJFNI45zC40MyuHoeDRZbROtt5CJW8RUL8/gEEHmEtxdCbPWwRO
 g41YqhN8k8QmKygQhCLarb7X3jYveI7TBA6Ke+CBz2Eq24jHENJKU6RDu8V0/RcVYdp6N5egY
 LRMSpn96iybJEEgnynNdOLj0QGghw0V+CRPX0qZ7Fll3a8Ut03ErsSRvOioI3kh342tyoqjTn
 zI4xgcypA47CrOO5JEWFXwPLyru247ZIUoQPfmUsxq2ucZjx7qBBxm2bIlc+OWcLJoydPfQpp
 4BggJd5S8qwEI78aYN6I+PDh3bpwQyd6DWdMAWCHRUEHMQhoBsjLpaF0L4oQXQwXtr72gumJK
 kT0KtJZceTrpZDIDCPdIvA78FhzHcKAWj/ua1K2zSUoy/4p50P+K9cRi6aqiI4vp3+TmjJ0K4
 6VrGfbbpXKmhMjAWggCbOD8Op+XJyptHFE89MlVhNjdm8yAIURa8EKXue4oTNk9zqlyHz7RUK
 uld87BjG5fJQ9CmK24siwsZYGrukMuwDqJeNJ40OzA5pUs1hA5wgtFQQbgufm6yWfjmy67q6Q
 pdFvsrQ8K4do0dAcBufkdfSaKa4EshT5o4Vu3LhZ+A8iBpvds6CvoxO6qYuyzO5zzUlaoNatJ
 hdFV+7iN8LpQAoyVywMHeyuBGpVEVsUM3eCvAz2eXSMHD0GAY5JzfxB7YWCJHEibwlu8ARwyI
 +kDum47ykBhCRMc2sHIO7cVeqhwRtHDJ7WwbBFzgL4eftg6spzF8zzN/AKAYfMTvJkxsaUbMz
 2xZ298IaXjjJi9HMeAqTi7rRc0Px/fFsk4lXLjMKjjPpw=

=E2=80=A6
> Add fwnode_handle_put() to avoid leaked references.

                          calls?

Would you like to add the tag =E2=80=9CFixes=E2=80=9D accordingly?


=E2=80=A6
> +++ b/drivers/soundwire/mipi_disco.c
=E2=80=A6
> @@ -236,8 +244,10 @@ static int sdw_slave_read_dpn(struct sdw_slave *sla=
ve,
>  						       dpn[i].num_channels,
>  						       sizeof(*dpn[i].channels),
>  						 GFP_KERNEL);
> -			if (!dpn[i].channels)
> +			if (!dpn[i].channels) {
> +				fwnode_handle_put(node);
>  				return -ENOMEM;
> +			}
>
>  			fwnode_property_read_u32_array(node,
>  					"mipi-sdw-channel-number-list",
> @@ -251,8 +261,10 @@ static int sdw_slave_read_dpn(struct sdw_slave *sla=
ve,
>  					dpn[i].num_ch_combinations,
>  					sizeof(*dpn[i].ch_combinations),
>  					GFP_KERNEL);
> -			if (!dpn[i].ch_combinations)
> +			if (!dpn[i].ch_combinations) {
> +				fwnode_handle_put(node);
>  				return -ENOMEM;
> +			}
>
>  			fwnode_property_read_u32_array(node,
>  					"mipi-sdw-channel-combination-list",
=E2=80=A6

* Would you like to complete the exception handling by using goto chains?

* How do you think about to increase the application of scope-based resour=
ce management?


Regards,
Markus