Received-SPF: pass (google.com: domain of linux-kernel+bounces-162185-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1d9cdfa05150a389433aa399b44fcbcff5bed258.camel@gmail.com>
Subject: Re: [PATCH 1/8] iio: adc: ad_sigma_delta: use 'time_left' variable
 with wait_for_completion_timeout()
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
	 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, 
	linux-kernel@vger.kernel.org
Date: Mon, 29 Apr 2024 14:06:05 +0200
In-Reply-To: <20240429113313.68359-2-wsa+renesas@sang-engineering.com>
References: <20240429113313.68359-1-wsa+renesas@sang-engineering.com>
	 <20240429113313.68359-2-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-04-29 at 13:33 +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeo=
ut'
> to
> store the result of wait_for_completion_timeout() causing patterns like:
>=20
> 	timeout =3D wait_for_completion_timeout(...)
> 	if (!timeout) return -ETIMEDOUT;
>=20
> with all kinds of permutations. Use 'time_left' as a variable to make the=
 code
> self explaining.
>=20
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/adc/ad_sigma_delta.c | 6 +++---
> =C2=A01 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad_sigma_delta.c
> b/drivers/iio/adc/ad_sigma_delta.c
> index a602429cdde4..40ba6506bfc1 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -206,7 +206,7 @@ int ad_sd_calibrate(struct ad_sigma_delta *sigma_delt=
a,
> =C2=A0	unsigned int mode, unsigned int channel)
> =C2=A0{
> =C2=A0	int ret;
> -	unsigned long timeout;
> +	unsigned long time_left;
> =C2=A0
> =C2=A0	ret =3D ad_sigma_delta_set_channel(sigma_delta, channel);
> =C2=A0	if (ret)
> @@ -223,8 +223,8 @@ int ad_sd_calibrate(struct ad_sigma_delta *sigma_delt=
a,
> =C2=A0
> =C2=A0	sigma_delta->irq_dis =3D false;
> =C2=A0	enable_irq(sigma_delta->spi->irq);
> -	timeout =3D wait_for_completion_timeout(&sigma_delta->completion, 2 *
> HZ);
> -	if (timeout =3D=3D 0) {
> +	time_left =3D wait_for_completion_timeout(&sigma_delta->completion, 2 *
> HZ);
> +	if (time_left =3D=3D 0) {
> =C2=A0		sigma_delta->irq_dis =3D true;
> =C2=A0		disable_irq_nosync(sigma_delta->spi->irq);
> =C2=A0		ret =3D -EIO;