Received-SPF: pass (google.com: domain of linux-kernel+bounces-162246-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 29 Apr 2024 13:24:15 +0100
From: Gary Guo <gary@garyguo.net>
To: Benno Lossin <benno.lossin@proton.me>
Cc: Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>,
 Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun Feng
 <boqun.feng@gmail.com>, =?UTF-8?B?QmrDtnJu?= Roy Baron
 <bjorn3_gh@protonmail.com>, Andreas Hindborg <a.hindborg@samsung.com>,
 Alice Ryhl <aliceryhl@google.com>, rust-for-linux@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rust: init: add re-initialization functions
Message-ID: <20240429132415.3039940d@eugeo>
In-Reply-To: <20240425213419.3904105-2-benno.lossin@proton.me>
References: <20240425213419.3904105-1-benno.lossin@proton.me>
	<20240425213419.3904105-2-benno.lossin@proton.me>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MN7cL+YSGjEMi2mMRIdoblRdOGabtiT/sffQM7w2BfDAwkCjTWOQPAv0F4at?=
 =?us-ascii?Q?CHpklDmNhlrGQSZhvFc1qzkXW3772DiEHxqGFGaaKtXvjFH9s061yiZf4TcJ?=
 =?us-ascii?Q?8B55GjV4IjNAzMm4u7wwW1LB3oV5sy23obo1MWBwu2vPbNSRm99ms573VmL0?=
 =?us-ascii?Q?0cyXJ+cVuxKeq/whrysrFIY2zyvl89lNhYtvpXn7auC2pqi6cNNoiKze9S4/?=
 =?us-ascii?Q?9EZNJgW2Qy4lt/3USVPgbYllCA19cKXXZSsL50toDYyBL3HSduOTZ2oku6gz?=
 =?us-ascii?Q?BYAYmbivkVQKbBgRcVUfgHCD/479KNBEQKg1ZOd7aM068y7Q6HV6iHuqiDFR?=
 =?us-ascii?Q?bVq9kr3ahbtvURHzuA6urtv0DPJwDZ1GuIyL3M2kEDOY5W9Z3mwPHjWHHVQO?=
 =?us-ascii?Q?/8uMh08Wdi098E9A2voFLw85LT75E3CCQR44OUBMhoBYGGVvGUWS90snmlwu?=
 =?us-ascii?Q?9idk2xqzPhqifpt3wQP/QlgtM6qU4x80w1WkaC8y16omEMJ8IjrRpr+kcXki?=
 =?us-ascii?Q?ycfWxKqNhr0Qq9VvohTsB2x1YfMR4AWZ6Yofd/8N2f1v0DjOHZGbtpM2OO19?=
 =?us-ascii?Q?TFZSsXPBP6v22I6o+vS7PsC4i8DHKEjW2ThC3Rnvz0ukGRS+VRok3nCiGVtk?=
 =?us-ascii?Q?HBKPQIO8slCItiqa2+DcZaApSl19mG2CHF6A9BWm+c85TC6DquYCVXpSdWJm?=
 =?us-ascii?Q?zB0D04AJkGnrAOssNGIqB4luZ2OngbAHahd0QhCbB/gCUkXFaxYWOkBM6LoE?=
 =?us-ascii?Q?CTqnxV0YnhmU96ci1j5OB/Qk0HVfNdpOQYqSGhkWLq45e4eQrVGrfoSrQDwG?=
 =?us-ascii?Q?8N4j8Nef5XA+hzIKRINCo2am0Dtx6TkLaCVrVFKhGkeLL97nG6m5nUhhbsO+?=
 =?us-ascii?Q?LHTIoQzFO2F9XQstJ/G4sAfxnnJhz9nUUhF3ryR2ZiBTaKVQzGywAopxLdT8?=
 =?us-ascii?Q?C9PRMNsvlqR9oiKxBWJ1n7Muu+HAXnaSBmOxJoHAsPzeKVDE0qrQvE+SGFpy?=
 =?us-ascii?Q?jzl4vltTO4PgAU3Yhkh7pKSY5X2SKVaOLB45ksNOUFxY07LDSL1atl/OxPnD?=
 =?us-ascii?Q?yaiXNfP4TD/59ygj37orvuE2su4YyZ4zZzClcMMp8aCts07JfZ0atIs0i0GH?=
 =?us-ascii?Q?450WRtCGGZSOUK8/kzRdl2vfpqksOIl2wV2YZUGA0ipSZDCg5f4cLlqXJyhL?=
 =?us-ascii?Q?FDExYmIq+QVlqz8ZGEWYHLintuCCdgpH6/qOld8ILneL4SwaGOIcecNycZjH?=
 =?us-ascii?Q?4XX3aAY12tuFZZzlNkfYaeTbnxLCKhYw4EQ/FlmscZWhyXpW/AIbQjmqPNhx?=
 =?us-ascii?Q?96qMgXwt8V3yvZmV3pfeG8vGCgh7BQ8Fs/Xyxr6oInDZPQWg9VylM+x57c3U?=
 =?us-ascii?Q?L9bP6DlOO/6bc7dJtJUCVfyiWLWc9z/pxFd1bSeBrFKmeiI93TmX9irWECNd?=
 =?us-ascii?Q?FcvHcCWUqV36ET6VTWdQ/NCeWFM1IkI1LCEhRg/dMYohuwRKFgiPFPAdj5G2?=
 =?us-ascii?Q?WMBcwY4rXI8PDq+nIZrlzgspZGuapiSvKWPl+tUznriYskNnzn1xIQwD0IsD?=
 =?us-ascii?Q?/02t+VSyITvEwilnEPx0rejY0hVfDRTFxm0BxAnY?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 852f5cfc-edfb-4960-0ea4-08dc68474ad7
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 12:24:18.9424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JJP4OYn2t9YqTmjU4YmNLoi4IoDplOil7EOa+inm/7YjHg/cvomqDHGezS5mIf5ib211MnrBJdIkD25gV62Ivg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P265MB3070

On Thu, 25 Apr 2024 21:34:44 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

> Sometimes it is necessary to split allocation and initialization into
> two steps. One such situation is when reusing existing allocations
> obtained via `Box::drop_contents`. See [1] for an example.
> In order to support this use case add `re_[pin_]init` functions to the
> pin-init API. These functions operate on already allocated smart
> pointers that contain `MaybeUninit<T>`.
> 
> Signed-off-by: Benno Lossin <benno.lossin@proton.me>
> Link: https://lore.kernel.org/rust-for-linux/f026532f-8594-4f18-9aa5-57ad3f5bc592@proton.me/ [1]


I don't find the re_init name very intuitive. From the name I would
imagine these functions be taking a `Box<T>` and a `impl Init<T, E>`,
dropping the content and produces a `Box<T>` again.

Would it make more to rename the existing functions to have `new` in
their name to indiciate that they allocate, e.g. `pin_new`, and have
these functions that only does initialisation `init`/`pin_init`?

Best,
Gary