Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1320044lqa; Mon, 29 Apr 2024 05:29:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVFTA58i++ttDXIMegCBn70i36RAInGhQFm1X5iZP428trALl2Df5vUdYCM2TDt+QErDct4F2FN3oVnFE5TQUEoenRAQOxqZE3wtvIV1w== X-Google-Smtp-Source: AGHT+IG0PkSM7X73tUN/WYu//BWRyBVcTXlvb2gDAZwtNnG5S+tacl1wJLcFwdd75f/wyJR/Ucs2 X-Received: by 2002:a05:6a20:729d:b0:1a7:5402:8a92 with SMTP id o29-20020a056a20729d00b001a754028a92mr12385131pzk.31.1714393799027; Mon, 29 Apr 2024 05:29:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714393799; cv=pass; d=google.com; s=arc-20160816; b=yTU0i8/jtYb0NNjNnun5HF8V10yy8M/iMerzJ45YWDVQhXAOhlF85mCe77Ezgz0hMX cQ1QfNszscE5SApCf0Zl4mN/sUkwx8rzrz6FtATc6cGDpJ084+yXJ0KcP7nHJeouNTJ4 0vcrMS6e9uvQHU7xsrXNyXI3FPkrHoiEJnj5aQuNPUEdGlgGs1lypRr8LHZlISdYxW3V IqvOnm59MMBFuqi8/za3pUlvre+zwNThdBBN+N/9Xg1zle5D053n/NvGgCBgxyzMiCKF tK8KwB0MUxqNetQDYnncM/9pVyiCbLcoSlXjv4cm9O2RrIHXforBjRio+mg5MuXtZTRS wOoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=55Zi9dSPjmV6EHr7HXJBBK0GAS5n6uFRNxp94MfZdBU=; fh=sP/l8MUS16FjYZzo9Wg89EetJb2xlU4iSB5yEaKfPzc=; b=zwUuFxKBg3Qmmf4faCNBV6S+rSxGuguJAEZ4ImU/hKrBzqi1U55a5N4sh+UUoG6PCR amTnqY8zhG7Aggx5I/OdJBHw/azy49Ci0Kn36+sCLhEV1R7JnCG9Ry6G9wVCAGFfctXL srfC3T2ZOSLuMz0smyRmtEPmrEccGQN8VG7YU9R6E20+L7Vf9tFgy1Q7fp7jBu/k41uA uxqIkyPIxujPrAowN6wVyo0RUhSgHlcEpIW3ULTEqf0H/A4NFnyUd9H8ZsQECNl2nWLv Ln8SXpLzMbaP3BJBW78YcczAOcsYifEoo7v3bzR2iF8R0JlTGiPwEg/Pa1BjSrouYJJI bfYg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=qLUQsOww; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-162239-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162239-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id m9-20020a655309000000b005dbedc825b5si19647067pgq.521.2024.04.29.05.29.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 05:29:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-162239-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=qLUQsOww; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-162239-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162239-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 36A2D2862CF for ; Mon, 29 Apr 2024 12:23:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0F9AB83CB9; Mon, 29 Apr 2024 12:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qLUQsOww" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A906A348; Mon, 29 Apr 2024 12:19:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714393190; cv=none; b=cnFBj/9+l/Jkz46bMijV7TWSXLNGN1L2cyZUo9HZ3MidcJI8dW4H+71AXCyiZp+LolmsNeOjxzOSVRV6D9o87MfBOUckOt6fpNIyILUH+Uh5moJnNKKrKSub9PPYyOwAUV5yxVrAc5oWEcql+LKA0C5wb6GG8jdyogUH4HS+EGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714393190; c=relaxed/simple; bh=Fl9BhUxNImaCXdVN/1n68+3txGl5bOMxWJDJ36ZX+3A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jjhw8Bk8RcPoUiq4zCrRFb2yaZspbaWGZngDcYiqqndUUcSOScmmKr2Jyq/TVy6POKlbVzWt8jeuRSjcIVyQAP/yHpU6ypcvrgVZDlMMFHT+Z7PQTMsdzRi5GX2LmiYTHkSwgpJFH18beehwottDMD6TFt0gYKuFO9Xzof7VHIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=qLUQsOww; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=55Zi9dSPjmV6EHr7HXJBBK0GAS5n6uFRNxp94MfZdBU=; b=qLUQsOwwolipCNVXpGEyEnoXAw PQUEuVzOIPv1Xra3ZcnQ8/4vEmqxgy17IPjhTjhQlOJTL2tEL7Fhbg/mCN86z+XXuvKN9k3VJznlQ u867a5LQb+Ba7RbPrkr+dhEgP2nj8UsgbIz8Syvjx4H/92JStHWIIaNVUZUf+kKZJbg8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s1Pyo-00EFN7-Sg; Mon, 29 Apr 2024 14:19:34 +0200 Date: Mon, 29 Apr 2024 14:19:34 +0200 From: Andrew Lunn To: =?iso-8859-1?Q?Ram=F3n?= Nordin Rodriguez Cc: Parthiban.Veerasooran@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, Horatiu.Vultur@microchip.com, ruanjinjie@huawei.com, Steen.Hegelund@microchip.com, vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com, Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com, benjamin.bigler@bernformulastudent.ch Subject: Re: [PATCH net-next v4 13/12] net: lan865x: optional hardware reset Message-ID: References: <20240418125648.372526-1-Parthiban.Veerasooran@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > Additionally I figured out why my setup did not work without the HW > reset, I had missed a pull resistor in the schematic that held the IC in > reset. Having a reset controlled by software is a pretty common design. Something needs to ensure the device is out of reset. It could be the bootloader, but i don't particularly like that, hiding away critical things where they are hard to see. So i think having it in the Linux driver is better. There is an open question of does the driver need to actually reset the device, or is it sufficient to ensure it is out of reset? The wording of the standard suggests a hardware reset cycle is probably not required, but why did Microchip provide a reset pin? Andrew