Received-SPF: pass (google.com: domain of linux-kernel+bounces-162249-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 29 Apr 2024 14:30:22 +0200
From: Borislav Petkov <bp@alien8.de>
To: Michael Matz <matz@suse.de>
Cc: Jiri Slaby <jirislaby@kernel.org>, Ard Biesheuvel <ardb+git@google.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>, Song Liu <song@kernel.org>,
	Ricardo Ribalda <ribalda@kernel.org>,
	Fangrui Song <maskray@google.com>,
	Arthur Eubanks <aeubanks@google.com>, stable@vger.kernel.org
Subject: Re: [PATCH] x86/purgatory: Switch to the position-independent small
 code model
Message-ID: <20240429123022.GBZi-S3p4vlPK10pYM@fat_crate.local>
References: <20240418201705.3673200-2-ardb+git@google.com>
 <3f23b551-4815-4a06-9217-ff5beeb80df2@kernel.org>
 <20240420131717.GAZiPAXY9EAYnHajaw@fat_crate.local>
 <836c267f-a028-acce-8b19-180162a5febc@suse.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <836c267f-a028-acce-8b19-180162a5febc@suse.de>

On Mon, Apr 29, 2024 at 02:05:12PM +0200, Michael Matz wrote:
> It may be so ingrained in my brain that I'm not _always_ saying it when 
> talking about the large code model over a beer.

Doh, you should. This is what you start with! :-P

> And indeed I know of no particular problems with it vis GCC, but that
> doesn't mean it's a good idea to use :-)
>
> So once again: "everyone should simply stop using -mcmodel=large.  Noone
> should use it."
>
> So the patch goes strictly into the direction of betterment of the
> universe. :)

Yeah, it is already on its way to every kernel near you. And looka here:

$ git grep mcmodel=large
arch/powerpc/Makefile:125:      # 64bit relocation for this to work, hence -mcmodel=large.
arch/powerpc/Makefile:126:      KBUILD_CFLAGS_MODULE += -mcmodel=large
arch/um/Makefile:34:    KBUILD_CFLAGS += -mcmodel=large

x86 is all free of the large model now.

One less thing to worry about - gazillion more to go.

:-P

See ya on Thu.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette