Received-SPF: pass (google.com: domain of linux-kernel+bounces-162370-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <700ae50c-2fd6-4bcc-8840-f426558b847f@collabora.com>
Date: Mon, 29 Apr 2024 18:28:53 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v1] fs/proc/task_mmu: Fix loss of young/dirty bits during
 pagemap scan
To: Ryan Roberts <ryan.roberts@arm.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 David Hildenbrand <david@redhat.com>, Peter Xu <peterx@redhat.com>
References: <20240429114017.182570-1-ryan.roberts@arm.com>
Content-Language: en-US
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <20240429114017.182570-1-ryan.roberts@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Thanks!

On 4/29/24 4:40 PM, Ryan Roberts wrote:
> make_uffd_wp_pte() was previously doing:
> 
>   pte = ptep_get(ptep);
>   ptep_modify_prot_start(ptep);
>   pte = pte_mkuffd_wp(pte);
>   ptep_modify_prot_commit(ptep, pte);
> 
> But if another thread accessed or dirtied the pte between the first 2
> calls, this could lead to loss of that information. Since
> ptep_modify_prot_start() gets and clears atomically, the following is
> the correct pattern and prevents any possible race. Any access after the
> first call would see an invalid pte and cause a fault:
> 
>   pte = ptep_modify_prot_start(ptep);
>   pte = pte_mkuffd_wp(pte);
>   ptep_modify_prot_commit(ptep, pte);
> 
> Fixes: 52526ca7fdb9 ("fs/proc/task_mmu: implement IOCTL to get and optionally clear info about PTEs")
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

> ---
>  fs/proc/task_mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 23fbab954c20..af4bc1da0c01 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -1825,7 +1825,7 @@ static void make_uffd_wp_pte(struct vm_area_struct *vma,
>  		pte_t old_pte;
> 
>  		old_pte = ptep_modify_prot_start(vma, addr, pte);
> -		ptent = pte_mkuffd_wp(ptent);
> +		ptent = pte_mkuffd_wp(old_pte);
>  		ptep_modify_prot_commit(vma, addr, pte, old_pte, ptent);
>  	} else if (is_swap_pte(ptent)) {
>  		ptent = pte_swp_mkuffd_wp(ptent);
> --
> 2.25.1
> 

-- 
BR,
Muhammad Usama Anjum