Received-SPF: pass (google.com: domain of linux-kernel+bounces-162437-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <891ec639-e557-4dbe-8afa-3317b9c173ce@amd.com>
Date: Mon, 29 Apr 2024 10:25:02 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, robert.richter@amd.com,
 linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
 tony.luck@intel.com, x86@kernel.org, Avadhut.Naik@amd.com, John.Allen@amd.com
Subject: Re: [PATCH v2 07/16] x86/mce/amd: Simplify DFR handler setup
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-8-yazen.ghannam@amd.com>
 <20240424190658.GHZilYUvw1KfSfVd_e@fat_crate.local>
 <e0d10606-4472-4cde-b55d-34180efad42b@amd.com>
 <20240429125956.GNZi-ZzN1Izxps8ztT@fat_crate.local>
 <d1e329da-6a04-47f7-bdab-ea6c4f584802@amd.com>
 <20240429141244.GGZi-q3NdmI17pai4N@fat_crate.local>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240429141244.GGZi-q3NdmI17pai4N@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z25zY1VwV3lXNThsTFZiNmxpZFRSTEs3R0FYcjYyRTJjWThRZkFoYkNiL1hG?=
 =?utf-8?B?cVFmbzRtNFVhT2tPU3FCNVB1VjlMMWNwMjZXeGpvQm5MWnlVR1pGWkNhMS8r?=
 =?utf-8?B?NWRybVcyTVNUSlpvVXlCc3JmN09veUgzY0J0UURiMVA1bldMM0dkRmFUbkJV?=
 =?utf-8?B?YVN1Yzhlc0VXdGx4R2ptQjRVMVd4akUvZUk0R0hMUDlTRVpNN2gxNDZXVllQ?=
 =?utf-8?B?V1ZzV3N4ekgvcHlYKzdWaUg5MFZlcHN0anltRmtWWDlFM0MyU0EwZTBER1VQ?=
 =?utf-8?B?N3FxZ1BvUmozdnhYUCtpWmlnUjhENWo3am9oZlhsR2xjMmYwaWMzRno4eGFH?=
 =?utf-8?B?YnkxYXMvTHM2blI2RmhSQVNsaWI2S1FyRGlJMklDcDJIMS8wUStSbzZnVTZX?=
 =?utf-8?B?TmM3bVRJSjFITzZMVzlRdHcrN3pHcDY1eEFqYStvVWdjUzhWVFBlbC9hRGlx?=
 =?utf-8?B?a0hlSCs0VDliV1BkOXFFRVhNQlo3MXF2ajlBaEEwZmVnWjJTenB1TXpaaHYv?=
 =?utf-8?B?eEdoQ2M1cXMxRllTZkZOa3BLMUs5SXZpMDJLdENTdHEzMWc2VEJaWGJWampi?=
 =?utf-8?B?SlFzbFhYUVpRcXhSOFQ2VWxCdGs1cFZ2SXZaYnphRjlvQmtBS29xV05UcVFS?=
 =?utf-8?B?bTNsQ3ErSExOSVRNNmMvNWpkS3lXRzFrREZVSHdaQTdPeEdCS050M3BwelI2?=
 =?utf-8?B?WlBYSHlxanJicENuMHcrYlQrb1ByRzBhVHI3aHF1d1VRWEw1NVcvTU84Qkxp?=
 =?utf-8?B?R2QyK1VhcmwvR09DS1lvTW42REFKMGE1NDh3S1VqRzNXL2hFYm43TFZaQlg0?=
 =?utf-8?B?TDV1cFN3RG1NNGRpdnVRL1E1aU5jSTdmVWpjUGd6Sk90YVlVRzdHSC9ZYnpK?=
 =?utf-8?B?K1hsUUdzYWVmelNrSDg5dXlqMDB1U1FYZldlUFFRMmVWRVFpOXNiL2VOQllP?=
 =?utf-8?B?WW9FbUNGTCtaSXc2UFZ4SFEraVpKRXUrT21sT1MxSmdJVmdxM3QyQWJCdWN4?=
 =?utf-8?B?dndYL2lOLzJkeGFLMnhwQzlhQ2hVMXh1TGNTeTBsdG5CVXFucE4xOVlQQWw2?=
 =?utf-8?B?TkYzOTU2WUhiMWs3OXBCTVpGdDkxY2RWK0FSUThVdTZwbXZQWEtOczNjZG9k?=
 =?utf-8?B?RTlQNGZ4bXJ2dXNuWXgvQUtWeWlOR0lVaW0zZ2ZDNkhWNE1lek9obnZhbzlP?=
 =?utf-8?B?aDZybjY0S01EVXBLeU56QUdrdkxKczhKR2tZZExZTGlkNUhaNCtwMkpaWjZT?=
 =?utf-8?B?ZTR5R3ZBcHJhYUhuZk0wUlI0bE1UL1V1V2sycEFLdmR1cEdPeEJsVEJhQVRO?=
 =?utf-8?B?TDcyOEVrK01xbWN6TzBYeUZIOFY2QVBtUnN4cFhYcktwUkJHSmp3Y3ZDVUZ3?=
 =?utf-8?B?VkZKVkYySERKSVBpb0ZSOTgvNVh3STVBUndweXo4cDQ4eldtU1h4Zjk1WVp3?=
 =?utf-8?B?OE5aWUVRV3FCbURRR2xRZUN3WDhmdHRPRzQ3NzVwK0ZpaHdCNEdtU3VtNlhJ?=
 =?utf-8?B?TElNQ3JkYUt2T0NBeTZOc0VTcWJWNkkwTzhPSmlESklYTmdXclFKNVgrSTJo?=
 =?utf-8?B?c3F6c2d6anhxc29QeEM2R210SVRFYlc2aG40aytSVFlaMGRqUkppclEyblRY?=
 =?utf-8?B?QkFFT3ZHZEtSYnpqUmtIVSt4SHYwanRVa2xZSVN5QzVnTnZqYmliSGh4WE92?=
 =?utf-8?B?RmRXeDVIamVsQXF0MDRkOGtFajJoRHlkWnVJQXJtWFRXY0VpK0FDNm5QSHJC?=
 =?utf-8?B?S2pRWkpjeDg1Z0ZRY1FCZDVXNDkweVdqYmhWWlM0TWZXYzVNT01DYkFpN1l4?=
 =?utf-8?B?VFVDQ256TGtsa2NQRkFpdWNJdDV4cnNXbEthb0RnMHJRbFVtMDkxZkJYamVE?=
 =?utf-8?B?TTJKTW5jeHVyOEpSMVVCTVpmTVByWEk4anlFWnFwYXJTemNxWDByeURtZmY2?=
 =?utf-8?B?YTdWYmJwZENRaUU2WC9NZnV2Z2xNdmRiUkx1cTJRNUFVR2ZJb2plQzVFVzA2?=
 =?utf-8?B?Z3lmM2pNcWlQRjd0RU1QYmZDNVVuNk04NVcyWlN0WDZwNFd3SDBlRDNjYlBr?=
 =?utf-8?B?Y2VoSmR1LzkvVkpWa0NKKzY5Q29KNGFEUkplRzl6ZVpMVWlScG9MRWFBbDRu?=
 =?utf-8?Q?LvFZOu+uaO2YnoU8xotwH5gNI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f94da89-1948-47a7-03e6-08dc68582960
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 14:25:04.1070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kQwI7Eea2dTjD8UigPXIKjvsr9MDcZTS2ciCAE+WIZdURTi8ejZbLIBFoZsztOKvBmfeF/Z6zmBpqvxw53USKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5853

On 4/29/2024 10:12 AM, Borislav Petkov wrote:
> On Mon, Apr 29, 2024 at 09:56:56AM -0400, Yazen Ghannam wrote:
>> Right, I mean we should do things the simpler way unless there's a real issue
>> to address.
> 
> You need to pay attention to past issues before you go, simplify it and
> break it again.
> 

I completely agree. I haven't seen evidence of an issue yet for the DFR case
though. Which is why I thought it'd be safe to do some clean up.

>> I'm not opposed to this, but I don't understand what is at risk.
>>
>> Is it that the function pointer may not be written atomically? So even if we
>> write it again with the same value, a concurrent interrupt on another core may
>> see a partially updated (corrupt) pointer?
> 
> Yes, it won't happen, they say as it is guaranteed by the
> architecture. But I've heard those "promises".
> 
>> intel_init_cmci() does not do this check. So is it more at risk, or is the AMD
>> code just more cautious?
>>
>> Again I'm not against the current code. I just think we should simplify it, if
>> possible.
> 
> So in looking at the INTR_CFG MSR, I think we should do a function which
> does MCA init stuff only on the BSP exactly for things like that.
> 
> There you can set the interrupt handler pointer, the INTR_CFG MSR and so
> on. And we don't have such function and I've needed a function like that
> in the past.
> 
> And just for the general goal of not doing ugly code which should run
> only once but is run per-CPU just because our infrastructure doesn't
> allow it.
> 
> Wanna give that a try?
> 
> Thx.
> 

Yep, "MCA init cleanup" is another thing on my TODO list.

The BSP still completely finishes init before the APs, correct? I recall some
effort to make CPU init more parallel, but I haven't been following it.

Thanks,
Yazen