Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1403528lqa; Mon, 29 Apr 2024 07:37:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWlYNQWBnKmL9H1f40kd27/tOmXvR41fAPBNTja6u27fFAmLavbKhibk/vnu1ottC+4q0DxXbbArT4ouC8LJCu5TiM6Rnx89XH0Kdzkmw== X-Google-Smtp-Source: AGHT+IEzEzH2gOhg7Eo6WGHA2B6HOBern65jxDBhp9UejyvWYCyRE8q+sRbv17OsZlVWKhcydISR X-Received: by 2002:a17:903:32c5:b0:1e4:9d6f:593 with SMTP id i5-20020a17090332c500b001e49d6f0593mr12358390plr.36.1714401467785; Mon, 29 Apr 2024 07:37:47 -0700 (PDT) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id z5-20020a170902708500b001e3e1e5f00bsi19691944plk.112.2024.04.29.07.37.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 07:37:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-162455-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-162455-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162455-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 699A62816A9 for ; Mon, 29 Apr 2024 14:37:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 260927E774; Mon, 29 Apr 2024 14:37:37 +0000 (UTC) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A58DC7E105 for ; Mon, 29 Apr 2024 14:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714401456; cv=none; b=Bj89VxL2QLWngZwBLWHvgf51yja70uYSSBjdwYJr4rKgnBYafNoEI0IsY5ljSy3c2Dl6j1c+VXuQ2jb48QCg+V/2HPa16Fl5sINsq3LjlyB6ARBQ9je4Hp8CdFZWGGiHNRmUyF54qD9heQW5lcbxoRZGzNH8Zg1U5gJCMwiDvDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714401456; c=relaxed/simple; bh=o76I6uYyuIHYHMcSkzurzNhgHFDpP4E7YAUzENMyBn0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Wp4LlIWBA2qpA0YpdrAKGpGm6+czKmH6VzoMAY05vVZQK9ZZfhQnP8bxDLtPa8vyeTPthrxZpuuXYfFKm4OPPQCI/82q84XAS26zqqabbByNP3mKVNT9+6mhLJICMT/6vwRkLkCLBuAP3R3qSrMOjHV8c0UnkUqyhpwSlxplkJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.219.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-de54cb87998so4876777276.2 for ; Mon, 29 Apr 2024 07:37:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714401452; x=1715006252; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1B8TUxX3GMUuuf6X9eCvF4beZUOUbPqjMpWnhsqSxGE=; b=cj8hnyeJk0TDAftS+LxaVqUlBG+DXz8Iq84lWhQxITlV4om9Xb+jIzkPnnH46p0sIK z6JJrcJKEp+pT+DzWNNnIlFpPnr0FpQKN/EcyD3XUKdUnxSqmwLen/EEgO0YHr6dx2IJ NGRvIRe9BTAb9j945etX2lSxm2TuQNaLrZyr3sPAbnXLBruSEtISbaDzxuKOxtbOsNsF AIexIwFgfnEhOyNDDx7SLB61pvQcF1b2ACYi3s3ZJm+J6ANWnVzoDSeY5aFJaubSUcrY 3kqiZoxQD6YmZcVr0JUV1a+Fcbb3tQYsajs+qh7Ga6wUmpZ/qXwnj7Nl8gGZSAQ0wp19 P3gg== X-Forwarded-Encrypted: i=1; AJvYcCWePtzZ+PgqqoGgMuH6XOaKVGmNQ+xEK8XS5wb9K6c/2uo0cFigDTJ/n2HMYVZIjkZXwu5fSBHVvsjpdk9qciD9Y/cPG3eF5wEOVGwv X-Gm-Message-State: AOJu0YwxaeUklAKv30c2TI37wf6iQP/+N8cspIndkBwJQELon+2w1G+q ArtxN5+6lZEkPwKaXdzk9R+YW2yrXqNWDlPBYQbOceQKW1nlwMKEN0Lx8LRW X-Received: by 2002:a05:6902:220b:b0:de5:4a91:11c4 with SMTP id dm11-20020a056902220b00b00de54a9111c4mr13778234ybb.44.1714401452551; Mon, 29 Apr 2024 07:37:32 -0700 (PDT) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com. [209.85.219.171]) by smtp.gmail.com with ESMTPSA id a6-20020a258706000000b00dcd2c2e7550sm5546689ybl.21.2024.04.29.07.37.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 07:37:32 -0700 (PDT) Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-de5acdb3838so3334495276.1 for ; Mon, 29 Apr 2024 07:37:32 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVTckxnLENU4uQEDQ3eSYe4OS0pPwfnikjiFTMdHWKgpGcQQenAslkb+y0zAKr3eS2Qo23sWOtyj8mJnKYzaUenTzdKCY3gKJS/eEQA X-Received: by 2002:a05:6902:2187:b0:dcf:a52d:6134 with SMTP id dl7-20020a056902218700b00dcfa52d6134mr13962181ybb.26.1714401451935; Mon, 29 Apr 2024 07:37:31 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <419fcc09d0e563b425c419053d02236b044d86b0.1710298421.git.fthain@linux-m68k.org> In-Reply-To: <419fcc09d0e563b425c419053d02236b044d86b0.1710298421.git.fthain@linux-m68k.org> From: Geert Uytterhoeven Date: Mon, 29 Apr 2024 16:37:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] macintosh/via-macii: Fix "BUG: sleeping function called from invalid context" To: Finn Thain Cc: Joshua Thompson , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2024 at 3:55=E2=80=AFAM Finn Thain = wrote: > The via-macii ADB driver calls request_irq() after disabling hard > interrupts. But disabling interrupts isn't necessary here because the > VIA shift register interrupt was masked during VIA1 initialization. > > Cc: Joshua Thompson > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Finn Thain Reviewed-by: Geert Uytterhoeven i.e. will queue in the m68k tree for v6.10. Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds