Received-SPF: pass (google.com: domain of linux-kernel+bounces-162493-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 29 Apr 2024 10:53:23 -0400
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-pci@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 01/11] PCI: imx6: Fix PCIe link down when i.MX8MM and
 i.MX8MP PCIe is EP mode
Message-ID: <Zi+0Y+BhPqIw7PeL@lizhi-Precision-Tower-5810>
References: <20240402-pci2_upstream-v3-0-803414bdb430@nxp.com>
 <20240402-pci2_upstream-v3-1-803414bdb430@nxp.com>
 <20240427090057.GF1981@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240427090057.GF1981@thinkpad>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aWUwVEQ1VjhCVVNpeWRidmIzdUEzUmp4ZlBrYnBWdkRXQVY5ZVZDWGIxZ1Ns?=
 =?utf-8?B?cnFZV1hxN3NzQVNDZUhzaG5qajQ2TXZ3Z0ZDcUlFUDNxSTU1MGNVTFBLc2xo?=
 =?utf-8?B?M2JTdU1hL0tpbkFvWTYrZmoyUmpaOUVGVjEzelJYVUNmRUlaeG9aTTFacHZV?=
 =?utf-8?B?QTBIREtQTit2YUtUNjZxQ0dnamV5Nmd3RVF2VEI4dHhhRFNPcjdNeG9lcS9z?=
 =?utf-8?B?b2lRUkpkVDlQRWxBUDg3R3lKL0lQYnFDVDhLa05CR2RjZ29kcUwzZ1dNU3Ri?=
 =?utf-8?B?SFFRSHNKSFFCQTdvZHhacitEVGo0N3BWemxadThpT0pDcWFYMGZVbUx3VTJH?=
 =?utf-8?B?TkRuMm1NS1VwM1dYL1BtWjg0V0ltWlVvT2tYOTVteW12WHFETkZkSHVPUkxx?=
 =?utf-8?B?akFFdDExVCtiVnRtTXhXU1ZuanE3WHI3NjBrbE5FWllSTHBMNWN1TkU5WWsz?=
 =?utf-8?B?NjM3MGo2RE1BdnhWbUVydVcwcnlYdFoyM0NRbDlaTUhIcVM0bXBsQWN1RFg1?=
 =?utf-8?B?WEd1aWpwdmVTZFA2QVZ4SThsV2syZ2dBb0IxMllsUDVONWFaZGtKMmpQbEp3?=
 =?utf-8?B?N0duVUp4ZTl4WElhaXdRd0RpN2h1ZnhlM2dMYmtHeTN4Ukp1U21QZnNITDZH?=
 =?utf-8?B?TXNLbXJnOGFyUTE4K3podkc2eWVYOWRncmsrZ0QzSzA1SGpnYXMwY1RueDdY?=
 =?utf-8?B?cllhQUFRRGFLNUgyR0pVR2RQbFNzSXlJNjdScVdZN3EyeVUvUDU5NFZLMGcy?=
 =?utf-8?B?WUh0aDl4bWl1M255UE1iQ0JzSi9kOHg5b2hacHNKdEgwMWZ5V3JoTjhCd01r?=
 =?utf-8?B?R2pJa1dYQmRvQ3JtdmNDRDZVOFVpOGk2NGtLdmFWRzJPbjEydStUbVlUQVRP?=
 =?utf-8?B?RVVvbHRuUFByTzFRdHVQMmJzNEJXYkFoOTZ3ak1pS3M0Vk96L3d2bGJjQVp3?=
 =?utf-8?B?T0JRMFVpYzJkRU5aNmNOMHpHYmtWTXVBWVZ2b1lOMGttVzdCekpwL3grcEU4?=
 =?utf-8?B?ZmQyK3ZodEpIeVJFRWhzOEZkUUk4eTArUTBVRGkrbXpFdlhjazZ0Z2RUZkZa?=
 =?utf-8?B?T2craWwrbjhBTjc1WUFuOVNSVmNLa0FpMHlicUl1elptdnA5N2wvcUY0elZx?=
 =?utf-8?B?NGdiTDRoZUZ2SGd6Q2xwSFQ0WE1IZVNEVG5OWG5GajVPbWM4bUtxVm1uQXBZ?=
 =?utf-8?B?MllMcHVIUnFtVTFMaGNrdkxlZjFLeHJvSXVBeHBWWGlQSjJoL3A1cVdVbFlM?=
 =?utf-8?B?MU5VdmQvOW9ZUDdUL2M3aFA0STJIcDVGUnF2N3YxU2dOTWZhWjRVdEZoRmdE?=
 =?utf-8?B?czRmbmlsMk1oMTJpcWx1d0dkRzl5YXdSTGlKQXpHWS9HWFc0ZlIvUDJuNEkw?=
 =?utf-8?B?ei9IZ1lLallhYTNnbHc2WXdjQ2VyUEpTTW1ZdXVWS3gxNjczbDNyRkxrR2x3?=
 =?utf-8?B?NW52K0dYQy9IYnpXNVRHTTBpMUdpeTNKYWdOMlppTWR2WlFwRDJESktuaXR5?=
 =?utf-8?B?WFQ3RFJ5T1RSak9ZWDdrZ3NiYkRSNk5oTjNBWnh1ejNZNXE3ZTFQZks2YnZR?=
 =?utf-8?B?NXBNeUlMZU1tUXIyU3ZuNWxwTDFpYjlOaU9YV2NscG5JdThtRS9DbXBPS3kx?=
 =?utf-8?B?SWdYWDBpN2p6SmF5NDBMdmJRUngvRVI3T0xzcEJDWm5neGd5K3RHS3hpK0V1?=
 =?utf-8?B?eEtBRHFOanMzbThGTWJoWVBiN1JBMmlxWHhkd1hFN0dsS1BvaXA0L1ZFTjlG?=
 =?utf-8?B?SC9pT3hudE96MitOVnVGYTdJUE50MFM5WE9GRjNDUG9IN1BBU2RickxVTXJM?=
 =?utf-8?B?UnBkeTNmMnd0RjNMSjA4cnlmOERiejlkbXdUeElSTzVYaERvcnE5bmh1cXBw?=
 =?utf-8?B?Vm1xRzc2aGs2YTBzeEh3dUVqUWRYdndyV20vcnRudTRFUHloVDZicFdXTld6?=
 =?utf-8?B?UUtoTW9DK1pmSnpVeU9lTkR2U1RYS084Umg1V29GVGlId09kZWtDcGsxV2xy?=
 =?utf-8?B?bXFTRWhGWW1EL2x6dHIzaVc0akRiZmtiNnphQ0k4WkdnUFRvV2diVGk1dWlT?=
 =?utf-8?B?b1Z0dHk4SEhra09yZkI3T1U3VUNYYW1EcUhBS1JOS1NqT3pYcjl6ZDB5dEJx?=
 =?utf-8?Q?vsRaHbfvFQ2titywgzAIx+L9F?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d94fe8eb-7e04-4f42-4d11-08dc685c24b3
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 14:53:34.4239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a6AmzYPD2r8cFd7e+7tPXYqH3rIAAsi8nucNZlbCQtU3Bus8Kw6Ua+dGyo+MkFKvlppLMviVQBhfkvU3DbqN7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7108

On Sat, Apr 27, 2024 at 02:30:57PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Apr 02, 2024 at 10:33:37AM -0400, Frank Li wrote:
> > From: Richard Zhu <hongxing.zhu@nxp.com>
> > 
> > Both IMX8MM_EP and IMX8MP_EP have the "IMX6_PCIE_FLAG_HAS_APP_RESET"
> > set indeed. Otherwise, the LTSSM_EN bit wouldn't be asserted anymore.
> > That's the root cause that PCIe link is down when i.MX8MM and i.MX8MP
> > PCIe are in the EP mode.
> > 
> 
> This commit message is difficult to understand. I think the issue you are fixing
> is that these 2 SoCs do not control the 'apps_reset', due to which the LTSSM
> state is not configured properly.
> 
> Referring Link Down is confusing at its best. Is the link training happens first
> of all?

Commit message is not good enough, how about change to below one

PCI: imx6: Fix iMX8MM and iMX8MP's EP mode failing to establish link

Add IMX6_PCIE_FLAG_HAS_APP_RESET flag to IMX8MM_EP and IMX8MP_EP drvdata.
This was missed during code restructuring. The app-reset from System Reset
Controller needs to be released before starting LTSSM.

Frank

> 
> - Mani
> 
> > Fixes: 0c9651c21f2a ("PCI: imx6: Simplify reset handling by using *_FLAG_HAS_*_RESET")
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  drivers/pci/controller/dwc/pci-imx6.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> > index 99a60270b26cd..e43eda6b33ca7 100644
> > --- a/drivers/pci/controller/dwc/pci-imx6.c
> > +++ b/drivers/pci/controller/dwc/pci-imx6.c
> > @@ -1568,7 +1568,8 @@ static const struct imx6_pcie_drvdata drvdata[] = {
> >  	},
> >  	[IMX8MM_EP] = {
> >  		.variant = IMX8MM_EP,
> > -		.flags = IMX6_PCIE_FLAG_HAS_PHYDRV,
> > +		.flags = IMX6_PCIE_FLAG_HAS_APP_RESET |
> > +			 IMX6_PCIE_FLAG_HAS_PHYDRV,
> >  		.mode = DW_PCIE_EP_TYPE,
> >  		.gpr = "fsl,imx8mm-iomuxc-gpr",
> >  		.clk_names = imx8mm_clks,
> > @@ -1579,7 +1580,8 @@ static const struct imx6_pcie_drvdata drvdata[] = {
> >  	},
> >  	[IMX8MP_EP] = {
> >  		.variant = IMX8MP_EP,
> > -		.flags = IMX6_PCIE_FLAG_HAS_PHYDRV,
> > +		.flags = IMX6_PCIE_FLAG_HAS_APP_RESET |
> > +			 IMX6_PCIE_FLAG_HAS_PHYDRV,
> >  		.mode = DW_PCIE_EP_TYPE,
> >  		.gpr = "fsl,imx8mp-iomuxc-gpr",
> >  		.clk_names = imx8mm_clks,
> > 
> > -- 
> > 2.34.1
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்