Received-SPF: pass (google.com: domain of linux-kernel+bounces-162587-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a65c696b-5947-45ee-a1a8-caa50c7ccf9f@intel.com>
Date: Mon, 29 Apr 2024 08:23:46 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V5 4/4] KVM: selftests: Add test for configure of x86 APIC
 bus frequency
To: "Chen, Zide" <zide.chen@intel.com>, <isaku.yamahata@intel.com>,
	<pbonzini@redhat.com>, <erdemaktas@google.com>, <vkuznets@redhat.com>,
	<seanjc@google.com>, <vannapurve@google.com>, <jmattson@google.com>,
	<mlevitsk@redhat.com>, <xiaoyao.li@intel.com>, <chao.gao@intel.com>,
	<rick.p.edgecombe@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <cover.1714081725.git.reinette.chatre@intel.com>
 <eac8c5e0431529282e7887aad0ba66506df28e9e.1714081726.git.reinette.chatre@intel.com>
 <f5a80896-e1aa-4f23-a739-5835f7430f78@intel.com>
 <12445519-efd9-42e9-a226-60cfa9d2a880@intel.com>
 <002340b7-86e2-4be3-8468-71d59233c32e@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <002340b7-86e2-4be3-8468-71d59233c32e@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3o2RE0rUDdJTXNRVDg2NGRONU42RElyNER0VEtIemdKbTVzZm9UOHlXbUQy?=
 =?utf-8?B?QlViUjdBZHhTazNlOEViZzR0MjhWRjRyTmJYTkdQTmJ2YTZrRlVLNy8wTncw?=
 =?utf-8?B?QW1nODRhK0dLQWR6TSs5MmRRVDZHbEI0MEtsM3dWZ2g0eTVKWVhoTVFCRi9j?=
 =?utf-8?B?MGtjaUpvdmtXaTRKNUt2cXpGa25OV1dNVDBXcGNpNDk5L1NlM0dBRW9LZlFM?=
 =?utf-8?B?SisxNzhRNjNPU2dQOGdXM080bHllOHlNR0o4ZXlvOVBYdSszM01PYTl5bzlq?=
 =?utf-8?B?RllsMWJYVUI5QWVXd3pldThiNE92cGhJVDRwajQrdEs1dG1mNSs3Q0FMYWg5?=
 =?utf-8?B?eU5HOG9VcTMwMmlDQUxOYkhFaFhhQXdDUnU2a0hpTkpzZ1BBSnB0T1J2bkpz?=
 =?utf-8?B?Z2dxdmdBenJPNmpqMy91Nm5BU2pxNXJTZk0rM2lyUWZ1elVzZThHbWRBRVU1?=
 =?utf-8?B?Rk01UVpwbDlGUkJSLzhaWE5qa052VkUwdzdqUzNrOFlBZWlNMUJIbGk5SG1j?=
 =?utf-8?B?aHBRU1JVa1BoSXFxck5uQ2xLVFVDV2FyWTZ3Ly9zREkrSU1iMzN6bWtLYUI2?=
 =?utf-8?B?eEY0N2MreE9rbmEwL2JxdlZGamt4VmFhbEVxTGhEYW5KWmI3bUpkelpxZTRn?=
 =?utf-8?B?Qk9ULzNTSHJqT2hXNWRVQzNlZWdVSy9xMS82RGNFQ1ZCUW1wdHBGRmxsTGt3?=
 =?utf-8?B?MHJuT3dPaS95WWN2UkZnbnVGaWFOZVZkQXBuSHhaNkw5WkxOa3NCMEZnVEMr?=
 =?utf-8?B?VjZ0NEltUzhDRVBvZDB2b21oT0JneGt6Y2psc2dzQ1hIdU01QWlrTnV3Ymxs?=
 =?utf-8?B?dVBaUnhwSzM4dHl5U0dvNnpreWorSE5ITGY1TlROdks0UU1DWFc2VktCZk1E?=
 =?utf-8?B?aTd0NHB2Rlp2YzMydCtMR0lOT205aXFDU1ROSHhUUThwdGRZQzFkbEpPeGhl?=
 =?utf-8?B?b29NY1NCQzNVY3BVK2llNlIwRmhIV3hsTFZ3WWIvcWxybHkrM21VNHNKdzNW?=
 =?utf-8?B?R2plR3N4KzN3dTVqL0NXeEdXR1FjZG9MM3NXQU1pTnlJTDdOcFcyT1VBNFRG?=
 =?utf-8?B?NHQvbUw0aUUvVTVGclVlWjBJRjNuV0F4VlZFekxCQU9nOFFMU0dUbEMwNUg5?=
 =?utf-8?B?aGlSMGZqMFczWk1Vc3dLeGVvWFNUeUR1K0NwbXg3NmFUN2RyVXNuTllQemFx?=
 =?utf-8?B?Z0hVMU5rWVJJeThrQ2k1R1dOSDNSSWZSamQrV0tGL3JVUzdTVFVaUHdPZDJV?=
 =?utf-8?B?R2hvaGhEL1p1a08xMWZ5N05NOE45ZmZuMy9UYVNLVmVrbWhZZ1JOdlFINmJ6?=
 =?utf-8?B?M3JEMXYrYmtJYjJ2MjRRb3V2cUxoRjhsOGo0dStvdEw3akdjY3ZzUnJ1Tmo5?=
 =?utf-8?B?bmh4VUNyK05lU0g5eGdjL2p1dGVRL2dFK3dxMzhSSEU1L1ppRDgrUVB4eVMw?=
 =?utf-8?B?dDJVcUxtK3hSNEhHMUVNczY0RUNIckozYlVjZUlsOWtmL3R3ZHpuYytCMTE4?=
 =?utf-8?B?NGE3dktrTXJ4c0FhZ0F3cnk5ajlZUEJ1Y2RHaVRLdEZsVk5mUzl4a2FINmlh?=
 =?utf-8?B?WkQ1a1ZOOGx5dnp0a1Eva2N4SjB0Z3h1cjI1OExrMWY1eUV6bU1jNWdtY1oz?=
 =?utf-8?B?WjhXUWpIN0xmazJwK0lXNjU0L2ZZbmwxanpHejI5L1FpdC94T3FiYVc4eFZW?=
 =?utf-8?B?ZVRvVFhKNXNMSG84dHdFUmxZK0VCVlVEQWJ6N1JtaW14ZGNRMjRqL0krbjZB?=
 =?utf-8?B?SnFrcGlYQ2lwam9kVStKOE5talBtb3YzQk1rdjh0YnpUMGl2YlJMRjFvQjZS?=
 =?utf-8?B?d1EwRldBT2xDemtyTGxrRjJ4Z3pQQUFnS09jV00xQW8vcm5wTjNkTGxIMGFF?=
 =?utf-8?B?dE9VVXJxRnIxVlhaZjVRYVp6eVNDQnV3dGp2R2NZSjNHTEovMnlBcldTUytY?=
 =?utf-8?B?ZlBaa2tLcGlPeFhaTURBYVd5N1RNV0pxYk0zaDNPMTlsSFlwR0RRSFlnblN5?=
 =?utf-8?B?aFBLSHFVZEpKdGNqdjFmY0szZGZVazZQS3Iwb3NzVm9nUSs4d0t1Y09WMUdK?=
 =?utf-8?B?eFN5TUFyWUl2M0N2djFGaE1qWUk2Tk5SRnREUjc2YWxYTFJMR3FjQlo0NzVj?=
 =?utf-8?B?OThNR1U1R3JQS2NTenBVbm13bzE0emJiWWQ0S1kzK05GV1Q4OVFuVXZKYUFr?=
 =?utf-8?B?bFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49b5ef4e-e2c8-4f6c-5426-08dc6860625a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 15:23:55.9031
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EiFIVDA+HW+M4fXR443aUev/8DSq9sotcin84eozkeS2tt3ZeE8B891j9efOGiKm0lAczorPAp5kqyEOX/XrHfs7N9ryW2PbkEUKhJKe9qQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6888
X-OriginatorOrg: intel.com

Hi Zide,

On 4/26/2024 10:38 PM, Chen, Zide wrote:
> On 4/26/2024 4:26 PM, Reinette Chatre wrote:
>> On 4/26/2024 4:06 PM, Chen, Zide wrote:
>>> On 4/25/2024 3:07 PM, Reinette Chatre wrote:
>>>> diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>>> new file mode 100644
>>>> index 000000000000..5100b28228af
>>>> --- /dev/null
>>>> +++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>>> @@ -0,0 +1,166 @@
>>>> +// SPDX-License-Identifier: GPL-2.0-only
>>>> +/*
>>>> + * Test configure of APIC bus frequency.
>>>> + *
>>>> + * Copyright (c) 2024 Intel Corporation
>>>> + *
>>>> + * To verify if the APIC bus frequency can be configured this test starts
>>>
>>> Nit: some typos here?
>>
>> Apologies but this is not obvious to me. Could you please help
>> by pointing out all those typos to me?
> 
> Do you think it's more readable to add a ","?
> 
> - * To verify if the APIC bus frequency can be configured this test starts
> + * To verify if the APIC bus frequency can be configured, this test starts
>   * by setting the TSC frequency in KVM, and then:

Sure. I'll do so in the next version.

Thank you.

Reinette