Received-SPF: pass (google.com: domain of linux-kernel+bounces-162640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 29 Apr 2024 12:01:10 -0400
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-pci@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 04/11] PCI: imx6: Rename pci-imx6.c to pcie-imx.c
Message-ID: <Zi/ERqbE3jnUxhkV@lizhi-Precision-Tower-5810>
References: <20240402-pci2_upstream-v3-0-803414bdb430@nxp.com>
 <20240402-pci2_upstream-v3-4-803414bdb430@nxp.com>
 <20240427093133.GI1981@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240427093133.GI1981@thinkpad>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bUJYN2V2VnhDZTlDcytEU1drKzlKRmNuV09neU53ckpoMmh4d2hmb05jRGxR?=
 =?utf-8?B?QWQxSXJsOVZiMEtPRUFJYXVDbDhGVW5EaUNpM1VVT01yWTE2ZHM2ZHZsWVZ0?=
 =?utf-8?B?SmVDb294WEFMNndadHlnVkt1STk3K1lBeTRMU0tIRGJLU3RaTkkvcmJ5VWRm?=
 =?utf-8?B?bEVuY1l6V1VYOUc5RnhxYUVxU08vZUIrL2s2WE01c0g3RWxlOWlpSVFLMVhw?=
 =?utf-8?B?NWxlY295NEFmU2c4OCthWHkxWDVSamJSVml4aFF2UHpYaXI3T1ZGR2oxcTZ4?=
 =?utf-8?B?cmJwaGN1b2l3Z29TUnhkR3lmOENYTnVDQXN1MXJpMU1oK002MlFvTVE0NWw4?=
 =?utf-8?B?WGRRbktrdm1hejMvWXpKRmMxUDhHeWxxcjBIR0dlZDlDYnVNVDBnemMrRFdX?=
 =?utf-8?B?ejRkOWNJRkVhdDlYb2JMdnB1ZXU1RXQ4QWxORUZ5bFg2VGEyWURhNytHK09R?=
 =?utf-8?B?T3Q3QW5tdm51MUxnOTJpdHZTWjJaN2paU2RGRlBxU0FyZzNNYjVVWjIwZUla?=
 =?utf-8?B?MmViSnR1Tzcxb3BYT2kxMTdqSHhKVUZzVE1NWTUvQVhKOXpHM0tPbkFsazkw?=
 =?utf-8?B?M3E0ZWkvSm56ZEh3VlhDUUV3b2V5QUpOWndCNVJWM0IrVzEwbHpCOUpVNGx2?=
 =?utf-8?B?V3pNSUNHaUFRdlhLRFNBZ2IxbmpyU2pZWmc5NFhvL0FsTXVmQzZ4cXNVWnZS?=
 =?utf-8?B?N096aEE3WlhnY1psbzROUXBtcS9xL1JHZHhkZjNQUXY0SWp1UUVqYzRHS0lT?=
 =?utf-8?B?ekg2UG9QRXY2VXk3elNVNGFnenpHcUpBaFIyc0V4VGhzQm1Taml6MkRxVHNV?=
 =?utf-8?B?RDZpaDNrcklsN2xBVUs3TFA2U3YvTE13M2xBMm1mOGJ3NzdzTWMvUDZxWlNE?=
 =?utf-8?B?R3UvdVBjbEUrVjlqM0lNSDBDcFExejFiY0FHMjh6eTVYMmdtanQweXIxT3hB?=
 =?utf-8?B?QzVWbGoyZ2NvQ2tzUTdQV2xXajd0YmMyQmwzdmdiL3hOVXY5UE1pMmIrbGla?=
 =?utf-8?B?TGxWMjBKQ2VFMkQzQUIzMUNrZFJRSktPNTVhd0IyY2FKNUozampad3hneFpE?=
 =?utf-8?B?eDRrZkp0Und5WWE2WFhRbDVuZ3Q5VzVMdEV3emc4N3BVWWlRenlTVS9mRzBU?=
 =?utf-8?B?cWNZN3RxMXZYSUZtWWt2aVp2U3UvWUhsT3Z0b2ZYV0RhR2NuanExaklOVUo1?=
 =?utf-8?B?bUZxSnhnRFRVeFJWVkQxTDZnR1JuNGlPcm1WVTlHd2JqNWUrL3JxWDBnSGJq?=
 =?utf-8?B?Q0s2OXljUmxYemVsS3B6SDI2dkRlY1N0eTlTa2RpUnFEV2Q5dVpaeUQrcVBX?=
 =?utf-8?B?YS91d0g5WDV4QUNQWlNjcmhvcE56MlVDM2xzNjNvVW9LYjM4MEtUVmNUcXZC?=
 =?utf-8?B?VHFjTG9qMEZIM1cvWkZZNVExNEpvOE1JL2F4MDZXemdIOHI2TnZxYkFjUjZm?=
 =?utf-8?B?S2tLbnlNbDhKYTVaMXV4YURlSHBsRXFZTGl5c2FUcmo2aytack1WaG5WZTFJ?=
 =?utf-8?B?bmcrQ1RtR0RGYnRXaThEUFpHQWloM0F1UEFCc3RPOG45d2VYc1dYdjM0OHYr?=
 =?utf-8?B?R21MVUZzay96ejZsUGJoSWo0S0RFaEhEY0NrL2Y0TTVEWXNhM21pcDJwalgz?=
 =?utf-8?B?UzBWbzQzY2M1UVExWkFaMGVoZ3VpR0gxeTJKd0l1VUFxMWhLT1VjT0hQeFd5?=
 =?utf-8?B?bTQzdVYyMzlXY1lZeDRJOVYzOURRUVNDbUZzRTVBL0paUDVkSGFsSjhKRHY4?=
 =?utf-8?B?UUN5dnBJbFZML3JkYWFPUEN2bnhraVJhaksvRUJJU2svZjRzTDFNaWR0djZk?=
 =?utf-8?B?eTA1QTV5SHRuVE1ieEdnVWhUcjBBYVlqRFI1RlpTTWpEQmlkejk5eXVSc0w4?=
 =?utf-8?B?bWpDMDFnZ05LTmlNekNtY2NGbFBBaTV4cERNKzhSd21BQ0NuYkFDL3JvMzZw?=
 =?utf-8?B?ckRseURsTGR4TitqeEVBOURZUm9WbklRVVdDdlhyWFliNjZVRTJtNVoxLzdl?=
 =?utf-8?B?TnA2ajY5S1JOaENqZjhxOTZaeDY3YlpPK1pvQkU1SDdjamFQc0MwYTJJVGF1?=
 =?utf-8?B?TWl2bEZ1QkMycEM2QndyOFozYytFUTZMZWRwWllaOU40c1E4eFcvcGZ4TmFx?=
 =?utf-8?Q?GuEw=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3d1a342-9eac-4f6c-4fe6-08dc68659d08
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 16:01:21.6408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wPN5ABm0FlUqTwHQPWpKuOxm5ZnAHv8YAAONY39+L+BzeACdYgLLBwnCqYT87F1SAoFe3YR8u3rPoarwPcqsvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6845

On Sat, Apr 27, 2024 at 03:01:33PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Apr 02, 2024 at 10:33:40AM -0400, Frank Li wrote:
> > Update the filename from 'pci-imx6.c' to 'pcie-imx.c' to accurately reflect
> > its applicability to all i.MX chips (i.MX6x, i.MX7x, i.MX8x, i.MX9x).
> > Eliminate the '6' to prevent confusion. Additionally, correct the prefix
> > from 'pci-' to 'pcie-'.
> > 
> > Retain the previous configuration CONFIG_PCI_IMX6 unchanged to maintain
> > compatibility.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> You should not rename a driver as that will break existing userspace scripts
> looking for module with old name.

Generally, pcie-driver will be not built as module. Anyway, it will not
big benefit by rename after second think. Let's keep the old name.

Frank

> 
> - Mani
> 
> > ---
> >  drivers/pci/controller/dwc/Makefile                   | 2 +-
> >  drivers/pci/controller/dwc/{pci-imx6.c => pcie-imx.c} | 0
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/Makefile b/drivers/pci/controller/dwc/Makefile
> > index bac103faa5237..eaea7abbabc2c 100644
> > --- a/drivers/pci/controller/dwc/Makefile
> > +++ b/drivers/pci/controller/dwc/Makefile
> > @@ -7,7 +7,7 @@ obj-$(CONFIG_PCIE_BT1) += pcie-bt1.o
> >  obj-$(CONFIG_PCI_DRA7XX) += pci-dra7xx.o
> >  obj-$(CONFIG_PCI_EXYNOS) += pci-exynos.o
> >  obj-$(CONFIG_PCIE_FU740) += pcie-fu740.o
> > -obj-$(CONFIG_PCI_IMX6) += pci-imx6.o
> > +obj-$(CONFIG_PCI_IMX6) += pcie-imx.o
> >  obj-$(CONFIG_PCIE_SPEAR13XX) += pcie-spear13xx.o
> >  obj-$(CONFIG_PCI_KEYSTONE) += pci-keystone.o
> >  obj-$(CONFIG_PCI_LAYERSCAPE) += pci-layerscape.o
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pcie-imx.c
> > similarity index 100%
> > rename from drivers/pci/controller/dwc/pci-imx6.c
> > rename to drivers/pci/controller/dwc/pcie-imx.c
> > 
> > -- 
> > 2.34.1
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்