Received-SPF: pass (google.com: domain of linux-kernel+bounces-162638-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 29 Apr 2024 10:59:51 -0500
From: Rob Herring <robh@kernel.org>
To: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
Cc: saravanak@google.com, linux-kernel@vger.kernel.org, kernel@quicinc.com,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] of: reserved_mem: Remove the use of phandle from the
 reserved_mem APIs
Message-ID: <171440638161.1895148.11194020129017609758.robh@kernel.org>
References: <20240422235243.2878536-1-quic_obabatun@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240422235243.2878536-1-quic_obabatun@quicinc.com>


On Mon, 22 Apr 2024 16:52:43 -0700, Oreoluwa Babatunde wrote:
> The __find_rmem() function is the only place that references the phandle
> field of the reserved_mem struct. __find_rmem() is used to match a
> device_node object to its corresponding entry in the reserved_mem array
> using its phandle value. But, there is already a function called
> of_reserved_mem_lookup() which carries out the same action using the
> name of the node.
> 
> Using the of_reserved_mem_lookup() function is more reliable because
> every node is gauranteed to have a name, but not all nodes will have a
> phandle.
> 
> Nodes are only assigned a phandle if they are explicitly defined in the
> DT using "phandle = <phandle_number>", or if they are referenced by
> another node in the DT. Hence, If the phandle field is empty, then
> __find_rmem() will return a false negative.
> 
> Hence, delete the __find_rmem() function and switch to using the
> of_reserved_mem_lookup() function to find the corresponding entry of a
> device_node in the reserved_mem array. Since the phandle field of the
> reserved_mem struct is now unused, delete that as well.
> 
> Signed-off-by: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
> ---
>  drivers/of/of_reserved_mem.c    | 26 +++-----------------------
>  include/linux/of_reserved_mem.h |  1 -
>  2 files changed, 3 insertions(+), 24 deletions(-)
> 

Applied, thanks!