Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1460040lqa; Mon, 29 Apr 2024 09:03:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWz64cxXPY0BSE+yC1Yh/uzfWeljn79SCiyJEOHYKGXPa9/Qos+p+Aug0fYwvOdI3oMBBgbUQH3jVFhGLEu46OkRVlQ4nQ8Rvm6KZVevA== X-Google-Smtp-Source: AGHT+IFDBhqGEj665+Zd48AxIY3g0V2JE8Rt3XSbStv6DWfb8n+00KH7gmcuhv5YcTsC4xzsGtND X-Received: by 2002:a05:6a00:4f8f:b0:6ea:86f2:24fb with SMTP id ld15-20020a056a004f8f00b006ea86f224fbmr15681729pfb.25.1714406589324; Mon, 29 Apr 2024 09:03:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714406589; cv=pass; d=google.com; s=arc-20160816; b=oDNnZHswpFhdegf0wrolMXUVGxG3RzHIU+I4eI3aKPUylEzOTR5t2sicFGeBGxsDOV uC9b1R55lGgj6z8lo8X41tKZ8W/Zi3KL6FSRM2nHrNUTFqSPfdRU5LNmTHiU79Yv2wjH 2cLU87satmrOPtAtCkLPLzS6/pfl9NRzpHrduanDhk3pjqk6FS64m5mL50kBvE8wvlwc JBWRXzcC+nK/91IbZ6Y9aVFx9b+J9bIz3UsfUz5fes+vHoFr9XfYB8C14HjuVAHOI8Dj SxDrK7UTf5doSYLuK4DaSux/MoNnF5A2ItcAglNIDGdDVH5MWROeuWtFlVl5+Eqb9tAj Hyhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1vP8H1PgFkZFQ6nz4DIR0J5Ohhr/3GoY+TJ/92tyUzY=; fh=I/PjfWMluTc11IlwKZbdtaZ6C/a247Gg9EU76+eWlpc=; b=go1Sze86d3cZoKWSz4DffvSuZ01r25D8uW7gjGBYV0GwzGUdMFFK/ENTeAEHWwuukG IJ28Req6mSL6Py3fcLvmtrIs10IOoUeTwLBRwQNUNOtYkoZ6QUOda5363XBwGHE5B6og M77AqT5rjrDNEgMGSGU5C7GWGVVo2mOW//Phs3G+MaYnbQ6mZKpYLyNTBts4yIRS7iAm u5FjiPuyV/3W9fSLla50n0ek+UJ0KdM0+rht4zdXv6VM7gPEQB/2FiU93gyLgQk5xMl3 jd7t2EQnGBuu+fw86Ok06+Xat0CrmqlcPMWFucVMgN+u5vncAgaGIj3+9VzibS7/xnuT SeeA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Z//pnv/M"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-162641-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162641-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l32-20020a635b60000000b005e46e6ba6cdsi19401092pgm.391.2024.04.29.09.03.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 09:03:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-162641-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Z//pnv/M"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-162641-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162641-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CCCFD2817D5 for ; Mon, 29 Apr 2024 16:01:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C7B6483CA0; Mon, 29 Apr 2024 16:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z//pnv/M" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02B5F8288A for ; Mon, 29 Apr 2024 16:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714406497; cv=none; b=d3ISCWtkHXH259xfKG3jfRk4biwPHR3mVw8okM2TSrCYAJGfgp/cbS9//DZUiUgpYNk/ZUq5jmYb/Z4Ms7tqtdpYUPQ2mgrRCO6bfji4NpwWLZI5vOhkAnWimWJxgVECuS55R8lXz6/xa4LewFLYTwUQjIpEUAx34cZBt211qYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714406497; c=relaxed/simple; bh=1vP8H1PgFkZFQ6nz4DIR0J5Ohhr/3GoY+TJ/92tyUzY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PvXXskH9r57OpVaN4/yyAtWXvM2/PqlLPKkx/nY1Sn3thHrMi2pPfYjxfWazeyeWOcqAPiIkk/rwv1naE1rEmn5RC3SkQasKe1WnyewjR5yfLJiMaqBVFBNA79bbHlrnjMNvF1uFFs6exsXvm7GRyuhf8+VnV+hfGNP63s9VtNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z//pnv/M; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30AA5C116B1; Mon, 29 Apr 2024 16:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714406496; bh=1vP8H1PgFkZFQ6nz4DIR0J5Ohhr/3GoY+TJ/92tyUzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z//pnv/MoTcjmaEtTbjxlmMqv9hNkx8rB2qaHRrAaAIfktyoHng9iWgmuJ76swoAy oLIz6SmufCP+NCRbZ5Yeuhs6BVN6SH5nAsH2v0mIjZmbTq4hqLCz16eP1o/VmGO/jl rRF2F016fcPSv6EU+xBRzM4lOO4oFzEOaCot7hXa1Nv5xPY/eE26Y7Le58f/btffcV ucdEQlAoc3ORH2g+nLYvZxTWalWW88IMgh86d/hu16El3XL7yQiqaV2opMFQ6M3xSF hmvLMD3DAgp3t941p67bUNApwmL0FFCBsg3sANeInRrHe/0AeQIKZDM2RNkOcyh9jv WdmRXjZO9UbsQ== Date: Tue, 30 Apr 2024 01:01:28 +0900 From: Mark Brown To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/12] regulator/core: regulator_bulk_get: remove redundant NULL stores Message-ID: References: <1ec1a8090c0e316ee005629c24f2779211e0aebf.1714399603.git.mirq-linux@rere.qmqm.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yP8oxXeM2ea1Is3J" Content-Disposition: inline In-Reply-To: <1ec1a8090c0e316ee005629c24f2779211e0aebf.1714399603.git.mirq-linux@rere.qmqm.pl> X-Cookie: lisp, v.: --yP8oxXeM2ea1Is3J Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 29, 2024 at 04:45:28PM +0200, Micha=C5=82 Miros=C5=82aw wrote: > On error, callers of regulator_bulk_get() pass the error up and don't > use the pointers in consumers[]. The function is documented to release > all regulators if any request fails. This doesn't seem good from a robustness point of view and should be nowhere near a fast path. --yP8oxXeM2ea1Is3J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYvxFgACgkQJNaLcl1U h9BOfwf9H88K7EcrVQqYM9JQsVepjbUIdocBBvSr/H08ORpBFdc6IT1hm02vBE6T 25E0Ch9eqLp1iWk3KPe/EiiJ/G8HUxw0ju06Xae8sx0iw0KK9+UYuhW1qr5xhErm pu606qgn9euEEQ8U/UBYUacdpJrB9Ihdr5e9Nql3uKsxnOdUNLK6HBOsTH7uNr1F OEx0DpwUquidOl5qlMPb49rc8qguw3KZh5a3CbLkso3rd45thU/qeO/nyo9jLKIE PXm6u5h7serILS7HJWmUpVJkh4qM+UIG02X3chZYL9zY65o6VZmu5qAUcVX7Zv0n xsp4FIUqLX0k1IUV3BONkLj+5d3RBg== =q08o -----END PGP SIGNATURE----- --yP8oxXeM2ea1Is3J--