Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1471473lqa; Mon, 29 Apr 2024 09:19:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWKmFgV3zXu8EccfDrwSNNUKXTdAjG70VJgvOGRwxEqoYoobGgrSrRKT/i2cSRhAmx+P1wuknoAQRxZoNE4U4huML90FzVpWIMDMsIGLQ== X-Google-Smtp-Source: AGHT+IEBnfH8TJHKKw7lij+NjxMRkhBPyJdelUFDq0R+hEivgYInfDzlCVikv3Fh0owClcwwcrJM X-Received: by 2002:a05:6512:3109:b0:518:a66e:aad2 with SMTP id n9-20020a056512310900b00518a66eaad2mr74567lfb.63.1714407552514; Mon, 29 Apr 2024 09:19:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714407552; cv=pass; d=google.com; s=arc-20160816; b=K5ceAo/m3UoMSJYnClJePtlvfmuKkz7itAUIDmTeNIh3HRbGJkYX2/N9Rwvw/FM/qv +TbpB47cRxYQtGO+dyRSx1iEEwavyf7RMBMK+/XRQKe9yWPCihqO1GugwDcNnFV5VhV6 fskyi0twtxMHvib+1jtHtDAm6LyK7ugZ2/5Q/78xkrktkf/DydxghcaDL2LGteP6bU5j mYi5orUlIoaLMa5SBHm0KhfZwkCUJ/cvJ0MQXJfYofAYGva38s0HHbNXUSXflC9aLd9O 1LCG6uA+pMLRrIkRxmPPvsARZ5M6xw9NE16a6Shst5CMhYkVNShNpzTtt6YAnXsS5XIv TTww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=Af9swwyjE9aq+gFvEtFlpYxD5VA7L7/5Bjt51dmOc2o=; fh=IsuQBNQYhkGChzqSB/vteDtpE7K1Tm5QTidFr5WcaN4=; b=iNyCticSQ0qYNi4j4I8m0No+Qu+NnMas1rwNHYNFpSCTNZnz/b39dUfbsLMuxhIHye ml/xu9EHlNhxFpRgNlTImSPgA2e9rMQGXEtvE5Fdd2B+JRXIzrnm3pjZnSZD5uxvYy/q so19pLWc2JxAcInplLEYBCZRTytFudrDokuAJY8TTVpPXdE6bjhwGZOcabwzkjr/QMZr p2GNk4bn5ml8gJNhF0767uyQ1+zhPKuExaidRbyJjyehZzCVukz5eSHwBAYsJ6R4P+Qg FZLCllkX3eA/EI45srT2IwahNTQKkiQBllDVLSRuekBLJPpBRZM7KP72bYwKSCMPKeq0 kkkA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=wdFn3l11; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-162654-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162654-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gt44-20020a1709072dac00b00a51ce4057c2si1056287ejc.995.2024.04.29.09.19.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 09:19:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-162654-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=wdFn3l11; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-162654-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162654-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1F6241F253DC for ; Mon, 29 Apr 2024 16:07:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 191CF83CB4; Mon, 29 Apr 2024 16:07:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wdFn3l11" Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D031874400 for ; Mon, 29 Apr 2024 16:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714406856; cv=none; b=ZKd38tB07MwlX677qY0V0wTKlx0RZqEW0tJuE1SXeNP9L/4U+nhU9gbsmu1vEvVm15++ltOPK8BlyF5wHzlw9Wcqx+8rJHd43bk3aJGqZyD91pKt1kzhmxFxxe4y2AO+fflDE5X07lFW0N3dFr9AstjboGP3yXmIh179sMZPCto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714406856; c=relaxed/simple; bh=Yv7MpG6Lph1Nkm5Wxn81Qp2iEq25Jsr8Xz6iEsJIkuU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NDE85kbewQUdmtSN7XLPbnsKQF9t4azF0026BMXMkG1fdO3EhQiH6yat5D0kH4KkyqDa3z8uuuB2SY9T/PfrEckg+0DOvrHS7vi5u+Jv5iUcC3RDdx31eZo7DS2OfP0v6FLhhDBJikvIeLYGm/8wWV/51gqr2PM1zJWkeHgySeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wdFn3l11; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Mon, 29 Apr 2024 09:07:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714406853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Af9swwyjE9aq+gFvEtFlpYxD5VA7L7/5Bjt51dmOc2o=; b=wdFn3l11noD7XAoZXISsQIPIsCwIB2M7qo6z6QbjiXguS62xBh6HdWbm1VfskBBqCTmIhU 1dCrIuubR2sk51yxM0Li7Xr5qQViHM4k6T6B2li22vaFv/ROpR7Cjk75phHvpt/mbGXxsK ymlfX2+PyYzolqAdigTR9muYX81fyN4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/7] mm: cleanup WORKINGSET_NODES in workingset Message-ID: References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-8-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240427003733.3898961-8-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT On Fri, Apr 26, 2024 at 05:37:33PM -0700, Shakeel Butt wrote: > WORKINGSET_NODES is not exposed in the memcg stats and thus there is no > need to use the memcg specific stat update functions for it. In future > if we decide to expose WORKINGSET_NODES in the memcg stats, we can > revert this patch. > > Signed-off-by: Shakeel Butt Reviewed-by: Roman Gushchin Thanks for the series, Shakeel!