Received-SPF: pass (google.com: domain of linux-kernel+bounces-162728-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 29 Apr 2024 18:11:45 +0100
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>
Cc: Jiri Olsa <olsajiri@gmail.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-kernel@vger.kernel.org,
	=?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@rivosinc.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>, bpf@vger.kernel.org,
	Anders Roxell <anders.roxell@linaro.org>, llvm@lists.linux.dev
Subject: Re: [PATCH v2] tools/build: Add clang cross-compilation flags to
 feature detection
Message-ID: <20240429171145.GA241057@myrica>
References: <20231102103252.247147-1-bjorn@kernel.org>
 <ZUOWcXDpCOzxbFW0@krava>
 <87o79wxvnu.fsf@all.your.base.are.belong.to.us>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87o79wxvnu.fsf@all.your.base.are.belong.to.us>

On Fri, Apr 26, 2024 at 12:31:17PM +0200, Björn Töpel wrote:
> Jiri Olsa <olsajiri@gmail.com> writes:
> 
> > On Thu, Nov 02, 2023 at 11:32:52AM +0100, Björn Töpel wrote:
> >> From: Björn Töpel <bjorn@rivosinc.com>
> >> 
> >> When a tool cross-build has LLVM=1 set, the clang cross-compilation
> >> flags are not passed to the feature detection build system. This
> >> results in the host's features are detected instead of the targets.
> >> 
> >> E.g, triggering a cross-build of bpftool:
> >> 
> >>   cd tools/bpf/bpftool
> >>   make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- LLVM=1
> >> 
> >> would report the host's, and not the target's features.
> >> 
> >> Correct the issue by passing the CLANG_CROSS_FLAGS variable to the
> >> feature detection makefile.
> >> 
> >> Fixes: cebdb7374577 ("tools: Help cross-building with clang")
> >> Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
> >
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> 
> Waking up the dead!
> 
> Arnaldo, Jean-Philippe: I'm still stung by what this patch fixes. LMK
> what you need from me/this patch to pick it up.

I guess the problem is these files don't have a specific tree. Since you
mention BPF maybe it should go through the BPF tree, in which case you
could resend to the tools/bpf maintainers (and "PATCH bpf" subject prefix)

FWIW the change looks good to me:

Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>