Received-SPF: pass (google.com: domain of linux-kernel+bounces-162733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes
To: "Dave Hansen" <dave.hansen@intel.com>, "Huang, Kai" <kai.huang@intel.com>,
 "hpa@zytor.com" <hpa@zytor.com>, "tim.c.chen@linux.intel.com"
 <tim.c.chen@linux.intel.com>, "linux-sgx@vger.kernel.org"
 <linux-sgx@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "mkoutny@suse.com" <mkoutny@suse.com>, "tglx@linutronix.de"
 <tglx@linutronix.de>, "Mehta, Sohil" <sohil.mehta@intel.com>, "tj@kernel.org"
 <tj@kernel.org>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
 <bp@alien8.de>, "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: "mikko.ylinen@linux.intel.com" <mikko.ylinen@linux.intel.com>,
 "seanjc@google.com" <seanjc@google.com>, "anakrish@microsoft.com"
 <anakrish@microsoft.com>, "Zhang, Bo" <zhanb@microsoft.com>,
 "kristen@linux.intel.com" <kristen@linux.intel.com>, "yangjie@microsoft.com"
 <yangjie@microsoft.com>, "Li, Zhiquan1" <zhiquan1.li@intel.com>,
 "chrisyan@microsoft.com" <chrisyan@microsoft.com>
Subject: Re: [PATCH v12 14/14] selftests/sgx: Add scripts for EPC cgroup
 testing
References: <20240416032011.58578-1-haitao.huang@linux.intel.com>
 <20240416032011.58578-15-haitao.huang@linux.intel.com>
 <op.2ma195shwjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <6b056faa6de2ba3a15c2e5dd576e96e3f85375ba.camel@intel.com>
 <D0LLZTSVG3BC.8WIRM39WC7UU@kernel.org>
 <f62c29ec-f893-4320-8097-f6b3a372267a@intel.com>
 <D0W3G5GVNMMW.3OCGUH8AYNORY@kernel.org>
 <op.2mzzkowowjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <D0WR9J2AICDK.GM1G85DEHDDF@kernel.org>
Date: Mon, 29 Apr 2024 12:14:31 -0500
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Haitao Huang" <haitao.huang@linux.intel.com>
Organization: Intel
Message-ID: <op.2mz16ha3wjvjmi@hhuan26-mobl.amr.corp.intel.com>
In-Reply-To: <D0WR9J2AICDK.GM1G85DEHDDF@kernel.org>
User-Agent: Opera Mail/1.0 (Win32)

On Mon, 29 Apr 2024 11:43:05 -0500, Jarkko Sakkinen <jarkko@kernel.org>  
wrote:

> On Mon Apr 29, 2024 at 7:18 PM EEST, Haitao Huang wrote:
>> Hi Jarkko
>>
>> On Sun, 28 Apr 2024 17:03:17 -0500, Jarkko Sakkinen <jarkko@kernel.org>
>> wrote:
>>
>> > On Fri Apr 26, 2024 at 5:28 PM EEST, Dave Hansen wrote:
>> >> On 4/16/24 07:15, Jarkko Sakkinen wrote:
>> >> > On Tue Apr 16, 2024 at 8:42 AM EEST, Huang, Kai wrote:
>> >> > Yes, exactly. I'd take one week break and cycle the kselftest part
>> >> > internally a bit as I said my previous response. I'm sure that  
>> there
>> >> > is experise inside Intel how to implement it properly. I.e. take  
>> some
>> >> > time to find the right person, and wait as long as that person has  
>> a
>> >> > bit of bandwidth to go through the test and suggest modifications.
>> >>
>> >> Folks, I worry that this series is getting bogged down in the  
>> selftests.
>> >>  Yes, selftests are important.  But getting _some_ tests in the  
>> kernel
>> >> is substantially more important than getting perfect tests.
>> >>
>> >> I don't think Haitao needs to "cycle" this back inside Intel.
>> >
>> > The problem with the tests was that they are hard to run anything else
>> > than Ubuntu (and perhaps Debian). It is hopefully now taken care of.
>> > Selftests do not have to be perfect but at minimum they need to be
>> > runnable.
>> >
>> > I need ret-test the latest series because it is possible that I did  
>> not
>> > have right flags (I was travelling few days thus have not done it  
>> yet).
>> >
>> > BR, Jarkko
>> >
>>
>> Let me know if you want me to send v13 before testing or you can just  
>> use
>> the sgx_cg_upstream_v12_plus branch in my repo.
>>
>> Also thanks for the "Reviewed-by" tags for other patches. But I've not  
>> got
>> "Reviewed-by" from you for patches #8-12 (not sure I missed). Could you  
>> go
>> through those alsoe when you get chance?
>
> So, I compiled v12 branch. Was the only difference in selftests?
>
> I can just copy them to the device.
>
> BR, Jarkko
>
The only other functional change is using BUG_ON() when workqueue  
allocation fails in sgx_cgroup_init(). It should not affect testing  
results.

Thanks
Haitao