Received-SPF: pass (google.com: domain of linux-kernel+bounces-162744-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Kees Cook <keescook@chromium.org>
To: linux-kernel@vger.kernel.org,
	Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <keescook@chromium.org>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] init: replace deprecated strncpy with strscpy_pad
Date: Mon, 29 Apr 2024 10:22:28 -0700
Message-Id: <171441134708.2359415.3239349305778672892.b4-ty@chromium.org>
In-Reply-To: <20240402-strncpy-init-do_mounts-c-v1-1-e16d7bc20974@google.com>
References: <20240402-strncpy-init-do_mounts-c-v1-1-e16d7bc20974@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Tue, 02 Apr 2024 20:39:49 +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> data_page wants to be NUL-terminated and NUL-padded, use strscpy_pad to
> provide both of these. data_page no longer awkwardly relies on
> init_mount to perform its NUL-termination, although that sanity check is
> left unchanged.
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] init: replace deprecated strncpy with strscpy_pad
      https://git.kernel.org/kees/c/fa6475acde9a

Take care,

-- 
Kees Cook