Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1516532lqa; Mon, 29 Apr 2024 10:34:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXZDwiKa3rUSPoUEzdR87ERdwVJ/Pa0txRh//8MoNcIqTZOk7zXMnPAtaNiRM261FdBxrKddpp8qYEAOd5qXjlvpCZyGIUgdgML03YKrw== X-Google-Smtp-Source: AGHT+IHZQM1vrllR6zStufBLx21j7bbZ1Odi9GXo/PQlhWO+0vXvXbnOXuD7FmRI1CGt2Max50Ra X-Received: by 2002:a17:903:2282:b0:1eb:2f02:cd0d with SMTP id b2-20020a170903228200b001eb2f02cd0dmr12910202plh.0.1714412085011; Mon, 29 Apr 2024 10:34:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714412084; cv=pass; d=google.com; s=arc-20160816; b=Mytb9ijs/o7TQsopbI1kF45aOKgJ/HDqqzBIWB6OxmnVF3jDuR+wbgOO73YhkqXPtu 70zlSlXvvcb2Fdmx3+a9+A9soHidIZt7VXOvej0vw/xNd7xubByvU9RFpaAtOfnBOjQy DoZAzGTFsZWmdfD7Tf7VBMGr5eUMdPVSlivbcSTnArGewul23xRr6BnlyAX0VJzF5Atj NHw0sbCffGENtb2jXLM8ADjo8exV5yG0XhJpbVCKlMxGHkE8JIx0XDzXzxvtnju5Z0nC ZYJ+FRjRrqzI6QlBN/6Q7vDzP14IsmVgKjSpPGj9isxjvKOli3T3rYRJF8RmZmSmL1y9 lxDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=9fNAtJJ8Bdtz5IH+iz9y15Tr2IyniXR+ujfWsyluwQ8=; fh=UBq3/OU/Kjy76XBTYuQNkB25dM0rL8fyQjJa77aU1VE=; b=yKqf45vERv9k6/HdMVCrrHC8fHhyHWQwaLNwo+iOMDBLbZBo2gP4n1oVlFFy/hPY5l pB+p55drKmpNRzKZ+moY3mEpbtNUdy526YGhQtpIne+vJyuU1XXBlQPrVapVCYkk7VhK wjMbxa64y1Lt7AZtSXWcUQ7k3JUlSqWf5pkIg7ppN/XK0e7xJ3Spc7iJbpF0Lk7Z572P JqLVv9ccKodTwxFfEu1sDx7eVOB9QlJaouXBDGVe/6ARA4hvVL2Ay5ebeI9aTquEceXh iEh4P51KuNro70c8pJEDaPevU1gD9sMJjbnA6QN2HjDVpOzpMwVvKgKT1nWZmZ7/rny5 SSXw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FW+tQ+qu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-162756-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162756-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d17-20020a170903231100b001ebacdc167bsi2833543plh.594.2024.04.29.10.34.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 10:34:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-162756-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FW+tQ+qu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-162756-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162756-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3CA96B20F21 for ; Mon, 29 Apr 2024 17:31:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C23C7127B69; Mon, 29 Apr 2024 17:30:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FW+tQ+qu" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D132F126F08; Mon, 29 Apr 2024 17:30:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714411845; cv=none; b=s7gqZUgk682nZQ3IB1CyGlhrFCqM9EpSmnbKL2z9Lhf4de7jL3DqnNWGRLtn1xcs1wYIAxRpl1ha8gERgipFYMXo+9TtsrKZcEqyp6UZFhMz/81zT4grF16K+YdYOdvSpS2XXVz0jLkFAaFJ4KtB66fvXFFBUIoXl48EDcsHm6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714411845; c=relaxed/simple; bh=Fvx4HChwgRIpWBOzS/+3wD8TnVRboVAfXw5D+J97/Qg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jPgYgWvYrgjvDdH5TGErHP7UtOCOOwqNY53gzkpjO6gA5rXOx6CkdWHiIGajzVNbn63mwfOAaXMpfb3/ty8KqCN/oUOkETK6NN+ACS7oxSVjoSzPMmWlULHjr6aTAmf8l2AYpVxbcQoKudN6/bqi3C5/7Mntl2CSaI7FclnU+uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FW+tQ+qu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60DE9C113CD; Mon, 29 Apr 2024 17:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714411845; bh=Fvx4HChwgRIpWBOzS/+3wD8TnVRboVAfXw5D+J97/Qg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FW+tQ+qud0THWqc2ik5/R/sUysmBByDgMoTQWtZbn4KQv/Uu79B/VD4cY3VBoXHw5 ELABzGgArhQfCfpFeMWd/vZdlU6YQmmpUOGFiyi30T2jHoXEJI/n5ZTus/IvKbqvVD lKyoayjw+4+0MWp0+Ly8861cJpYEdoRkA9t7kG2rdyZi9Bq8SfVBZUwz6sBqdXyjKi azzQo5sUZ2036U35mt/014/PNT5JNZOw5OpP03ryIuPx77LT+7GUJgiDoTfUnrVVAr asyN4LDM9GHHVknRRUrofKtWHXqM07ZdurQ/olp/GLVcam1xtHT/gRoCqW5++u4dLM LSqYZNQrfAg8A== Message-ID: <8b3c9d34-15d5-4aac-b725-4cc25e469a58@kernel.org> Date: Mon, 29 Apr 2024 19:30:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] arm64: dts: exynos: gs101: Add ufs and ufs-phy dt nodes To: Peter Griffin , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, kernel-team@android.com References: <20240429111537.2369227-1-peter.griffin@linaro.org> <20240429111537.2369227-4-peter.griffin@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240429111537.2369227-4-peter.griffin@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/04/2024 13:15, Peter Griffin wrote: > + ufs_0: ufs@14700000 { > + compatible = "google,gs101-ufs"; > + reg = <0x14700000 0x200>, > + <0x14701100 0x200>, > + <0x14780000 0xa000>, > + <0x14600000 0x100>; > + reg-names = "hci", "vs_hci", "unipro", "ufsp"; > + interrupts = ; > + clocks = <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_ACLK>, > + <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_CLK_UNIPRO>, > + <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_FMP_CLK>, > + <&cmu_hsi2 CLK_GOUT_HSI2_QE_UFS_EMBD_HSI2_ACLK>, > + <&cmu_hsi2 CLK_GOUT_HSI2_QE_UFS_EMBD_HSI2_PCLK>, > + <&cmu_hsi2 CLK_GOUT_HSI2_SYSREG_HSI2_PCLK>; > + clock-names = "core_clk", "sclk_unipro_main", "fmp", > + "aclk", "pclk", "sysreg"; > + freq-table-hz = <0 0>, <0 0>, <0 0>, <0 0>, <0 0>, <0 0>; > + pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>; > + pinctrl-names = "default"; > + phys = <&ufs_0_phy>; > + phy-names = "ufs-phy"; > + samsung,sysreg = <&sysreg_hsi2 0x710>; > + status = "disabled"; > + }; > + > + ufs_0_phy: phy@0x14704000 { Drop 0x from unit address. Best regards, Krzysztof