Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1520207lqa; Mon, 29 Apr 2024 10:41:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVm9FEI/xvuimia53Afk40/XwG7ROVrSs+I5c601FEkPvBtKR+Pca3ikKzZxUf0fvciqShI+IkQdqRAe/QOYOYDPgmL3t5/VgYrapgBDw== X-Google-Smtp-Source: AGHT+IGzvC0O1mtNS9eGyWUbQ3YlJccOW1go4yAnT1o3GspmoPe/Q7tw6ujYX9C/goNt9e/O5gs0 X-Received: by 2002:a17:90b:c91:b0:2a3:ba0:d9f with SMTP id o17-20020a17090b0c9100b002a30ba00d9fmr10431579pjz.11.1714412496530; Mon, 29 Apr 2024 10:41:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714412496; cv=pass; d=google.com; s=arc-20160816; b=kWWAEfse2WimcuTaVjb5Y9NmygzkkE+L4ESTlp7DZBoGYZSHlmu7it6gd0E2vlnM7A wzxT2Lpl6Q/OIF/VB+izGW8bqNaoiIcYkPHcrzto3ICFz9ZQAe1RDf9GCmHJgQz6VJlP fjQv31LF8Gycd2E2/iG4spWHfzSrqN/XhXYN413wmwjZWWrxbK9OglV1hEgsLqjZgmG8 SCjRrBmgH2Y2ReCfpu9QcwAkyNwwR+d2if+kLjYDHwHvM9QubPC0Y1tP/E4GwWd6mEtD M2shOkwT9lS36L4lrVL0DNqXzxA+BRa4yThK5BknfZS6/ehyuFzHxJ1Hmqmr60Ililno tttA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=zDyniUDLX9BN31iT5VmvAaYZ04LeyPffF1ccVkjbzhU=; fh=t1qVYhxaPJzDJLLHUqilzQXhc6fd/cVAZ/NhMNE0noE=; b=gJVZUA0MeaJ4+lzJy1CGSTzxXJLlKO/2opwUs3axQdUuqQComzHzoKqq6PS6h71Yan BpfG97H4COF2C4xBxeW/xQ9kCPivN/U3Ttjnbr7TGXBOw1SpH4jZNLUf5MfgVr6LTdeA oUagIUvMnD6r0dPRn3vFrrQAutWgR8JoQnTsAzPkmLQ3e2uuzEmq3/E6Qv8bXMo0tAL6 4mQkDxA3h3y/XDHju6y9BL6wBNS1oSF6UclRdmCbXT2h0iaka2H5Sxlf0vbbvzJuDVj6 RclI8/r6D4ni2T84++ELucMB8ktgOSSgO86z6OJrGZczNLdL3Awu1hv1N7S50hChQ0QK RoYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iF93v2hv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-162767-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162767-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a6-20020a17090a70c600b002a525340be6si21500698pjm.93.2024.04.29.10.41.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 10:41:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-162767-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iF93v2hv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-162767-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162767-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 94408284607 for ; Mon, 29 Apr 2024 17:40:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5FC27126F3D; Mon, 29 Apr 2024 17:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iF93v2hv" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A5580630; Mon, 29 Apr 2024 17:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714412428; cv=none; b=BcKnU1w2oaNTziDgCXTPDjTBms3j+pWvjFPS+V6VpC+A3FFpMVyIP03gfLyIun6RwSHCMYZ6yQwGJK5y0Cbf+pfeYQv33ezzlRf0Sj/fpi9HlrV4bMNEDkyRWSF5USn7w7J6zeMr6aLoikgUZyyOL9pjAXsHYIosuy7blvmFMvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714412428; c=relaxed/simple; bh=E11Va/fGQEDHKI15S2rcyyuzQ+3AMPPAvFdsSakTQGg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M/VbbNWtRmujlHn5Eiljryp77YX/j0xNTzTWCLqD5O9vbNZcAjjnlutbaurO9kmw5O9C1FotaoeqVzAVWfXH7F35oIt9jnDbg+GJGLDJi+SJr6yJPIVbbOUYzBB78Qv0yFwXYEKkxN4NrYHoGWiraVxftAJHBJBPU97AukEPwPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iF93v2hv; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5111EC113CD; Mon, 29 Apr 2024 17:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714412428; bh=E11Va/fGQEDHKI15S2rcyyuzQ+3AMPPAvFdsSakTQGg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iF93v2hvlLt56jU2WHJ2RyfRv/vPO6wqrX9sMGF7/xMB2jeAXWCfeZRgl7SqDhDcb 4AowmGyxC1i/lzZBLW1bfcIM+9CGscCLTPEjZU5LvY8g0O4+rwepIQVe9p2d7SkkB5 TKKCKcc0yxblXpFaid0P6jQ2N+1jX2s/1AGk7DtOdU6OwVMStQyA13tKPalhCAD9LT 2BLdTA+kKiof/YIuzATMWtuAbzKz5aT13JfwEh1mT/YU39Tl/4Fiqo5O06rPZ5Cx1w duL+Vhjg5nqkc9tzg2M+NEZ/JAMhkup1Rp4xwuAolm8DbMtiOcVsLlSa5RIZvKqdt0 4leSwn0D5efWQ== Date: Mon, 29 Apr 2024 10:40:26 -0700 From: Jakub Kicinski To: Lukasz Majewski Cc: netdev@vger.kernel.org, Paolo Abeni , Casper Andersson , Andrew Lunn , Eric Dumazet , Vladimir Oltean , "David S. Miller" , Oleksij Rempel , Tristram.Ha@microchip.com, Sebastian Andrzej Siewior , Ravi Gunasekaran , Simon Horman , Nikita Zhandarovich , Murali Karicheri , Jiri Pirko , Dan Carpenter , Ziyang Xuan , Shigeru Yoshida , "Ricardo B. Marliere" , linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH] hsr: Simplify code for announcing HSR nodes timer setup Message-ID: <20240429104026.0fe3de0f@kernel.org> In-Reply-To: <20240429120904.2ab5248c@wsk> References: <20240425153958.2326772-1-lukma@denx.de> <20240426173317.2f6228a0@kernel.org> <20240429120904.2ab5248c@wsk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 29 Apr 2024 12:09:04 +0200 Lukasz Majewski wrote: > > if the > > timer is already running we'll mess with the spacing of the frames, > > no? > > When NETDEV_CHANGE is trigger for reason different than carrier (or > port state) change and the netif_oper_up() returns true, the period for > HSR supervisory frames (i.e. HSR_ANNOUNCE_INTEVAL) would be violated. > > What are here the potential threads? Practically speaking I'm not sure if anyone uses any of the weird IFF_* flags, but they are defined in uAPI (enum net_device_flags) and I don't see much validation so presumably it's possible to flip them.