Received-SPF: pass (google.com: domain of linux-kernel+bounces-162788-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: John Garry <john.g.garry@oracle.com>
To: david@fromorbit.com, djwong@kernel.org, hch@lst.de,
        viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
        chandan.babu@oracle.com, willy@infradead.org
Cc: axboe@kernel.dk, martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        ojaswin@linux.ibm.com, ritesh.list@gmail.com, mcgrof@kernel.org,
        p.raghav@samsung.com, linux-xfs@vger.kernel.org,
        catherine.hoang@oracle.com, John Garry <john.g.garry@oracle.com>
Subject: [PATCH v3 01/21] fs: Add generic_atomic_write_valid_size()
Date: Mon, 29 Apr 2024 17:47:26 +0000
Message-Id: <20240429174746.2132161-2-john.g.garry@oracle.com>
In-Reply-To: <20240429174746.2132161-1-john.g.garry@oracle.com>
References: <20240429174746.2132161-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?jqs6r7/eOgqb6n6nBqvWAXyRXIrO3BWMG5ksZF0ZHkzRcOCWL970nVBwbHKu?=
 =?us-ascii?Q?M9pBFhPx6SH+Yaw5yTY+OhRfOJfohUyDOc6icKnG+iVa6pdsWvbYCj3tjKdI?=
 =?us-ascii?Q?Ju3AJtRG212dUwiFjO1rHWIKtznXJQooSg/VYXC2FCHI+GWwAISvbgzLQ4Cz?=
 =?us-ascii?Q?wUHPA7CeOrr/txjvq4J0Io+7E4ktOSqn1SmoIaQq8m260ZhjVMV7iWk3UcwG?=
 =?us-ascii?Q?aw/vEaFv+c6XLAp2forGfsEXW0luloeEkWCpVdN/tJHEzrF+FFzARzjATR8r?=
 =?us-ascii?Q?QOkXASMHdGy8Va3/lfwV3YDY1bznFPs+huhMhDFhK2woIqjryMNODqpN7riA?=
 =?us-ascii?Q?O5XmdXWErb4SvIq/A5RSblFlUZRWjq1k64IOviRsB+uJBdLksYWSadhznlZ6?=
 =?us-ascii?Q?bUvmETkz67zjhSWeL3fjayriHOcSbNNEUuVr9KvvK1+lyy9ry1aV5sUeVj/P?=
 =?us-ascii?Q?IAvD8K4fU51e+xGxEUGlqD7BgSQHyR8e+YLtLP650s3laRFQQdZl3qIfcvn4?=
 =?us-ascii?Q?wJX/Ej/LEUfGCBmA6Y8/QEFPg4Z7Z6yBoYeso0D+dAd9/3ts5Qae9rHogI4q?=
 =?us-ascii?Q?8l7wv13SnTRuFrGqszwooP/8FIyHs9ss4PccanaTPyJMIPRJHXHZwL+8Cb7E?=
 =?us-ascii?Q?AwboqNiRcvXDKr69SF76kQzZbrtxrf6kHUShLq5xcx7NfkXIZbqYuIxaKWmQ?=
 =?us-ascii?Q?53AkaMIJ6lJJw9aj6cy/hvY752io/yxFparScfaWHSklDIlddNiD/uauBen9?=
 =?us-ascii?Q?bNAo8hoMuUYe9ooNn+VyRgHyuSIm1QfQmAwCxRoX2WvmmZkFpVPXPUDz8cAy?=
 =?us-ascii?Q?EelzjdErwuCOtr7cHW8rM1bEFEgUtVp8Ni/BmdgrEIC4F32mWKZP0JmngFr0?=
 =?us-ascii?Q?JQ/mwfqKF5iKw0dh8reVc+ILEpnltJGuUQeb4JTM4hIhf0nOg40EtoN1xbVp?=
 =?us-ascii?Q?1JRoh+lDrDjTnJINkwerwHLhDX5uMdTxYCnKsSmXcgcm7jBwmpfDl9QDtObL?=
 =?us-ascii?Q?VZY5boqLVGpNfLTL2bqLewMIGbNXbOnNdx1VCJwvVh4Hl4vU8yOOBra+rK6O?=
 =?us-ascii?Q?JKKyB1SgkV1iPfBWbkEzwboqTFr/4jiZ/B/kNL13SV6+rjbjcG1U+d1l2mZw?=
 =?us-ascii?Q?o27IcFEFaynzmbqo86nZHFsA0TaBd18ZeVaiBhm0WewpzrO1hzilz5kuKMgi?=
 =?us-ascii?Q?s0rW2lHINgC8S15fKoDAPrzPso8ATuMjBDorP0e9ajEHleM/ly4apK/uN8p5?=
 =?us-ascii?Q?WFXN5LtNbqVl7VVEjhZpkcpSxsdlm0s4NkaumEmbaB1GeEy4r2j9ucs5jU0J?=
 =?us-ascii?Q?5JdY3ZWDsoO3d0e6o20JwEAUoaL6IGCgrcLSkuoZUKHFj2m4o0s8RjCYf/qJ?=
 =?us-ascii?Q?CwsK3Q//aAO/Mv3CXQQeZEbhoDZsLrpNIJGjWXlHg129eSnzhBSqcs7pwtGi?=
 =?us-ascii?Q?VyVT8W39TmCM4YT8yxABaC+zlyHNh/y9tf2LvYny+4FmSymfFZQMJuJWT2Jj?=
 =?us-ascii?Q?Jddg1ZtOJwmM0bNDfQ3GQpXHAUw8wV5CUWAL5cV1MKwLRxkzEtHcAB+Pw7QC?=
 =?us-ascii?Q?1y1Y4Xys5a7cueESnd95gq2hiIK6GtHXaYkyt2huyqtXsR4DWqJljAuKngWv?=
 =?us-ascii?Q?Lg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	BHscyP2YmJjeZq01X69J1MnViHx14w0xfGz2XOgsXAq6rEsItEclego0TbHLXD5TA35WAE8jpFHkHj+r8fIpF2esznxad+wy7hl+wZDUnTUxZ5rJ4icti9lWEc0cr0KtQxL3XZ+akQWT21bCZ7MDJBvBm/GsSnlnoqmm+ui+5LM5sw3OWKkjEVOqS7nU6jCpeyuNLZxexdb1h89+ZGsThrdzqp8OluJ+0yIpUgCWOJ3ZksofTEvvaUihm4Tlz4RiM9nS7OnEKVMIfgtbZcRscRWz37mHzpTXMLJKtFmFa1IDq4Z335EHXOEJea0tzfRJmTJsolYRykrUZUIH23cebrAkij+zaTWkBsikLOmKKC4k5sASxoVz2U0UM1pR1ultWPsbIMsPfH2T03xaa8GyJuEUvY75uIoTZLCFP6QQMk3gKWkLsjNcuxi443BzyCrNooxdMr/6R4XCJDGA2VVuYbk7VLBW3TYCgKRVPpqVMK1GqJdwtAB9R9XP4tIOK+kqsKlcbhsJtlmrumrr2DuaJ/qhD3JgrVSJrfWllb/zGmLv1zzfG08Mtsjpklm0A6gvMCwJ2kgnCtw0H4i30ruTqiO7JwFllZC0UwstW8zNSwI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fbfbcf3-4c58-4f31-f6b9-08dc68748610
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 17:48:05.6125
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zTaK3K2KET+EgypJFluXHVK8BOzJ/P+kyJc6dANu0K6CDsNdf0aCop4dZGOxZk1w5UrEwC63er1+41NJfBTYwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6389
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-29_15,2024-04-29_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404290115
X-Proofpoint-GUID: 3UAwMplDnlAEfmpLs6lZIu2HfnyQCLzq
X-Proofpoint-ORIG-GUID: 3UAwMplDnlAEfmpLs6lZIu2HfnyQCLzq

Add a generic helper for FSes to validate that an atomic write is
appropriately sized (along with the other checks).

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 include/linux/fs.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 6ebefb079740..9bfa9b68d800 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3648,4 +3648,16 @@ bool generic_atomic_write_valid(loff_t pos, struct iov_iter *iter)
 	return true;
 }
 
+static inline
+bool generic_atomic_write_valid_size(loff_t pos, struct iov_iter *iter,
+				unsigned int unit_min, unsigned int unit_max)
+{
+	size_t len = iov_iter_count(iter);
+
+	if (len < unit_min || len > unit_max)
+		return false;
+
+	return generic_atomic_write_valid(pos, iter);
+}
+
 #endif /* _LINUX_FS_H */
-- 
2.31.1