Received-SPF: pass (google.com: domain of linux-kernel+bounces-162798-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: John Garry <john.g.garry@oracle.com>
To: david@fromorbit.com, djwong@kernel.org, hch@lst.de,
        viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
        chandan.babu@oracle.com, willy@infradead.org
Cc: axboe@kernel.dk, martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        ojaswin@linux.ibm.com, ritesh.list@gmail.com, mcgrof@kernel.org,
        p.raghav@samsung.com, linux-xfs@vger.kernel.org,
        catherine.hoang@oracle.com, John Garry <john.g.garry@oracle.com>
Subject: [PATCH v3 21/21] xfs: Support setting FMODE_CAN_ATOMIC_WRITE
Date: Mon, 29 Apr 2024 17:47:46 +0000
Message-Id: <20240429174746.2132161-22-john.g.garry@oracle.com>
In-Reply-To: <20240429174746.2132161-1-john.g.garry@oracle.com>
References: <20240429174746.2132161-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?EzndzFO9mmdOxb0tNu3jSoXQWd9s0JzMC43SbgNQFbpZi159FvdFCf3r40FN?=
 =?us-ascii?Q?7Yhm4zNjsPbVz9N3v0MAcKslAhXagPdWu33SefR1C+HzTw5NzNz1tNjDyzeV?=
 =?us-ascii?Q?atMUbql/LuaqNQXVu5uvm/cshu48TKr52pusXIiiLhA4XQOnvyl0JeFRxzNu?=
 =?us-ascii?Q?4FtuY2MXUEmUW84TcNbyE6biylWUp04p380wwIYsoSNew39IQvyBCT96AJiO?=
 =?us-ascii?Q?1b9xbjE23xIMGSd/mE0zEIiou7K8L9wJCtJRIkbzjuoAZiv81IHCsc4PQ88i?=
 =?us-ascii?Q?AZStcoJO+b0VafA4uWSiiLvQ+OeLVPJmsFNVSlHo4CYUsyTte8FnEHRKrlXL?=
 =?us-ascii?Q?PzSvKpa+597rGMt6oklid7lUVwsNHarxJ4SUkXD8A1kP0JvL92iO2BB8w3lk?=
 =?us-ascii?Q?y8Hg7GoEOoHR/5V7IxEaG1o5YMCkLyLpYjGVBG6A6xHkDfH/gG6mdlxfbNK1?=
 =?us-ascii?Q?aNUNny2dfCjyYHjC5Tbs64zU20IPJQ0Xc/4phUwFnU4cAFUdNuDPqvVV2Abl?=
 =?us-ascii?Q?FNJpucLlaoROOfvA000gYMCHj6oI+HJAomjHn8d5CcneLZXu8oKbHxDTfvpF?=
 =?us-ascii?Q?AAD7PhyZh+bqHtcwf+st0t2mOgu4Ms632MFn36DWmCMBegDt7TZ3hv1j5JM9?=
 =?us-ascii?Q?3nwLrCiIJHH+ozeQZYa8ksUKuXT61rg8dIwqc9hCfa1U6LZNWC8A18M0vNYf?=
 =?us-ascii?Q?6eqTp63Xv9qVGbrJKbWwjDv+NHUZSwc1rozVq41zwcZYR1IXRJlV2dLVTP2B?=
 =?us-ascii?Q?qmqtdhC1me0FgfPD0V2+QctoMEEo7BZzrHF1w1bKjRVzia4PhghhY1F4FLZX?=
 =?us-ascii?Q?DQFXY4anoP3Ac9TVprTgopANe90HjaMtw3v1r7yEFj3At9JVWuLTH8NfpGiD?=
 =?us-ascii?Q?ck7PDo5OCIPUn3Cx1vTMfn5I+oNrpMfqwK2XQCJxYkrZe5Dcu4+aD2Fpo5YM?=
 =?us-ascii?Q?8ILFXKIACVKBCYUTE3+yZjCtxEiLpIdstRq5Cjw2rtcyVoEzDPM5W3mI+W7G?=
 =?us-ascii?Q?+6xVHkSCyfzyQ26eN52RpqeGmffCzYj/4D9sfhZTg84Kme7RsCSumyjMCi7o?=
 =?us-ascii?Q?dnw77XIKtYuaDMsa50GrW2yuAaCxN4fpvtZfTUxTdmRa0eW/89SVVduEbMLP?=
 =?us-ascii?Q?LA6SrHzanT3cgbQja5fmELHFQH0bUSkro4vDiTrOG59xR3U/PMmXaTwU9zOc?=
 =?us-ascii?Q?eG9wpNn/SZRrqc6J/pkI58A80d0uHkU6Pt1vC4wqUjR2AAmOKexxx2V1ovTe?=
 =?us-ascii?Q?JhmDoIY0NZjjZEimCArapqtsFKCZniKVTRDdIxyK9croYbC+0zGk6pmyklQF?=
 =?us-ascii?Q?21O7bIGrqD/jWaPEza1zMaARoX98asi35Rx5HAkZCcdz0WbW2714xzKPEgJa?=
 =?us-ascii?Q?jke3zI1ULiRgLCJGvzadfS9rdmiokeeYnGMjuTTewC5tv/JdK+Lau1d3+Gwe?=
 =?us-ascii?Q?e9OZsoNYc0h1BoGd44snU63Vg5Bsy11ntWBy5BsciJOIWvMbXvhn4x8G+anx?=
 =?us-ascii?Q?3TYwKGeF5cL/kBDZpBd9rQ1HT5jxrbH1HjsuKVxeGkiZVJvoEWc/aHaeN6Cs?=
 =?us-ascii?Q?vU+eDvv5uws/hjzpzAlXFVhmbMVYpuU6kF5gD4sAZDU69TQWa4/O1/Lo/fzo?=
 =?us-ascii?Q?PA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	DCL+H1S7IGw/NpvVz24OvjhZPYHXEQN6Te+vOujKE3hqMZx8+b8VQLC8yBL2Te+BGu8fdVtmivQ5GN8XODQW5lz1atDTWd+Z/FzGpEijbOZZjVkyZS/B64FLJybFB+GMVrEUaId1Nx75w8K1N0DWwpmGVNskVElUlQHcgrk0u2PNi1QQorJQa1HHbXY8mgtUdmujjBqC+b3zXoTKkh+f27Yg64K20vOpCDW8xxyk7ZqVPapKpjNSVsS31kgX2L7LgkOMhUXpgF2Nm9Dy1cxwb7W2JhBDvcSZ6QE3wctDklbIk8opa7hVoSVPeNUSHioXWkNoGXvklhdmcPHcQK9G2IUgR8l6jngvP5IDfCfw0S3mBhqPsWhsVJ13cjT8TPtlWr75GwO1ndNe3dK5yXC97uwMrE62hn/dVq6zAisiUeeQ59S0fpAaU/J/vVIwebZ8OqKLhIELS89SJq7biBz+RUMfg44EX96ZQCeDcgzX0w0vSjSa3DS//5ZZg21UakBnI6V6FNOVeXAhaVWlqcgjcK6/bXp7PtWr/zvSaZQZmNhjiIgZ+5ULNxu28xD9qWH2YfxDZgzNcoMJie8brMRESOgVBELOJd2NPfERi3wvczk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14d95c22-3e3a-4629-bf1e-08dc6874a3ac
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 17:48:55.2732
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cs7qsxWzzj4L6buyIbrWfBPdt/uRID1FcPHgOzUjT+38Fdke7YuUQNFhcfkNKz7+w3b1lkZoyTVhyXFSfqZUhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7763
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-29_15,2024-04-29_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404290115
X-Proofpoint-GUID: u710AV0qDp4fnXW7X_rA97Mn2cxLE4v-
X-Proofpoint-ORIG-GUID: u710AV0qDp4fnXW7X_rA97Mn2cxLE4v-

For when an inode is enabled for atomic writes, set FMODE_CAN_ATOMIC_WRITE
flag. Only direct IO is currently supported, so check for that also.

We rely on the block layer to reject atomic writes which exceed the bdev
request_queue limits, so don't bother checking any such thing here.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 fs/xfs/xfs_file.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 256d05c1be6a..5a17748eb6bd 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1243,6 +1243,18 @@ xfs_file_remap_range(
 	return remapped > 0 ? remapped : ret;
 }
 
+static bool xfs_file_open_can_atomicwrite(
+	struct inode		*inode,
+	struct file		*file)
+{
+	struct xfs_inode	*ip = XFS_I(inode);
+
+	if (!(file->f_flags & O_DIRECT))
+		return false;
+
+	return xfs_inode_has_atomicwrites(ip);
+}
+
 STATIC int
 xfs_file_open(
 	struct inode	*inode,
@@ -1252,6 +1264,8 @@ xfs_file_open(
 		return -EIO;
 	file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC | FMODE_BUF_WASYNC |
 			FMODE_DIO_PARALLEL_WRITE | FMODE_CAN_ODIRECT;
+	if (xfs_file_open_can_atomicwrite(inode, file))
+		file->f_mode |= FMODE_CAN_ATOMIC_WRITE;
 	return generic_file_open(inode, file);
 }
 
-- 
2.31.1