Received-SPF: pass (google.com: domain of linux-kernel+bounces-162810-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 29 Apr 2024 13:56:58 -0400
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-pci@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 11/11] PCI: imx6: Add i.MX8Q PCIe support
Message-ID: <Zi/faud9ZrlsA9us@lizhi-Precision-Tower-5810>
References: <20240402-pci2_upstream-v3-0-803414bdb430@nxp.com>
 <20240402-pci2_upstream-v3-11-803414bdb430@nxp.com>
 <20240427114736.GO1981@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240427114736.GO1981@thinkpad>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VmRDM3dQYUpta09zUVJPT0src1JRQjQ1aUdrYlc3V29HSjhPUWN3QWxtcFNZ?=
 =?utf-8?B?SGlncCtKNkJRMHduTDg3ajdVVlRKdHh4b2NDTXpsOFFac0RHTlpjZXVtbWJD?=
 =?utf-8?B?TG9LeENZclVINWU1bldHZUZaeHRIY2hBOXZIVjZ5UktPS1pVbXBCb0NCUzZE?=
 =?utf-8?B?cUYyNUJoZFlYZUNYcmZYdEU5TCtxMUd2UDcwYUFrZnZva0o1YSsxMm1yMEJs?=
 =?utf-8?B?dURkQUJpOXE0Y2l4dm5helNkQ2RLN2s2VzFmQVV5djF4QzZDU0NBSWNyTHUv?=
 =?utf-8?B?WTNicEU1TVJyNHpLT2JOTmNpOFcrbm40QUJoRm04L3RkL2tIWUV6d05VTkor?=
 =?utf-8?B?WTZDYnJZd0ljNmJ4alprSzJBOWFQYjlqNlhVZmE2WXdiWUU2QlYvTzVJb1Bp?=
 =?utf-8?B?c21QNW1nQWd2ZFRpYkJva3V6SkwrWUFvek5UalBTcWJkZ1FJY1N6ZlJlQXBv?=
 =?utf-8?B?Mk9Pa0RiUnh1ZXRxbUwwL1JXMkhqOGtnbjRycFFLaEc2ZEYvWEhTNDVkZTdu?=
 =?utf-8?B?U053RnpLTzZrMDVsQXVOMzQwSGlxVjR5b1dzTk1lZUYxQUNQNGlUSWwraHJI?=
 =?utf-8?B?QVQ5b2d2VlFQQ2NKTnp5YzVOd2VaeW9YYmJncUR5YUpxOHdJRnQ3VUpFRGJJ?=
 =?utf-8?B?NnFJQklFRGtoVUtuTWhueGQrZStIWkg4dXQyZ0NVUEZ6YXA3eVNScXlrTkVs?=
 =?utf-8?B?eXJjVmpqOWpkYWZ3RE85STBsdmZkM1FyS0J0NFVqTElyVEl4NlZ6YzR6UTBG?=
 =?utf-8?B?VzZqZldWMGd1aXM1ZUhOQVg4dU5tYzArVDlma1JuNkdrR2I2Y2xCczBCVGNK?=
 =?utf-8?B?M2RjUWlZWUdhelBRb3ZqUTBlZ3B0eFJiRm4zTk95Q1g2dFpyYkNKSEF3NkhT?=
 =?utf-8?B?ZEVrTnFlWXZ3dVRGNUZMRmFKN0dBc3F0NTZyeEMwLzF2NFhmMVo3RTRDOFM3?=
 =?utf-8?B?NzlCTGxTR3BkTXBEM29zNStNeGhOQnNMRTFzcTE3SDlGQ3VNbnhFc2wvMWlS?=
 =?utf-8?B?MHgxRERuNDJwbHI2UzlyM1kwWmtkTkI0cDd5UnJDdGhEdk1ZbWJvSTRPWThl?=
 =?utf-8?B?TVJTcjN6OUR4bUJtYmNWVjVRK0NydVZkQnErcW41dVc1K2JKajJFTThOU1Bh?=
 =?utf-8?B?T1RrNVJvWGZseUY3clVkSmlMcExqN0xGbnJtM3Q3N0lOb0tPQjkyRjNEMUN0?=
 =?utf-8?B?TVNCQ3QzZ2lUdnVtdEFsd1dnL1ZBR0JZRzFXTkRmWHNZTnhPMGRrRE10MGZK?=
 =?utf-8?B?ZmtJRU4zdXlRMk9COHNYeHZVMUJBMDN3UnlTRHNmNUprd0xISVk5NlF3eUZw?=
 =?utf-8?B?M0VOVGZLY0x4NkV4Q3NvQnZDcGsvSFJhSXVWWW5aN3MxaHdVYWlvMDdQOEM2?=
 =?utf-8?B?UHg2ektrZFViUS9scEJLUm9wT1RoZ0xqa2NZN3E4aXhQNDhac2JOWVRWSUdM?=
 =?utf-8?B?amdNYU1rMHdFWjVjTnd4L3JVZkhaUndvWlBPV2locGNaZlhZdHB2N0FNek9y?=
 =?utf-8?B?TEEvT1JESEVUYmhhbEZ5MHJmRk15VVVNZUU0c1dUdHpkQ1JPVjlMME1XbWE4?=
 =?utf-8?B?aW5Ia09BWnR5Slc0SDZVcVNzL0Y0RkxKeC81c0hOY0s1Y2prZzl5cFY4Sld3?=
 =?utf-8?B?NURpemZhWlgxRmpaUnRjeEtLcXRJSjFHNFVqTVk3WStvdXFrSHZRcXpFZ2RO?=
 =?utf-8?B?aFdpeURpbWFJcU0xYXJpa1QvRkg0dFRBSzVHajd0OWxYU2d1eGZ2VDZ4K3BW?=
 =?utf-8?B?SmpOL0k0T2E2MFF6YjNobWhlMlRpSVZ4WVZlQzlraCtWS0NiTHlwbGxQeUZP?=
 =?utf-8?B?cC9ueCtlTmxhYlk1VkNyTlJUUGpqNzkrU05XaTV2Y05kRHhyZmRoTVVZcXps?=
 =?utf-8?B?UWsxNWxPYnlaREFSU3d6ZEdKb3hkcGRtTHlWb25YL2FlalZxdU9WbmlHbThs?=
 =?utf-8?B?NVRwUHpoU1JUSVhhTHhVNGdYaGFhWHV1VzROY2VTZnVuTEtFUTh1a29weXVx?=
 =?utf-8?B?V1JZcUlFNE5vdnI3cnhVdXhUa3JvaS83YmxyVnRxZm4zd1BsTGJCYkovWWEz?=
 =?utf-8?B?aEV4ZjdxMThKcnBtbGwvQ3ZqR0FIempQa25ab1lTbC9NY1JCNmZUNmhXQmc5?=
 =?utf-8?Q?aCDw=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a44e171c-6efb-4571-69aa-08dc6875c9b3
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 17:57:08.5190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 08yrVakjn/kK0Bj6sqdoVZY5AUEROAfewkmPL3bEwe5Ixwps5vx8YP0YmQPGfkVbbDH4t4BRhyJsFIbSC7W/eA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8042

On Sat, Apr 27, 2024 at 05:17:36PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Apr 02, 2024 at 10:33:47AM -0400, Frank Li wrote:
> > From: Richard Zhu <hongxing.zhu@nxp.com>
> > 
> > Add i.MX8Q (i.MX8QM, i.MX8QXP and i.MX8DXL) PCIe support.
> > 
> 
> Add some info like IP version, PCIe Gen, how different the code support
> comparted to previous SoCs etc...
> 
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  drivers/pci/controller/dwc/pcie-imx.c | 54 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/pcie-imx.c b/drivers/pci/controller/dwc/pcie-imx.c
> > index 378808262d16b..af7c79e869e70 100644
> > --- a/drivers/pci/controller/dwc/pcie-imx.c
> > +++ b/drivers/pci/controller/dwc/pcie-imx.c
> > @@ -30,6 +30,7 @@
> >  #include <linux/interrupt.h>
> >  #include <linux/reset.h>
> >  #include <linux/phy/phy.h>
> > +#include <linux/phy/pcie.h>
> >  #include <linux/pm_domain.h>
> >  #include <linux/pm_runtime.h>
> >  
> > @@ -81,6 +82,7 @@ enum imx_pcie_variants {
> >  	IMX8MQ,
> >  	IMX8MM,
> >  	IMX8MP,
> > +	IMX8Q,
> >  	IMX95,
> >  	IMX8MQ_EP,
> >  	IMX8MM_EP,
> > @@ -96,6 +98,7 @@ enum imx_pcie_variants {
> >  #define IMX_PCIE_FLAG_HAS_PHY_RESET		BIT(5)
> >  #define IMX_PCIE_FLAG_HAS_SERDES		BIT(6)
> >  #define IMX_PCIE_FLAG_SUPPORT_64BIT		BIT(7)
> > +#define IMX_PCIE_FLAG_CPU_ADDR_FIXUP		BIT(8)
> >  
> >  #define imx_check_flag(pci, val)     (pci->drvdata->flags & val)
> >  
> > @@ -132,6 +135,7 @@ struct imx_pcie {
> >  	struct regmap		*iomuxc_gpr;
> >  	u16			msi_ctrl;
> >  	u32			controller_id;
> > +	u32			local_addr;
> >  	struct reset_control	*pciephy_reset;
> >  	struct reset_control	*apps_reset;
> >  	struct reset_control	*turnoff_reset;
> > @@ -402,6 +406,10 @@ static void imx_pcie_configure_type(struct imx_pcie *imx_pcie)
> >  	if (!drvdata->mode_mask[id])
> >  		id = 0;
> >  
> > +	/* If mode_mask is 0, means use phy driver to set mode */
> > +	if (!drvdata->mode_mask[id])
> > +		return;
> 
> There is already a check above for 0 mode_mask. Please consolidate.
> 
> > +
> >  	mask = drvdata->mode_mask[id];
> >  	val = mode << (ffs(mask) - 1);
> >  
> > @@ -957,6 +965,7 @@ static void imx_pcie_ltssm_enable(struct device *dev)
> >  	struct imx_pcie *imx_pcie = dev_get_drvdata(dev);
> >  	const struct imx_pcie_drvdata *drvdata = imx_pcie->drvdata;
> >  
> > +	phy_set_speed(imx_pcie->phy, PCI_EXP_LNKCAP_SLS_2_5GB);
> >  	if (drvdata->ltssm_mask)
> >  		regmap_update_bits(imx_pcie->iomuxc_gpr, drvdata->ltssm_off, drvdata->ltssm_mask,
> >  				   drvdata->ltssm_mask);
> > @@ -969,6 +978,7 @@ static void imx_pcie_ltssm_disable(struct device *dev)
> >  	struct imx_pcie *imx_pcie = dev_get_drvdata(dev);
> >  	const struct imx_pcie_drvdata *drvdata = imx_pcie->drvdata;
> >  
> > +	phy_set_speed(imx_pcie->phy, 0);
> >  	if (drvdata->ltssm_mask)
> >  		regmap_update_bits(imx_pcie->iomuxc_gpr, drvdata->ltssm_off,
> >  				   drvdata->ltssm_mask, 0);
> > @@ -1104,6 +1114,12 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp)
> >  			goto err_clk_disable;
> >  		}
> >  
> > +		ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE, PHY_MODE_PCIE_RC);
> > +		if (ret) {
> > +			dev_err(dev, "unable to set pcie PHY mode\n");
> > +			goto err_phy_off;
> > +		}
> 
> This is not i.MX8Q specific. Please add it in a separate patch.
> 
> > +
> >  		ret = phy_power_on(imx_pcie->phy);
> >  		if (ret) {
> >  			dev_err(dev, "waiting for PHY ready timeout!\n");
> > @@ -1154,6 +1170,28 @@ static void imx_pcie_host_exit(struct dw_pcie_rp *pp)
> >  		regulator_disable(imx_pcie->vpcie);
> >  }
> >  
> > +static u64 imx_pcie_cpu_addr_fixup(struct dw_pcie *pcie, u64 cpu_addr)
> > +{
> > +	struct imx_pcie *imx_pcie = to_imx_pcie(pcie);
> > +	struct dw_pcie_ep *ep = &pcie->ep;
> > +	struct dw_pcie_rp *pp = &pcie->pp;
> > +	struct resource_entry *entry;
> > +	unsigned int offset;
> > +
> > +	if (!(imx_pcie->drvdata->flags & IMX_PCIE_FLAG_CPU_ADDR_FIXUP))
> 
> This flag should be documented in the commit message.
> 
> > +		return cpu_addr;
> > +
> > +	if (imx_pcie->drvdata->mode == DW_PCIE_EP_TYPE) {
> > +		offset = ep->phys_base;
> > +	} else {
> > +		entry = resource_list_first_type(&pp->bridge->windows,
> > +						 IORESOURCE_MEM);
> 
> Check for NULL entry.
> 
> > +		offset = entry->res->start;
> > +	}
> > +
> > +	return (cpu_addr + imx_pcie->local_addr - offset);
> > +}
> > +
> >  static const struct dw_pcie_host_ops imx_pcie_host_ops = {
> >  	.init = imx_pcie_host_init,
> >  	.deinit = imx_pcie_host_exit,
> > @@ -1162,6 +1200,7 @@ static const struct dw_pcie_host_ops imx_pcie_host_ops = {
> >  static const struct dw_pcie_ops dw_pcie_ops = {
> >  	.start_link = imx_pcie_start_link,
> >  	.stop_link = imx_pcie_stop_link,
> > +	.cpu_addr_fixup = imx_pcie_cpu_addr_fixup,
> >  };
> >  
> >  static void imx_pcie_ep_init(struct dw_pcie_ep *ep)
> > @@ -1481,6 +1520,12 @@ static int imx_pcie_probe(struct platform_device *pdev)
> >  					     "Failed to get PCIEPHY reset control\n");
> >  	}
> >  
> > +	if (imx_check_flag(imx_pcie, IMX_PCIE_FLAG_CPU_ADDR_FIXUP)) {
> > +		ret = of_property_read_u32(node, "fsl,local-address", &imx_pcie->local_addr);
> > +		if (ret)
> > +			return dev_err_probe(dev, ret, "Failed to get local-address");
> 
> Is it OK to continue?

No, if no "fsl,local-address" for iMX8QM/QXP, address map will be wrong. 

Frank

> 
> - Mani
> 
> -- 
> மணிவண்ணன் சதாசிவம்